ShipmentTotalWeight::getUnitOfMeasurement() - Code Metrics - Inspection of "Added shipment total weight to rate (adjusted, clo..." - gabrielbull/php-ups-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#211)

by Stefan

created 2018-04-09 12:51 UTC

ShipmentTotalWeight::getUnitOfMeasurement() A

↳ Parent: ShipmentTotalWeight

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Ups\Entity;

use DOMDocument;
use DOMElement;
use Ups\NodeInterface;
use Ups\Entity\UnitOfMeasurement;

class ShipmentTotalWeight implements NodeInterface
{
    /**
     * @var UnitOfMeasurement
     */
    private $unitOfMeasurement;

    /**
     * @var string
     */
    private $weight;

    public function __construct($response = null)

    {
        if (null !== $response) {
            if (isset($response->unitOfMeasurement)) {
                $this->setUnitOfMeasurement(new UnitOfMeasurement($response->unitOfMeasurement));
            }
            if (isset($response->Weight)) {
                $this->setWeight($response->Weight);
            }
        }
    }

    /**
     * @param null|DOMDocument $document
     *
     * @return DOMElement
     */
    public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }

        $node = $document->createElement('ShipmentTotalWeight');
        if ($this->getUnitOfMeasurement()) {
            $node->appendChild($this->getUnitOfMeasurement()->toNode($document));
        }

        $node->appendChild($document->createElement('Weight', $this->getWeight()));
        
        return $node;
    }

    /**
     * @return UnitOfMeasurement
     */
    public function getUnitOfMeasurement()
    {
        return $this->unitOfMeasurement;
    }

    /**
     * @param UnitOfMeasurement $unitOfMeasurement
     */
    public function setUnitOfMeasurement(UnitOfMeasurement $unitOfMeasurement)
    {
        $this->unitOfMeasurement = $unitOfMeasurement;
    }

    /**
     * @return int
     */
    public function getWeight()
    {
        return $this->weight;
    }
    
    /**
     * @param string $weight
     */
    public function setWeight($weight)
    {
        if (!is_numeric($weight)) {
            throw new \Exception('Weight value should be a numeric value');
        }

        $this->weight = $weight;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }
}


1		<?php
2
3		namespace Ups\Entity;
4
5		use DOMDocument;
6		use DOMElement;
7		use Ups\NodeInterface;
8		use Ups\Entity\UnitOfMeasurement;
9
10		class ShipmentTotalWeight implements NodeInterface
11		{
12		/**
13		* @var UnitOfMeasurement
14		*/
15		private $unitOfMeasurement;
16
17		/**
18		* @var string
19		*/
20		private $weight;
21
22	View Code Duplication	public function __construct($response = null)
		0 ignored issues – show Duplication introduced 2017-08-03 13:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		if (null !== $response) {
25		if (isset($response->unitOfMeasurement)) {
26		$this->setUnitOfMeasurement(new UnitOfMeasurement($response->unitOfMeasurement));
27		}
28		if (isset($response->Weight)) {
29		$this->setWeight($response->Weight);
30		}
31		}
32		}
33
34		/**
35		* @param null\|DOMDocument $document
36		*
37		* @return DOMElement
38		*/
39		public function toNode(DOMDocument $document = null)
40		{
41		if (null === $document) {
42		$document = new DOMDocument();
43		}
44
45		$node = $document->createElement('ShipmentTotalWeight');
46		if ($this->getUnitOfMeasurement()) {
47		$node->appendChild($this->getUnitOfMeasurement()->toNode($document));
48		}
49
50		$node->appendChild($document->createElement('Weight', $this->getWeight()));
51
52		return $node;
53		}
54
55		/**
56		* @return UnitOfMeasurement
57		*/
58		public function getUnitOfMeasurement()
59		{
60		return $this->unitOfMeasurement;
61		}
62
63		/**
64		* @param UnitOfMeasurement $unitOfMeasurement
65		*/
66		public function setUnitOfMeasurement(UnitOfMeasurement $unitOfMeasurement)
67		{
68		$this->unitOfMeasurement = $unitOfMeasurement;
69		}
70
71		/**
72		* @return int
73		*/
74		public function getWeight()
75		{
76		return $this->weight;
77		}
78
79		/**
80		* @param string $weight
81		*/
82		public function setWeight($weight)
83		{
84		if (!is_numeric($weight)) {
85		throw new \Exception('Weight value should be a numeric value');
86		}
87
88		$this->weight = $weight;
		0 ignored issues – show Documentation Bug introduced 2018-04-09 12:55 UTC by Report Bug Copy Issue Report It seems like `$weight` can also be of type `integer` or `double`. However, the property `$weight` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
89		}
90		}
91

gabrielbull / php-ups-api

Pull Request — master (#211)

ShipmentTotalWeight::getUnitOfMeasurement() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like