Quantity::setUnitOfMeasurement() - Code Metrics - Inspection of "Seeing if this workaround will fix the hhvm issue..." - gabrielbull/php-ups-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#223)

unknown

created 2018-08-16 21:03 UTC

Quantity::setUnitOfMeasurement() A

↳ Parent: Quantity

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	6
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	6
loc	6
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace Ups\Entity\Tradeability;

use DOMDocument;
use DOMElement;
use Ups\NodeInterface;

/**
 * Class Quantity.
 */
class Quantity implements NodeInterface

{

    /**
     * @var UnitOfMeasurement
     */
    private $unitOfMeasurement;

    /**
     * @var int
     */
    private $value;

    /**
     * @param null|DOMDocument $document
     *
     * @return DOMElement
     */
    public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }

        $node = $document->createElement('Quantity');

        // Required
        $node->appendChild($document->createElement('Value', $this->getValue()));

        // Optional
        if ($this->getUnitOfMeasurement() instanceof UnitOfMeasurement) {
            $node->appendChild($this->getUnitOfMeasurement()->toNode($document));
        }

        return $node;
    }

    /**
     * @return int
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @param int $value
     * @return Quantity
     */
    public function setValue($value)
    {
        $this->value = $value;

        return $this;
    }

    /**
     * @return UnitOfMeasurement
     */
    public function getUnitOfMeasurement()
    {
        return $this->unitOfMeasurement;
    }

    /**
     * @param UnitOfMeasurement $unitOfMeasurement
     * @return Quantity
     */
    public function setUnitOfMeasurement(UnitOfMeasurement $unitOfMeasurement)
    {
        $this->unitOfMeasurement = $unitOfMeasurement;

        return $this;
    }
}


1			<?php
2
3			namespace Ups\Entity\Tradeability;
4
5			use DOMDocument;
6			use DOMElement;
7			use Ups\NodeInterface;
8
9			/**
10			* Class Quantity.
11			*/
12		View Code Duplication	class Quantity implements NodeInterface
			0 ignored issues – show Duplication introduced 2015-11-23 16:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13			{
14
15			/**
16			* @var UnitOfMeasurement
17			*/
18			private $unitOfMeasurement;
19
20			/**
21			* @var int
22			*/
23			private $value;
24
25			/**
26			* @param null\|DOMDocument $document
27			*
28			* @return DOMElement
29			*/
30	1		public function toNode(DOMDocument $document = null)
31			{
32	1		if (null === $document) {
33			$document = new DOMDocument();
34			}
35
36	1		$node = $document->createElement('Quantity');
37
38			// Required
39	1		$node->appendChild($document->createElement('Value', $this->getValue()));
40
41			// Optional
42	1		if ($this->getUnitOfMeasurement() instanceof UnitOfMeasurement) {
43			$node->appendChild($this->getUnitOfMeasurement()->toNode($document));
44			}
45
46	1		return $node;
47			}
48
49			/**
50			* @return int
51			*/
52	1		public function getValue()
53			{
54	1		return $this->value;
55			}
56
57			/**
58			* @param int $value
59			* @return Quantity
60			*/
61			public function setValue($value)
62			{
63			$this->value = $value;
64
65			return $this;
66			}
67
68			/**
69			* @return UnitOfMeasurement
70			*/
71	1		public function getUnitOfMeasurement()
72			{
73	1		return $this->unitOfMeasurement;
74			}
75
76			/**
77			* @param UnitOfMeasurement $unitOfMeasurement
78			* @return Quantity
79			*/
80			public function setUnitOfMeasurement(UnitOfMeasurement $unitOfMeasurement)
81			{
82			$this->unitOfMeasurement = $unitOfMeasurement;
83
84			return $this;
85			}
86			}
87

gabrielbull / php-ups-api

Pull Request — master (#223)

Quantity::setUnitOfMeasurement() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like