FreightCharges::getCurrencyCode() - Code Metrics - Inspection of "Seeing if this workaround will fix the hhvm issue..." - gabrielbull/php-ups-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#223)

unknown

created 2018-08-16 21:03 UTC

FreightCharges::getCurrencyCode() A

↳ Parent: FreightCharges

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace Ups\Entity\Tradeability;

use DOMDocument;
use DOMElement;

class FreightCharges extends \Ups\Entity\FreightCharges
{
    private $currencyCode;

    public function __construct($response = null)
    {
        if (null !== $response) {
            if (isset($response->CurrencyCode)) {
                $this->setCurrencyCode($response->CurrencyCode);
            }
        }

        parent::__construct($response);
    }

    /**
     * @param null|DOMDocument $document
     *
     * @return DOMElement
     */
    public function toNode(DOMDocument $document = null)

    {
        if (null === $document) {
            $document = new DOMDocument();
        }

        $node = $document->createElement('FreightCharges');
        $node->appendChild($document->createElement('MonetaryValue', $this->getMonetaryValue()));
        $node->appendChild($document->createElement('CurrencyCode', $this->getCurrencyCode()));

        return $node;
    }

    /**
     * @return mixed
     */
    public function getCurrencyCode()
    {
        return $this->currencyCode;
    }

    /**
     * @param mixed $currencyCode
     */
    public function setCurrencyCode($currencyCode)
    {
        $this->currencyCode = $currencyCode;
    }
}


1			<?php
2
3			namespace Ups\Entity\Tradeability;
4
5			use DOMDocument;
6			use DOMElement;
7
8			class FreightCharges extends \Ups\Entity\FreightCharges
9			{
10			private $currencyCode;
11
12	1		public function __construct($response = null)
13			{
14	1		if (null !== $response) {
15			if (isset($response->CurrencyCode)) {
16			$this->setCurrencyCode($response->CurrencyCode);
17			}
18			}
19
20	1		parent::__construct($response);
21	1		}
22
23			/**
24			* @param null\|DOMDocument $document
25			*
26			* @return DOMElement
27			*/
28	1	View Code Duplication	public function toNode(DOMDocument $document = null)
			0 ignored issues – show Duplication introduced 2017-08-03 08:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29			{
30	1		if (null === $document) {
31			$document = new DOMDocument();
32			}
33
34	1		$node = $document->createElement('FreightCharges');
35	1		$node->appendChild($document->createElement('MonetaryValue', $this->getMonetaryValue()));
36	1		$node->appendChild($document->createElement('CurrencyCode', $this->getCurrencyCode()));
37
38	1		return $node;
39			}
40
41			/**
42			* @return mixed
43			*/
44	1		public function getCurrencyCode()
45			{
46	1		return $this->currencyCode;
47			}
48
49			/**
50			* @param mixed $currencyCode
51			*/
52			public function setCurrencyCode($currencyCode)
53			{
54			$this->currencyCode = $currencyCode;
55			}
56			}
57

gabrielbull / php-ups-api

Pull Request — master (#223)

FreightCharges::getCurrencyCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like