EstimatedArrival::getTime() - Code Metrics - Inspection of "Implement Ratetimeintransit and Shoptimeintransit..." - gabrielbull/php-ups-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#145)

unknown

created 2017-03-09 23:15 UTC

EstimatedArrival::getTime() A

↳ Parent: EstimatedArrival

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Ups\Entity;

class EstimatedArrival extends Rate\EstimatedArrival
{
    const EA_MONDAY = 'MON';
    const EA_TUESDAY = 'TUE';
    const EA_WEDNESDAY = 'WEB';
    const EA_THUSDAY = 'THU';
    const EA_FRIDAY = 'FRI';
    const EA_SATURDAY = 'SAT';
    // Sunday is an invalid day :-)

    private $Time;
    private $PickupDate;
    private $PickupTime;
    private $DelayCount;

    private $Date;

    /**
     * @param \stdClass|null $response
     */
    public function __construct(\stdClass $response = null)

    {
        parent::__construct($response);

        if (null !== $response) {
            if (isset($response->Time)) {
                $this->Time = $response->Time;
            }
            if (isset($response->PickupDate)) {
                $this->PickupDate = $response->PickupDate;
            }
            if (isset($response->PickupTime)) {
                $this->PickupTime = $response->PickupTime;
            }
            if (isset($response->DelayCount)) {
                $this->DelayCount = $response->DelayCount;
            }
            if (isset($response->Date)) {
                $this->Date = $response->Date;
            }
        }
    }

    /**
     * @return mixed
     */
    public function getTime()
    {
        return $this->Time;
    }

    /**
     * @param mixed $Time
     */
    public function setTime($Time)
    {
        $this->Time = $Time;
    }

    /**
     * @return mixed
     */
    public function getPickupDate()
    {
        return $this->PickupDate;
    }

    /**
     * @param mixed $PickupDate
     */
    public function setPickupDate($PickupDate)
    {
        $this->PickupDate = $PickupDate;
    }

    /**
     * @return mixed
     */
    public function getPickupTime()
    {
        return $this->PickupTime;
    }

    /**
     * @param mixed $PickupTime
     */
    public function setPickupTime($PickupTime)
    {
        $this->PickupTime = $PickupTime;
    }

    /**
     * @return mixed
     */
    public function getDelayCount()
    {
        return $this->DelayCount;
    }

    /**
     * @param mixed $DelayCount
     */
    public function setDelayCount($DelayCount)
    {
        $this->DelayCount = $DelayCount;
    }

    /**
     * @return mixed
     */
    public function getDate()
    {
        return $this->Date;
    }

    /**
     * @param mixed $Date
     */
    public function setDate($Date)
    {
        $this->Date = $Date;
    }

}


1			<?php
2
3			namespace Ups\Entity;
4
5			class EstimatedArrival extends Rate\EstimatedArrival
6			{
7			const EA_MONDAY = 'MON';
8			const EA_TUESDAY = 'TUE';
9			const EA_WEDNESDAY = 'WEB';
10			const EA_THUSDAY = 'THU';
11			const EA_FRIDAY = 'FRI';
12			const EA_SATURDAY = 'SAT';
13			// Sunday is an invalid day :-)
14
15			private $Time;
16			private $PickupDate;
17			private $PickupTime;
18			private $DelayCount;
			0 ignored issues – show Comprehensibility introduced 2017-02-16 00:54 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
19			private $Date;
20
21			/**
22			* @param \stdClass\|null $response
23			*/
24	5	View Code Duplication	public function __construct(\stdClass $response = null)
			0 ignored issues – show Duplication introduced 2017-02-16 00:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25			{
26	5		parent::__construct($response);
27
28	5		if (null !== $response) {
29	3		if (isset($response->Time)) {
30	3		$this->Time = $response->Time;
31	3		}
32	3		if (isset($response->PickupDate)) {
33	3		$this->PickupDate = $response->PickupDate;
34	3		}
35	3		if (isset($response->PickupTime)) {
36	3		$this->PickupTime = $response->PickupTime;
37	3		}
38	3		if (isset($response->DelayCount)) {
39	3		$this->DelayCount = $response->DelayCount;
40	3		}
41	3		if (isset($response->Date)) {
42	3		$this->Date = $response->Date;
43	3		}
44	3		}
45	5		}
46
47			/**
48			* @return mixed
49			*/
50			public function getTime()
51			{
52			return $this->Time;
53			}
54
55			/**
56			* @param mixed $Time
57			*/
58			public function setTime($Time)
59			{
60			$this->Time = $Time;
61			}
62
63			/**
64			* @return mixed
65			*/
66			public function getPickupDate()
67			{
68			return $this->PickupDate;
69			}
70
71			/**
72			* @param mixed $PickupDate
73			*/
74			public function setPickupDate($PickupDate)
75			{
76			$this->PickupDate = $PickupDate;
77			}
78
79			/**
80			* @return mixed
81			*/
82			public function getPickupTime()
83			{
84			return $this->PickupTime;
85			}
86
87			/**
88			* @param mixed $PickupTime
89			*/
90			public function setPickupTime($PickupTime)
91			{
92			$this->PickupTime = $PickupTime;
93			}
94
95			/**
96			* @return mixed
97			*/
98			public function getDelayCount()
99			{
100			return $this->DelayCount;
101			}
102
103			/**
104			* @param mixed $DelayCount
105			*/
106			public function setDelayCount($DelayCount)
107			{
108			$this->DelayCount = $DelayCount;
109			}
110
111			/**
112			* @return mixed
113			*/
114			public function getDate()
115			{
116			return $this->Date;
117			}
118
119			/**
120			* @param mixed $Date
121			*/
122			public function setDate($Date)
123			{
124			$this->Date = $Date;
125			}
126
127			}
128

gabrielbull / php-ups-api

Pull Request — master (#145)

EstimatedArrival::getTime() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like