ItemizedPaymentInformation::setDutyAndTax() - Code Metrics - Inspection of "Add ItemizedPaymentInformation. Only applied when..." - gabrielbull/php-ups-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#151)

unknown

created 2017-03-07 17:43 UTC

ItemizedPaymentInformation::setDutyAndTax() A

↳ Parent: ItemizedPaymentInformation

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace Ups\Entity;

use DOMDocument;

class ItemizedPaymentInformation
{

    /**
     * @var ShipmentCharge
     */
    private $transporation;


    /**
     * @var ShipmentCharge
     */
    private $dutyAndTax;

    /**
     * @var bool
     */
    private $splitDutyVATIndicator;

    public function __construct($attributes = null)
    {
        if (isset($attributes->ShipmentCharges)) {
            foreach ($attributes->ShipmentCharges as $shipmentCharge) {
                if (!isset($shipmentCharge->Type)) {
                    continue;
                }

                if ($shipmentCharge->Type === ShipmentCharge::TYPE_TRANSPORTATION) {
                    $this->setTransportation(new ShipmentCharge($shipmentCharge));
                } elseif ($shipmentCharge->Type === ShipmentCharge::TYPE_DUTY_AND_TAX) {
                    $this->setDutyAndTax(new ShipmentCharge($shipmentCharge));
                }
            }
        }

        if (isset($attributes->SplitDutyVATIndicator)) {
            $this->setSplitDutyVATIndicator($attributes->SplitDutyVATIndicator);

        }
    }

    /**
     * @param null|DOMDocument $document
     *
     * @return DOMElement
     */
    public function toNode(DOMDocument $document = null)
    {
        if (is_null($document)) {
            $document = new DOMDocument();
        }

        $node = $document->createElement('ItemizedPaymentInformation');
        if ($this->getTransportation()) {
            $node->appendChild($this->getTransportation()->toNode($document));
        }
        if ($this->getDutyAndTax()) {
            $node->appendChild($this->getDutyAndTax()->toNode($document));
        }
        if ($this->getSplitDutyVATIndicator()) {
            $node->appendChild($document->createElement('SplitDutyVATIndicator'));
        }

        return $node;
    }

    /**
     * @return ShipmentCharge
     */
    public function getTransportation()
    {
        return $this->transportation;

    }

    /**
     * @param ShipmentCharge $transportation
     *
     * @return ItemizedPaymentInformation
     */
    public function setTransportation(ShipmentCharge $transportation)
    {
        $this->transportation = $transportation;


        return $this;
    }

    /**
     * @return ShipmentCharge
     */
    public function getDutyAndTax()
    {
        return $this->dutyAndTax;
    }

    /**
     * @param ShipmentCharge $dutyAndTax
     *
     * @return ItemizedPaymentInformation
     */
    public function setDutyAndTax(ShipmentCharge $dutyAndTax)
    {
        $this->dutyAndTax = $dutyAndTax;

        return $this;
    }

    /**
     * @return bool
     */
    public function getSplitDutyVATIndicator()
    {
        return $this->splitDutyVATIndicator;
    }

    /**
     * @param bool $splitDutyVATIndicator
     *
     * @return ItemizedPaymentInformation
     */
    public function setSplityDutyVATIndicator($splitDutyVATIndicator)
    {
        $this->splitDutyVATIndicator = $splitDutyVATIndicator;

        return $this;
    }
}


1			<?php
2
3			namespace Ups\Entity;
4
5			use DOMDocument;
6
7			class ItemizedPaymentInformation
8			{
9
10			/**
11			* @var ShipmentCharge
12			*/
13			private $transporation;
			0 ignored issues – show Unused Code introduced 2017-03-07 17:46 UTC by Report Bug Copy Issue Report The property `$transporation` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15			/**
16			* @var ShipmentCharge
17			*/
18			private $dutyAndTax;
19
20			/**
21			* @var bool
22			*/
23			private $splitDutyVATIndicator;
24
25			public function __construct($attributes = null)
26			{
27			if (isset($attributes->ShipmentCharges)) {
28			foreach ($attributes->ShipmentCharges as $shipmentCharge) {
29			if (!isset($shipmentCharge->Type)) {
30			continue;
31			}
32
33			if ($shipmentCharge->Type === ShipmentCharge::TYPE_TRANSPORTATION) {
34			$this->setTransportation(new ShipmentCharge($shipmentCharge));
35			} elseif ($shipmentCharge->Type === ShipmentCharge::TYPE_DUTY_AND_TAX) {
36			$this->setDutyAndTax(new ShipmentCharge($shipmentCharge));
37			}
38			}
39			}
40
41			if (isset($attributes->SplitDutyVATIndicator)) {
42			$this->setSplitDutyVATIndicator($attributes->SplitDutyVATIndicator);
			0 ignored issues – show Bug introduced 2017-03-07 17:46 UTC by Report Bug Copy Issue Report The method `setSplitDutyVATIndicator()` does not exist on `Ups\Entity\ItemizedPaymentInformation`. Did you maybe mean `setSplityDutyVATIndicator()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
43			}
44			}
45
46			/**
47			* @param null\|DOMDocument $document
48			*
49			* @return DOMElement
50			*/
51			public function toNode(DOMDocument $document = null)
52			{
53			if (is_null($document)) {
54			$document = new DOMDocument();
55			}
56
57			$node = $document->createElement('ItemizedPaymentInformation');
58			if ($this->getTransportation()) {
59			$node->appendChild($this->getTransportation()->toNode($document));
60			}
61			if ($this->getDutyAndTax()) {
62			$node->appendChild($this->getDutyAndTax()->toNode($document));
63			}
64			if ($this->getSplitDutyVATIndicator()) {
65			$node->appendChild($document->createElement('SplitDutyVATIndicator'));
66			}
67
68			return $node;
69			}
70
71			/**
72			* @return ShipmentCharge
73			*/
74			public function getTransportation()
75			{
76			return $this->transportation;
			0 ignored issues – show Bug introduced 2017-03-07 17:46 UTC by Report Bug Copy Issue Report The property `transportation` does not seem to exist. Did you mean `transporation`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
77			}
78
79			/**
80			* @param ShipmentCharge $transportation
81			*
82			* @return ItemizedPaymentInformation
83			*/
84			public function setTransportation(ShipmentCharge $transportation)
85			{
86			$this->transportation = $transportation;
			0 ignored issues – show Bug introduced 2017-03-07 17:46 UTC by Report Bug Copy Issue Report The property `transportation` does not seem to exist. Did you mean `transporation`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
87
88			return $this;
89			}
90
91			/**
92			* @return ShipmentCharge
93			*/
94			public function getDutyAndTax()
95			{
96			return $this->dutyAndTax;
97			}
98
99			/**
100			* @param ShipmentCharge $dutyAndTax
101			*
102			* @return ItemizedPaymentInformation
103			*/
104			public function setDutyAndTax(ShipmentCharge $dutyAndTax)
105			{
106			$this->dutyAndTax = $dutyAndTax;
107
108			return $this;
109			}
110
111			/**
112			* @return bool
113			*/
114			public function getSplitDutyVATIndicator()
115			{
116			return $this->splitDutyVATIndicator;
117			}
118
119			/**
120			* @param bool $splitDutyVATIndicator
121			*
122			* @return ItemizedPaymentInformation
123			*/
124			public function setSplityDutyVATIndicator($splitDutyVATIndicator)
125			{
126			$this->splitDutyVATIndicator = $splitDutyVATIndicator;
127
128			return $this;
129			}
130			}
131

gabrielbull / php-ups-api

Pull Request — master (#151)

ItemizedPaymentInformation::setDutyAndTax() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like