Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like InternationalForms often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use InternationalForms, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class InternationalForms implements NodeInterface |
||
11 | { |
||
12 | /** |
||
13 | * @var string |
||
14 | */ |
||
15 | private $type = self::TYPE_INVOICE; |
||
16 | |||
17 | /** |
||
18 | * Form Types. |
||
19 | */ |
||
20 | const TYPE_INVOICE = '01'; |
||
21 | const TYPE_CO = '03'; |
||
22 | const TYPE_NAFTA_CO = '04'; |
||
23 | const TYPE_PARTIAL_INVOICE = '05'; |
||
24 | const TYPE_PACKINGLIST = '06'; |
||
25 | const TYPE_CUSTOMER_GENERATED_FORMS = '07'; |
||
26 | const TYPE_AIR_FREIGHT_PACKING_LIST = '08'; |
||
27 | const TYPE_CN22_FORMS = '09'; |
||
28 | const TYPE_UPS_PREMIUM_CARE = '10'; |
||
29 | const TYPE_EEI_SHIPMENT_WITH_RETURN_SERVICE = '11'; |
||
30 | |||
31 | private static $typeNames = [ |
||
32 | '01' => 'Invoice', |
||
33 | '03' => 'CO', |
||
34 | '04' => 'NAFTA CO', |
||
35 | '05' => 'Partial Invoice', |
||
36 | '06' => 'Packinglist', |
||
37 | '07' => 'Customer Generated Forms', |
||
38 | '08' => 'Air Freight Packing List', |
||
39 | '09' => 'CN22 Forms', |
||
40 | '10' => 'UPS Premium Care', |
||
41 | '11' => 'EEI. For shipment with return service', |
||
42 | ]; |
||
43 | |||
44 | /** |
||
45 | * @var string |
||
46 | */ |
||
47 | private $termsOfShipment; |
||
48 | |||
49 | /** |
||
50 | * Terms of Shipment. |
||
51 | */ |
||
52 | const TOS_COST_AND_FREIGHT = 'CFR'; |
||
53 | const TOS_COST_INSURANCE_AND_FREIGHT = 'CIF'; |
||
54 | const TOS_CARRIAGE_AND_INSURANCE_PAID = 'CIP'; |
||
55 | const TOS_CARRIAGE_PAID_TO = 'CPT'; |
||
56 | const TOS_DELIVERED_AT_FRONTIER = 'DAF'; |
||
57 | const TOS_DELIVERY_DUTY_PAID = 'DDP'; |
||
58 | const TOS_DELIVERY_DUTY_UNPAID = 'DDU'; |
||
59 | const TOS_DELIVERED_EX_QUAY = 'DEQ'; |
||
60 | const TOS_DELIVERED_EX_SHIP = 'DES'; |
||
61 | const TOS_EX_WORKS = 'EXW'; |
||
62 | const TOS_FREE_ALONGSIDE_SHIP = 'FAS'; |
||
63 | const TOS_FREE_CARRIER = 'FCA'; |
||
64 | const TOS_FREE_ON_BOARD = 'FOB'; |
||
65 | |||
66 | private static $termsOfShipmentNames = [ |
||
|
|||
67 | 'CFR' => 'Cost and Freight', |
||
68 | 'CIF' => 'Cost, Insurance and Freight', |
||
69 | 'CIP' => 'Carriage and Insurance Paid', |
||
70 | 'CPT' => 'Carriage Paid To', |
||
71 | 'DAF' => 'Delivered at Frontier', |
||
72 | 'DDP' => 'Delivery Duty Paid', |
||
73 | 'DDU' => 'Delivery Duty Unpaid', |
||
74 | 'DEQ' => 'Delivered Ex Quay', |
||
75 | 'DES' => 'Delivered Ex Ship', |
||
76 | 'EXW' => 'Ex Works', |
||
77 | 'FAS' => 'Free Alongside Ship', |
||
78 | 'FCA' => 'Free Carrier', |
||
79 | 'FOB' => 'Free On Board', |
||
80 | ]; |
||
81 | |||
82 | /** |
||
83 | * @var string |
||
84 | */ |
||
85 | private $reasonForExport; |
||
86 | |||
87 | /** |
||
88 | * Reasons for export. |
||
89 | */ |
||
90 | const RFE_SALE = 'SALE'; |
||
91 | const RFE_GIFT = 'GIFT'; |
||
92 | const RFE_SAMPLE = 'SAMPLE'; |
||
93 | const RFE_RETURN = 'RETURN'; |
||
94 | const RFE_REPAIR = 'REPAIR'; |
||
95 | const RFE_INTERCOMPANYDATA = 'INTERCOMPANYDATA'; |
||
96 | |||
97 | /** |
||
98 | * @var string |
||
99 | */ |
||
100 | private $comments; |
||
101 | |||
102 | /** |
||
103 | * @var string |
||
104 | */ |
||
105 | private $currencyCode; |
||
106 | |||
107 | /** |
||
108 | * @var string |
||
109 | */ |
||
110 | private $invoiceNumber; |
||
111 | |||
112 | /** |
||
113 | * @var DateTime |
||
114 | */ |
||
115 | private $invoiceDate; |
||
116 | |||
117 | /** |
||
118 | * @var string |
||
119 | */ |
||
120 | private $purchaseOrderNumber; |
||
121 | |||
122 | /** |
||
123 | * @var array |
||
124 | */ |
||
125 | private $products = []; |
||
126 | |||
127 | /** |
||
128 | * @var Discount |
||
129 | */ |
||
130 | private $discount; |
||
131 | |||
132 | /** |
||
133 | * @var FreightCharges |
||
134 | */ |
||
135 | private $freightCharges; |
||
136 | |||
137 | /** |
||
138 | * @var OtherCharges |
||
139 | */ |
||
140 | private $otherCharges; |
||
141 | |||
142 | /** |
||
143 | * @var string $declarationStatement |
||
144 | */ |
||
145 | private $declarationStatement; |
||
146 | |||
147 | /** |
||
148 | * @return array |
||
149 | */ |
||
150 | public static function getTypes() |
||
154 | |||
155 | /** |
||
156 | * @return string |
||
157 | */ |
||
158 | public function getTypeName() |
||
162 | |||
163 | /** |
||
164 | * @param null|object $attributes |
||
165 | */ |
||
166 | public function __construct($attributes = null) |
||
195 | |||
196 | /** |
||
197 | * @param $type string |
||
198 | * |
||
199 | * @return $this |
||
200 | */ |
||
201 | public function setType($type) |
||
207 | |||
208 | /** |
||
209 | * @return string |
||
210 | */ |
||
211 | public function getType() |
||
215 | |||
216 | /** |
||
217 | * @param $freightCharges FreightCharges |
||
218 | * |
||
219 | * @return $this |
||
220 | */ |
||
221 | public function setFreightCharges(FreightCharges $freightCharges) |
||
227 | |||
228 | /** |
||
229 | * @return FreightCharges |
||
230 | */ |
||
231 | public function getFreightCharges() |
||
235 | |||
236 | /** |
||
237 | * @param $discount Discount |
||
238 | * |
||
239 | * @return $this |
||
240 | */ |
||
241 | public function setDiscount(Discount $discount) |
||
247 | |||
248 | /** |
||
249 | * @return Discount |
||
250 | */ |
||
251 | public function getDiscount() |
||
255 | |||
256 | /** |
||
257 | * @param \Ups\Entity\OtherCharges $otherCharges |
||
258 | * |
||
259 | * @return $this |
||
260 | */ |
||
261 | public function setOtherCharges(OtherCharges $otherCharges) |
||
267 | |||
268 | /** |
||
269 | * @return OtherCharges |
||
270 | */ |
||
271 | public function getOtherCharges() |
||
275 | |||
276 | /** |
||
277 | * @param Product $product |
||
278 | * |
||
279 | * @return $this |
||
280 | */ |
||
281 | public function addProduct(Product $product) |
||
287 | |||
288 | /** |
||
289 | * @return array |
||
290 | */ |
||
291 | public function getProducts() |
||
295 | |||
296 | /** |
||
297 | * @param null|DOMDocument $document |
||
298 | * |
||
299 | * @return DOMElement |
||
300 | */ |
||
301 | public function toNode(DOMDocument $document = null) |
||
351 | |||
352 | /** |
||
353 | * @param $number string |
||
354 | * |
||
355 | * @return $this |
||
356 | */ |
||
357 | public function setInvoiceNumber($number) |
||
363 | |||
364 | /** |
||
365 | * @return string |
||
366 | */ |
||
367 | public function getInvoiceNumber() |
||
371 | |||
372 | /** |
||
373 | * @param DateTime $date |
||
374 | * |
||
375 | * @return $this |
||
376 | */ |
||
377 | public function setInvoiceDate(DateTime $date) |
||
383 | |||
384 | /** |
||
385 | * @return DateTime |
||
386 | */ |
||
387 | public function getInvoiceDate() |
||
391 | |||
392 | /** |
||
393 | * @param $number |
||
394 | * |
||
395 | * @return $this |
||
396 | */ |
||
397 | public function setPurchaseOrderNumber($number) |
||
403 | |||
404 | /** |
||
405 | * @return string |
||
406 | */ |
||
407 | public function getPurchaseOrderNumber() |
||
411 | |||
412 | /** |
||
413 | * @param $terms |
||
414 | * |
||
415 | * @return $this |
||
416 | */ |
||
417 | public function setTermsOfShipment($terms) |
||
423 | |||
424 | /** |
||
425 | * @return string |
||
426 | */ |
||
427 | public function getTermsOfShipment() |
||
431 | |||
432 | /** |
||
433 | * @param $reason |
||
434 | * |
||
435 | * @return $this |
||
436 | */ |
||
437 | public function setReasonForExport($reason) |
||
447 | |||
448 | /** |
||
449 | * @return string |
||
450 | */ |
||
451 | public function getReasonForExport() |
||
455 | |||
456 | /** |
||
457 | * @param $comments |
||
458 | * |
||
459 | * @return $this |
||
460 | */ |
||
461 | View Code Duplication | public function setComments($comments) |
|
471 | |||
472 | /** |
||
473 | * @return string |
||
474 | */ |
||
475 | public function getComments() |
||
479 | |||
480 | /** |
||
481 | * @param $code |
||
482 | * |
||
483 | * @return $this |
||
484 | */ |
||
485 | public function setCurrencyCode($code) |
||
491 | |||
492 | /** |
||
493 | * @return string |
||
494 | */ |
||
495 | public function getCurrencyCode() |
||
499 | |||
500 | /** |
||
501 | * @return string |
||
502 | */ |
||
503 | public function getDeclarationStatement() |
||
507 | |||
508 | public function setDeclarationStatement($statement) |
||
514 | } |
||
515 |
This check marks private properties in classes that are never used. Those properties can be removed.