gabrielbull / php-ups-api

src/Entity/AddressValidation/AVAddress.php

Spacing +5 added lines, -5 removed lines

@@ -62,15 +62,15 @@ 
     public function __construct(\SimpleXMLElement $xmlDoc)
     {
         if ($xmlDoc->count() == 0) {
-            throw new \InvalidArgumentException(__METHOD__ . ': The passed object does not have any child nodes.');
+            throw new \InvalidArgumentException(__METHOD__.': The passed object does not have any child nodes.');
         }
         $this->addressClassification = isset($xmlDoc->AddressClassification) ? new AddressClassification($xmlDoc->AddressClassification) : null;
         $this->consigneeName = isset($xmlDoc->ConsigneeName) ? (string)$xmlDoc->ConsigneeName : '';
         $this->buildingName = isset($xmlDoc->BuildingName) ? (string)$xmlDoc->BuildingName : '';
         if (isset($xmlDoc->AddressLine)) {
             for ($i = 0, $len = count($xmlDoc->AddressLine); $i < $len; $i++) {
-                $var = 'addressLine' . ($i > 0 ? $i + 1 : '');
-                $this->{$var} = isset($xmlDoc->AddressLine[$i]) ? (string) $xmlDoc->AddressLine[$i] : '';
+                $var = 'addressLine'.($i > 0 ? $i + 1 : '');
+                $this->{$var} = isset($xmlDoc->AddressLine[$i]) ? (string)$xmlDoc->AddressLine[$i] : '';
             }
         }
         $this->region = isset($xmlDoc->Region) ? (string)$xmlDoc->Region : '';
@@ -154,7 +154,7 @@ 
      */
     public function getPostalCodeWithExtension($divider = '-')
     {
-        return $this->postcodePrimaryLow . $divider . $this->postcodeExtendedLow;
+        return $this->postcodePrimaryLow.$divider.$this->postcodeExtendedLow;
     }
 
     /**
@@ -165,7 +165,7 @@ 
      */
     public function getAddressLine($lineNumber = 1)
     {
-        $var = 'addressLine' . ($lineNumber > 1 ? $lineNumber : '');
+        $var = 'addressLine'.($lineNumber > 1 ? $lineNumber : '');
         return $this->{$var};
     }
 }

src/Entity/Product.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
 
         $node = $document->createElement('Product');
         for ($i = 1; $i <= 3; $i++) {
-            $desc = $this->{'getDescription' . $i}();
+            $desc = $this->{'getDescription'.$i}();
             if ($desc !== null) {
                 $node->appendChild($document->createElement('Description', $desc));
             }

src/Entity/AddressValidationResponse.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
     public function noCandidates()
     {
         if (AddressValidation::REQUEST_OPTION_ADDRESS_CLASSIFICATION == $this->requestAction) {
-            throw new \BadMethodCallException(__METHOD__ . ' should not be called on Address Classification only requests.');
+            throw new \BadMethodCallException(__METHOD__.' should not be called on Address Classification only requests.');
         }
         return isset($this->response->NoCandidatesIndicator);
     }
@@ -62,7 +62,7 @@ 
     public function isAmbiguous()
     {
         if (AddressValidation::REQUEST_OPTION_ADDRESS_CLASSIFICATION == $this->requestAction) {
-            throw new \BadMethodCallException(__METHOD__ . ' should not be called on Address Classification only requests.');
+            throw new \BadMethodCallException(__METHOD__.' should not be called on Address Classification only requests.');
         }
         return isset($this->response->AmbiguousAddressIndicator);
     }

src/Entity/AddressKeyFormat.php

Spacing +4 added lines, -4 removed lines

@@ -60,16 +60,16 @@
         }
 
         for ($i = 1; $i <= 3; $i++) {
-            $line = $this->{'getAddressLine' . $i}();
+            $line = $this->{'getAddressLine'.$i}();
             if ($line) {
-                $node->appendChild($document->createElement('AddressLine' . ($i == 1 ? '' : $i), $line));
+                $node->appendChild($document->createElement('AddressLine'.($i == 1 ? '' : $i), $line));
             }
         }
 
         for ($i = 1; $i <= 3; $i++) {
-            $line = $this->{'getPoliticalDivision' . $i}();
+            $line = $this->{'getPoliticalDivision'.$i}();
             if ($line) {
-                $node->appendChild($document->createElement('PoliticalDivision' . $i, $line));
+                $node->appendChild($document->createElement('PoliticalDivision'.$i, $line));
             }
         }
 

src/SoapRequest.php

Spacing +5 added lines, -5 removed lines

@@ -97,7 +97,7 @@ 
         );
 
         // Initialize soap client
-        $client = new SoapClient(__DIR__ . '/WSDL/' . $wsdl . '.wsdl', $mode);
+        $client = new SoapClient(__DIR__.'/WSDL/'.$wsdl.'.wsdl', $mode);
 
         // Set endpoint URL + auth & request data
         $client->__setLocation($endpointurl);
@@ -116,7 +116,7 @@ 
             'endpointurl' => $this->getEndpointUrl(),
         ]);
 
-        $this->logger->debug('Request: ' . $this->getRequest(), [
+        $this->logger->debug('Request: '.$this->getRequest(), [
             'id' => $id,
             'endpointurl' => $this->getEndpointUrl(),
         ]);
@@ -132,7 +132,7 @@ 
                 'endpointurl' => $this->getEndpointUrl(),
             ]);
 
-            $this->logger->debug('Response: ' . $body, [
+            $this->logger->debug('Response: '.$body, [
                 'id' => $id,
                 'endpointurl' => $this->getEndpointUrl(),
             ]);
@@ -155,14 +155,14 @@ 
                     'endpointurl' => $this->getEndpointUrl(),
                 ]);
 
-                throw new InvalidResponseException('Failure: ' . (string)$errorMsg[0] . ' (' . (string)$errorCode[0] . ')');
+                throw new InvalidResponseException('Failure: '.(string)$errorMsg[0].' ('.(string)$errorCode[0].')');
             } else {
                 $this->logger->alert($e->getMessage(), [
                     'id' => $id,
                     'endpointurl' => $this->getEndpointUrl(),
                 ]);
 
-                throw new InvalidResponseException('Cannot parse error from UPS: ' . $e->getMessage(), $e->getCode(),
+                throw new InvalidResponseException('Cannot parse error from UPS: '.$e->getMessage(), $e->getCode(),
                     $e);
             }
         }

src/Entity/OtherCharges.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMonetaryValue()
     {

src/Request.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 use SimpleXMLElement;
-use Ups\Exception\InvalidResponseException;
 use Ups\Exception\RequestException;
 
 class Request implements RequestInterface, LoggerAwareInterface

Doc Comments +3 added lines, -3 removed lines

@@ -145,7 +145,7 @@ 
     }
 
     /**
-     * @param $access
+     * @param string $access
      *
      * @return $this
      */
@@ -165,7 +165,7 @@ 
     }
 
     /**
-     * @param $request
+     * @param string $request
      *
      * @return $this
      */
@@ -185,7 +185,7 @@ 
     }
 
     /**
-     * @param $endpointUrl
+     * @param string $endpointUrl
      *
      * @return $this
      */

Spacing +4 added lines, -4 removed lines

@@ -84,7 +84,7 @@ 
             'endpointurl' => $this->getEndpointUrl(),
         ]);
 
-        $this->logger->debug('Request: ' . $this->getRequest(), [
+        $this->logger->debug('Request: '.$this->getRequest(), [
             'id' => $id,
             'endpointurl' => $this->getEndpointUrl(),
         ]);
@@ -95,7 +95,7 @@ 
             $response = $client->post(
                 $this->getEndpointUrl(),
                 [
-                    'body' => $this->getAccess() . $this->getRequest(),
+                    'body' => $this->getAccess().$this->getRequest(),
                     'headers' => [
                         'Content-type' => 'application/x-www-form-urlencoded; charset=utf-8',
                         'Accept-Charset' => 'UTF-8',
@@ -111,7 +111,7 @@ 
                 'endpointurl' => $this->getEndpointUrl(),
             ]);
 
-            $this->logger->debug('Response: ' . $body, [
+            $this->logger->debug('Response: '.$body, [
                 'id' => $id,
                 'endpointurl' => $this->getEndpointUrl(),
             ]);
@@ -140,7 +140,7 @@ 
                 'endpointurl' => $this->getEndpointUrl(),
             ]);
 
-            throw new RequestException('Failure: ' . $e->getMessage());
+            throw new RequestException('Failure: '.$e->getMessage());
         }
     }