Ups\Entity\AddressValidation\AVAddress

Complexity

Total Complexity

24

Size/Duplication

Total Lines	132
Duplicated Lines	4.55 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

80%

Importance

Changes	6
Bugs	2	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCity()	0	4	1
A	getStateProvince()	0	4	1
A	getPostalCode()	0	4	1
A	getPostalCodeWithExtension()	0	4	1
F	__construct()	6	29	20

<?php namespace Ups\Entity\AddressValidation;

class AVAddress
{
    /**
     * @var null|AddressClassification
     */
    public $addressClassification;
    /**
     * @var string
     */
    public $consigneeName;
    /**
     * @var string
     */
    public $buildingName;
    /**
     * @var string
     */
    public $addressLine;
    /**
     * @var string
     */
    public $addressLine2;
    /**
     * @var string
     */
    public $addressLine3;
    /**
     * @var string
     */
    public $region;
    /**
     * @var string
     */
    public $politicalDivision2;
    /**
     * @var string
     */
    public $politicalDivision1;
    /**
     * @var string
     */
    public $postcodePrimaryLow;
    /**
     * @var string
     */
    public $postcodeExtendedLow;
    /**
     * @var string
     */
    public $urbanization;
    /**
     * @var
     */
    public $countryCode;

    /**
     * Address constructor.
     * @param \SimpleXMLElement $xmlDoc
     */
    public function __construct(\SimpleXMLElement $xmlDoc)
    {
        if ($xmlDoc->count() == 0) {
            throw new \InvalidArgumentException(__METHOD__ . ': The passed object does not have any child nodes.');
        }
        $this->addressClassification = isset($xmlDoc->AddressClassification) ? new AddressClassification($xmlDoc->AddressClassification) : null;
        $this->consigneeName = isset($xmlDoc->ConsigneeName) ? (string)$xmlDoc->ConsigneeName : '';
        $this->buildingName = isset($xmlDoc->BuildingName) ? (string)$xmlDoc->BuildingName : '';
        if (isset($xmlDoc->AddressLine)) {
            for ($i = 0, $len = count($xmlDoc->AddressLine); $i < $len; $i++) {
                if ($i === 0) {
                    $this->addressLine = isset($xmlDoc->AddressLine[$i]) ? (string) $xmlDoc->AddressLine[$i] : '';
                }
                elseif ($i === 1) {

This code seems to be duplicated across your project.

                    $this->addressLine2 = isset($xmlDoc->AddressLine[$i]) ? (string) $xmlDoc->AddressLine[$i] : '';
                }
                elseif ($i === 2) {

This code seems to be duplicated across your project.

                    $this->addressLine3 = isset($xmlDoc->AddressLine[$i]) ? (string) $xmlDoc->AddressLine[$i] : '';
                }
            }
        }
        $this->region = isset($xmlDoc->Region) ? (string)$xmlDoc->Region : '';
        $this->politicalDivision2 = isset($xmlDoc->PoliticalDivision2) ? (string)$xmlDoc->PoliticalDivision2 : '';
        $this->politicalDivision1 = isset($xmlDoc->PoliticalDivision1) ? (string)$xmlDoc->PoliticalDivision1 : '';
        $this->postcodePrimaryLow = isset($xmlDoc->PostcodePrimaryLow) ? (string)$xmlDoc->PostcodePrimaryLow : '';
        $this->postcodeExtendedLow = isset($xmlDoc->PostcodeExtendedLow) ? (string)$xmlDoc->PostcodeExtendedLow : '';
        $this->urbanization = isset($xmlDoc->Urbanization) ? (string)$xmlDoc->Urbanization : '';
        $this->countryCode = isset($xmlDoc->CountryCode) ? (string)$xmlDoc->CountryCode : '';
    }

    /**
     * Convenience methods. Even though all properties are public, these methods provide a convenient interface to
     * retrieve commonly requested parts so that the user doesn't have to remember which API fields reference
     * which piece of information. For example, I won't have to remember that the city is in 'PoliticalDivision2'.
     */

    /**
     * @return string
     */
    public function getCity()
    {
        return $this->politicalDivision2;
    }

    /**
     * @return string
     */
    public function getStateProvince()
    {
        return $this->politicalDivision1;
    }

    /**
     * Return the address postal code
     *
     * @return string
     */
    public function getPostalCode()
    {
        return $this->postcodePrimaryLow;
    }

    /**
     * Return the address postal code with extension (i.e. the U.S. extended zip+4 postal code)
     *
     * @param string $divider
     * @return string
     */
    public function getPostalCodeWithExtension($divider = '-')
    {
        return $this->postcodePrimaryLow . $divider . $this->postcodeExtendedLow;
    }
}