Complex classes like HazMat often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HazMat, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
12 | class HazMat implements NodeInterface |
||
13 | { |
||
14 | |||
15 | /** |
||
16 | * @var string |
||
17 | */ |
||
18 | private $packagingTypeQuantity; |
||
19 | |||
20 | /** |
||
21 | * @var string |
||
22 | */ |
||
23 | private $subRiskClass; |
||
24 | |||
25 | /** |
||
26 | * @var string |
||
27 | */ |
||
28 | private $adrItemNumber; |
||
29 | |||
30 | /** |
||
31 | * @var string |
||
32 | */ |
||
33 | private $adrPackingGroupLetter; |
||
34 | |||
35 | /** |
||
36 | * @var string |
||
37 | */ |
||
38 | private $technicalName; |
||
39 | |||
40 | /** |
||
41 | * @var string |
||
42 | */ |
||
43 | private $hazardLabelRequired; |
||
44 | |||
45 | /** |
||
46 | * @var string |
||
47 | */ |
||
48 | private $classDivisionNumber; |
||
49 | |||
50 | /** |
||
51 | * @var string |
||
52 | */ |
||
53 | private $referenceNumber; |
||
54 | |||
55 | /** |
||
56 | * @var string |
||
57 | */ |
||
58 | private $quantity; |
||
59 | |||
60 | /** |
||
61 | * @var string |
||
62 | */ |
||
63 | private $uom; |
||
64 | |||
65 | /** |
||
66 | * @var string |
||
67 | */ |
||
68 | private $packagingType; |
||
69 | |||
70 | /** |
||
71 | * @var string |
||
72 | */ |
||
73 | private $idNumber; |
||
74 | |||
75 | /** |
||
76 | * @var string |
||
77 | */ |
||
78 | private $properShippingName; |
||
79 | |||
80 | /** |
||
81 | * @var string |
||
82 | */ |
||
83 | private $additionalDescription; |
||
84 | |||
85 | /** |
||
86 | * @var string |
||
87 | */ |
||
88 | private $packagingGroupType; |
||
89 | |||
90 | /** |
||
91 | * @var string |
||
92 | */ |
||
93 | private $packagingInstructionCode; |
||
94 | |||
95 | /** |
||
96 | * @var string |
||
97 | */ |
||
98 | private $emergencyPhone; |
||
99 | |||
100 | /** |
||
101 | * @var string |
||
102 | */ |
||
103 | private $emergencyContact; |
||
104 | |||
105 | /** |
||
106 | * @var string |
||
107 | */ |
||
108 | private $reportableQuantity; |
||
109 | |||
110 | /** |
||
111 | * @var string |
||
112 | */ |
||
113 | private $regulationSet; |
||
114 | |||
115 | /** |
||
116 | * @var string |
||
117 | */ |
||
118 | private $transportationMode; |
||
119 | |||
120 | /** |
||
121 | * @var string |
||
122 | */ |
||
123 | private $commodityRegulatedLevelCode; |
||
124 | |||
125 | /** |
||
126 | * @var string |
||
127 | */ |
||
128 | private $transportCategory; |
||
129 | |||
130 | /** |
||
131 | * @var string |
||
132 | */ |
||
133 | private $tunnelRestrictionCode; |
||
134 | |||
135 | /** |
||
136 | * @var string |
||
137 | */ |
||
138 | private $chemicalRecordIdentifier; |
||
139 | |||
140 | /** |
||
141 | * @param DOMDocument|null $document |
||
142 | * @return \DOMElement |
||
143 | */ |
||
144 | public function toNode(DOMDocument $document = null) |
||
231 | |||
232 | /** |
||
233 | * @return string |
||
234 | */ |
||
235 | public function getPackagingTypeQuantity() |
||
239 | |||
240 | /** |
||
241 | * @param string $packagingTypeQuantity |
||
242 | */ |
||
243 | public function setPackagingTypeQuantity($packagingTypeQuantity) |
||
247 | |||
248 | /** |
||
249 | * @return string |
||
250 | */ |
||
251 | public function getSubRiskClass() |
||
255 | |||
256 | /** |
||
257 | * @param string $subRiskClass |
||
258 | */ |
||
259 | public function setSubRiskClass($subRiskClass) |
||
263 | |||
264 | /** |
||
265 | * @return string |
||
266 | */ |
||
267 | public function getAdrItemNumber() |
||
271 | |||
272 | /** |
||
273 | * @param string $adrItemNumber |
||
274 | */ |
||
275 | public function setAdrItemNumber($adrItemNumber) |
||
279 | |||
280 | /** |
||
281 | * @return string |
||
282 | */ |
||
283 | public function getAdrPackingGroupLetter() |
||
287 | |||
288 | /** |
||
289 | * @param string $adrPackingGroupLetter |
||
290 | */ |
||
291 | public function setAdrPackingGroupLetter($adrPackingGroupLetter) |
||
295 | |||
296 | /** |
||
297 | * @return string |
||
298 | */ |
||
299 | public function getTechnicalName() |
||
303 | |||
304 | /** |
||
305 | * @param string $technicalName |
||
306 | */ |
||
307 | public function setTechnicalName($technicalName) |
||
311 | |||
312 | /** |
||
313 | * @return string |
||
314 | */ |
||
315 | public function getHazardLabelRequired() |
||
319 | |||
320 | /** |
||
321 | * @param string $hazardLabelRequired |
||
322 | */ |
||
323 | public function setHazardLabelRequired($hazardLabelRequired) |
||
327 | |||
328 | /** |
||
329 | * @return string |
||
330 | */ |
||
331 | public function getClassDivisionNumber() |
||
335 | |||
336 | /** |
||
337 | * @param string $classDivisionNumber |
||
338 | */ |
||
339 | public function setClassDivisionNumber($classDivisionNumber) |
||
343 | |||
344 | /** |
||
345 | * @return string |
||
346 | */ |
||
347 | public function getReferenceNumber() |
||
351 | |||
352 | /** |
||
353 | * @param string $referenceNumber |
||
354 | */ |
||
355 | public function setReferenceNumber($referenceNumber) |
||
359 | |||
360 | /** |
||
361 | * @return string |
||
362 | */ |
||
363 | public function getQuantity() |
||
367 | |||
368 | /** |
||
369 | * @param string $quantity |
||
370 | */ |
||
371 | public function setQuantity($quantity) |
||
375 | |||
376 | /** |
||
377 | * @return string |
||
378 | */ |
||
379 | public function getUom() |
||
383 | |||
384 | /** |
||
385 | * @param string $uom |
||
386 | */ |
||
387 | public function setUom($uom) |
||
391 | |||
392 | /** |
||
393 | * @return string |
||
394 | */ |
||
395 | public function getPackagingType() |
||
399 | |||
400 | /** |
||
401 | * @param string $packagingType |
||
402 | */ |
||
403 | public function setPackagingType($packagingType) |
||
407 | |||
408 | /** |
||
409 | * @return string |
||
410 | */ |
||
411 | public function getIdNumber() |
||
415 | |||
416 | /** |
||
417 | * @param string $idNumber |
||
418 | */ |
||
419 | public function setIdNumber($idNumber) |
||
423 | |||
424 | /** |
||
425 | * @return string |
||
426 | */ |
||
427 | public function getProperShippingName() |
||
431 | |||
432 | /** |
||
433 | * @param string $properShippingName |
||
434 | */ |
||
435 | public function setProperShippingName($properShippingName) |
||
439 | |||
440 | /** |
||
441 | * @return string |
||
442 | */ |
||
443 | public function getAdditionalDescription() |
||
447 | |||
448 | /** |
||
449 | * @param string $additionalDescription |
||
450 | */ |
||
451 | public function setAdditionalDescription($additionalDescription) |
||
455 | |||
456 | /** |
||
457 | * @return string |
||
458 | */ |
||
459 | public function getPackagingGroupType() |
||
463 | |||
464 | /** |
||
465 | * @param string $packagingGroupType |
||
466 | */ |
||
467 | public function setPackagingGroupType($packagingGroupType) |
||
471 | |||
472 | /** |
||
473 | * @return string |
||
474 | */ |
||
475 | public function getPackagingInstructionCode() |
||
479 | |||
480 | /** |
||
481 | * @param string $packagingInstructionCode |
||
482 | */ |
||
483 | public function setPackagingInstructionCode($packagingInstructionCode) |
||
487 | |||
488 | /** |
||
489 | * @return string |
||
490 | */ |
||
491 | public function getEmergencyPhone() |
||
495 | |||
496 | /** |
||
497 | * @param string $emergencyPhone |
||
498 | */ |
||
499 | public function setEmergencyPhone($emergencyPhone) |
||
503 | |||
504 | /** |
||
505 | * @return string |
||
506 | */ |
||
507 | public function getEmergencyContact() |
||
511 | |||
512 | /** |
||
513 | * @param string $emergencyContact |
||
514 | */ |
||
515 | public function setEmergencyContact($emergencyContact) |
||
519 | |||
520 | /** |
||
521 | * @return string |
||
522 | */ |
||
523 | public function getReportableQuantity() |
||
527 | |||
528 | /** |
||
529 | * @param string $reportableQuantity |
||
530 | */ |
||
531 | public function setReportableQuantity($reportableQuantity) |
||
535 | |||
536 | /** |
||
537 | * @return string |
||
538 | */ |
||
539 | public function getRegulationSet() |
||
543 | |||
544 | /** |
||
545 | * @param string $regulationSet |
||
546 | */ |
||
547 | public function setRegulationSet($regulationSet) |
||
551 | |||
552 | /** |
||
553 | * @return string |
||
554 | */ |
||
555 | public function getTransportationMode() |
||
559 | |||
560 | /** |
||
561 | * @param string $transportationMode |
||
562 | */ |
||
563 | public function setTransportationMode($transportationMode) |
||
567 | |||
568 | /** |
||
569 | * @return string |
||
570 | */ |
||
571 | public function getCommodityRegulatedLevelCode() |
||
575 | |||
576 | /** |
||
577 | * @param string $commodityRegulatedLevelCode |
||
578 | */ |
||
579 | public function setCommodityRegulatedLevelCode($commodityRegulatedLevelCode) |
||
583 | |||
584 | /** |
||
585 | * @return string |
||
586 | */ |
||
587 | public function getTransportCategory() |
||
591 | |||
592 | /** |
||
593 | * @param string $transportCategory |
||
594 | */ |
||
595 | public function setTransportCategory($transportCategory) |
||
599 | |||
600 | /** |
||
601 | * @return string |
||
602 | */ |
||
603 | public function getTunnelRestrictionCode() |
||
607 | |||
608 | /** |
||
609 | * @param string $tunnelRestrictionCode |
||
610 | */ |
||
611 | public function setTunnelRestrictionCode($tunnelRestrictionCode) |
||
615 | |||
616 | /** |
||
617 | * @return string |
||
618 | */ |
||
619 | public function getChemicalRecordIdentifier() |
||
623 | |||
624 | /** |
||
625 | * @param string $chemicalRecordIdentifier |
||
626 | */ |
||
627 | public function setChemicalRecordIdentifier($chemicalRecordIdentifier) |
||
631 | } |
||
632 |