Ups\Entity\ShipmentTotalWeight

Complexity

Total Complexity

12

Size/Duplication

Total Lines	82
Duplicated Lines	13.41 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	4
A	toNode()	0	15	3
A	getUnitOfMeasurement()	0	4	1
A	setUnitOfMeasurement()	0	4	1
A	getWeight()	0	4	1
A	setWeight()	0	8	2

<?php

namespace Ups\Entity;

use DOMDocument;
use DOMElement;
use Ups\NodeInterface;
use Ups\Entity\UnitOfMeasurement;

class ShipmentTotalWeight implements NodeInterface
{

    /**
    * @var UnitOfMeasurement
    **/
    private $unitOfMeasurement;

    /**
    * @var weight
    **/
    private $weight;

    public function __construct($response = null)

This method seems to be duplicated in your project.

    {
        if (null !== $response) {
            if (isset($response->unitOfMeasurement)) {
                $this->setUnitOfMeasurement(new UnitOfMeasurement($response->unitOfMeasurement));
            }
            if (isset($response->Weight)) {
                $this->setWeight($response->Weight);
            }
        }
    }

    /**
     * @param null|DOMDocument $document
     *
     * @return DOMElement
     */
    public function toNode(DOMDocument $document = null)
    {
        if (null === $document) {
            $document = new DOMDocument();
        }

        $node = $document->createElement('ShipmentTotalWeight');
        if ($this->getUnitOfMeasurement()) {
            $node->appendChild($this->getUnitOfMeasurement()->toNode($document));
        }

        $node->appendChild($document->createElement('Weight', $this->getWeight()));
        
        return $node;
    }

    /**
     * @return UnitOfMeasurement
     */
    public function getUnitOfMeasurement()
    {
        return $this->unitOfMeasurement;
    }

    /**
     * @param UnitOfMeasurement $unitOfMeasurement
     */
    public function setUnitOfMeasurement(UnitOfMeasurement $unitOfMeasurement)
    {
        $this->unitOfMeasurement = $unitOfMeasurement;
    }

    /**
     * @return int
     */
    public function getWeight()
    {
        return $this->weight;
    }
    
    /**
     * @param number $weight
     */
    public function setWeight($weight)
    {
        if (!is_numeric($weight)) {
            throw new \Exception('Weight value should be a numeric value');
        }

        $this->weight = $weight;

It seems like $weight of type integer or double or string is incompatible with the declared type object<Ups\Entity\weight> of property $weight.

    }
}