PullRequests::addSearchResults() - Code Metrics - g1a/hubph - Measure and Improve Code Quality continuously with Scrutinizer

PullRequests::addSearchResults() A
last analyzed 2020-06-13 02:38 UTC

↳ Parent: PullRequests

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	4
nc	3
nop	2

<?php

namespace Hubph;

class PullRequests
{
    protected $prs = [];

    /**
     * PullRequests constructor
     */
    public function __construct()
    {
    }

    public function addSearchResults($searchResults, $pattern = '')
    {
        $total = $searchResults['total_count'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $incomplete = $searchResults['incomplete_results'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        foreach ($searchResults['items'] as $pr) {
            if (empty($pattern) || preg_match("#{$pattern}#", $pr['title'])) {
                $this->add($pr);
            }
        }
    }

    public function add($pr)
    {
        $this->prs[$pr['number']] = $pr;
    }

    public function titles()
    {
        $titles = array_map(
            function ($pr) {
                return $pr['title'];
            },
            $this->prs
        );
        return $titles;
    }

    public function prNumbers()
    {
        return array_keys($this->prs);
    }

    public function isEmpty()
    {
        return empty($this->prs);
    }
}


1			<?php
2
3			namespace Hubph;
4
5			class PullRequests
6			{
7			protected $prs = [];
8
9			/**
10			* PullRequests constructor
11			*/
12			public function __construct()
13			{
14			}
15
16			public function addSearchResults($searchResults, $pattern = '')
17			{
18			$total = $searchResults['total_count'];
			0 ignored issues – show Unused Code introduced 2018-07-25 22:37 UTC by Report Bug Copy Issue Report `$total` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19			$incomplete = $searchResults['incomplete_results'];
			0 ignored issues – show Unused Code introduced 2018-07-25 22:37 UTC by Report Bug Copy Issue Report `$incomplete` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
20
21			foreach ($searchResults['items'] as $pr) {
22			if (empty($pattern) \|\| preg_match("#{$pattern}#", $pr['title'])) {
23			$this->add($pr);
24			}
25			}
26			}
27
28			public function add($pr)
29			{
30			$this->prs[$pr['number']] = $pr;
31			}
32
33			public function titles()
34			{
35			$titles = array_map(
36			function ($pr) {
37			return $pr['title'];
38			},
39			$this->prs
40			);
41			return $titles;
42			}
43
44			public function prNumbers()
45			{
46			return array_keys($this->prs);
47			}
48
49			public function isEmpty()
50			{
51			return empty($this->prs);
52			}
53			}
54

g1a / hubph

PullRequests::addSearchResults() A last analyzed 2020-06-13 02:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PullRequests::addSearchResults() A
last analyzed 2020-06-13 02:38 UTC