Fyuze\Routing\Collection

Complexity

Total Complexity

4

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	0	5	1
A	getRoutes()	0	3	1
A	get()	0	3	1
A	post()	0	3	1

<?php
namespace Fyuze\Routing;

class Collection
{
    /**
     * @var array
     */
    protected $routes = [];

    /**
     * @return array
     */
    public function getRoutes()
    {
        return $this->routes;
    }

    /**
     * @param $route
     * @param $action
     * @param null $name

Are you sure the doc-type for parameter $name is correct as it would always require null to be passed?

     * @param array $options
     * @return Collection
     */
    public function post($route, $name, $action, $options = [])
    {
        return $this->add($route, $name, $action, array_merge(['method' => 'POST'], $options));
    }

    /**
     * @param $route
     * @param $action
     * @param null $name

Are you sure the doc-type for parameter $name is correct as it would always require null to be passed?

     * @param array $options
     * @return Collection
     */
    public function get($route, $name, $action, $options = [])
    {
        return $this->add($route, $name, $action, array_merge(['method' => 'GET'], $options));
    }

    /**
     * @param $route
     * @param $name
     * @param $action
     * @param array $options
     * @return $this
     */
    protected function add($route, $name, $action, $options = [])
    {
        $this->routes[] = new Route($route, $name, $action, $options);

The call to Fyuze\Routing\Route::__construct() has too many arguments starting with $options.

        return $this;
    }
}