Issues in XmlReaderParser.php (master) - Issues in master - fxmlrpc/serialization - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Parser/XmlReaderParser.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Fxmlrpc\Serialization\Parser;

use Fxmlrpc\Serialization\Exception\FaultException;
use Fxmlrpc\Serialization\Exception\UnexpectedTagException;
use Fxmlrpc\Serialization\Parser;
use Fxmlrpc\Serialization\Value\Base64Value;
use Fxmlrpc\Serialization\XmlChecker;

/**
 * Parser to parse XML responses into its PHP representation using XML Reader extension.
 *
 * @author Lars Strojny <[email protected]>
 */
final class XmlReaderParser implements Parser
{
    /**
     * @var bool
     */
    private $validateResponse;

    /**
     * @param bool $validateResponse
     */
    public function __construct($validateResponse = true)
    {
        $this->validateResponse = $validateResponse;
    }

    /**
     * {@inheritdoc}
     */
    public function parse($xmlString)
    {
        if ($this->validateResponse) {
            XmlChecker::isValid($xmlString);
        }

        $useErrors = libxml_use_internal_errors(true);

        $xml = new \XMLReader();
        $xml->xml($xmlString, 'UTF-8', LIBXML_COMPACT | LIBXML_NOCDATA | LIBXML_NOBLANKS | LIBXML_PARSEHUGE);
        $xml->setParserProperty(\XMLReader::VALIDATE, false);
        $xml->setParserProperty(\XMLReader::LOADDTD, false);

// This following assignments are auto-generated using Fxmlrpc\Serialization\CodeGenerator\XmlReaderParserBitmaskGenerator
// Don’t edit manually
        static $flagmethodResponse = 0b000000000000000000000000001;
        static $flagparams = 0b000000000000000000000000010;
        static $flagfault = 0b000000000000000000000000100;
        static $flagparam = 0b000000000000000000000001000;
        static $flagvalue = 0b000000000000000000000010000;
        static $flagarray = 0b000000000000000000000100000;
        static $flagmember = 0b000000000000000000001000000;
        static $flagname = 0b000000000000000000010000000;
        ${'flag#text'} = 0b000000000000000000100000000;
        static $flagstring = 0b000000000000000001000000000;
        static $flagstruct = 0b000000000000000010000000000;
        static $flagint = 0b000000000000000100000000000;
        static $flagbiginteger = 0b000000000000001000000000000;
        static $flagi8 = 0b000000000000010000000000000;
        static $flagi4 = 0b000000000000100000000000000;
        static $flagi2 = 0b000000000001000000000000000;
        static $flagi1 = 0b000000000010000000000000000;
        static $flagboolean = 0b000000000100000000000000000;
        static $flagdouble = 0b000000001000000000000000000;
        static $flagfloat = 0b000000010000000000000000000;
        static $flagbigdecimal = 0b000000100000000000000000000;
        ${'flagdateTime.iso8601'} = 0b000001000000000000000000000;
        static $flagdateTime = 0b000010000000000000000000000;
        static $flagbase64 = 0b000100000000000000000000000;
        static $flagnil = 0b001000000000000000000000000;
        static $flagdom = 0b010000000000000000000000000;
        static $flagdata = 0b100000000000000000000000000;
// End of auto-generated code

        $aggregates = [];
        $depth = 0;
        $nextExpectedElements = 0b000000000000000000000000001;
        $i = 0;
        $isFault = false;

        while ($xml->read()) {
            ++$i;
            $nodeType = $xml->nodeType;

            if (($nodeType === \XMLReader::COMMENT || $nodeType === \XMLReader::DOC_TYPE) ||
                (
                   $nodeType === \XMLReader::SIGNIFICANT_WHITESPACE &&
                   ($nextExpectedElements & 0b000000000000000000100000000) !== 0b000000000000000000100000000)
                ) {
                continue;
            }

            if ($nodeType === \XMLReader::ENTITY_REF) {
                return '';
            }

            $tagName = $xml->localName;

            if ($nextExpectedElements !== null &&
                ($flag = isset(${'flag'.$tagName}) ? ${'flag'.$tagName} : -1) &&
                ($nextExpectedElements & $flag) !== $flag
            ) {
                throw new UnexpectedTagException(
                    $tagName,
                    $nextExpectedElements,
                    get_defined_vars(),
                    $xml->depth,
                    $xml->readOuterXml()
                );
            }

            processing:
            switch ($nodeType) {
                case \XMLReader::ELEMENT:
                    switch ($tagName) {
                        case 'methodResponse':
                            // Next: params, fault
                            $nextExpectedElements = 0b000000000000000000000000110;
                            break;

                        case 'params':
                            // Next: param
                            $nextExpectedElements = 0b000000000000000000000001000;
                            $aggregates[$depth] = [];
                            break;

                        case 'fault':
                            $isFault = true;
                            // Break intentionally omitted
                        case 'param':
                            // Next: value
                            $nextExpectedElements = 0b000000000000000000000010000;
                            break;

                        case 'array':
                            $aggregates[++$depth] = [];
                            // Break intentionally omitted
                        case 'data':
                            // Next: array, data, value
                            $nextExpectedElements = 0b100000000000000000000110000;
                            break;

                        case 'struct':
                            // Next: struct, member, value
                            $nextExpectedElements = 0b000000000000000010001010000;
                            $aggregates[++$depth] = [];
                            break;

                        case 'member':
                            // Next: name, value
                            $nextExpectedElements = 0b000000000000000000010010000;
                            $aggregates[++$depth] = [];
                            break;

                        case 'name':
                            // Next: #text
                            $nextExpectedElements = 0b000000000000000000100000000;
                            $type = 'name';
                            break;

                        case 'value':
                            $nextExpectedElements = 0b011111111111111111100110000;
                            $type = 'value';
                            $aggregates[$depth + 1] = '';
                            break;

                        case 'base64':
                        case 'string':
                        case 'biginteger':
                        case 'i8':
                        case 'dateTime.iso8601':
                        case 'dateTime':

                            // Next: value, $tagName, #text
                            $nextExpectedElements = 0b000000000000000000100010000 | ${'flag'.$tagName};
                            $type = $tagName;
                            $aggregates[$depth + 1] = '';
                            break;

                        case 'nil':

                            // Next: value, $tagName
                            $nextExpectedElements = 0b001000000000000000000010000 | ${'flag'.$tagName};
                            $type = $tagName;
                            $aggregates[$depth + 1] = null;
                            break;

                        case 'int':
                        case 'i4':
                        case 'i2':
                        case 'i1':

                            // Next: value, #text, $tagName
                            $nextExpectedElements = 0b000000000000000000100010000 | ${'flag'.$tagName};
                            $type = $tagName;
                            $aggregates[$depth + 1] = 0;
                            break;

                        case 'boolean':

                            // Next: value, #text, $tagName
                            $nextExpectedElements = 0b000000000000000000100010000 | ${'flag'.$tagName};
                            $type = 'boolean';
                            $aggregates[$depth + 1] = false;
                            break;

                        case 'double':
                        case 'float':
                        case 'bigdecimal':

                            // Next: value, #text, $tagName
                            $nextExpectedElements = 0b000000000000000000100010000 | ${'flag'.$tagName};
                            $type = $tagName;
                            $aggregates[$depth + 1] = 0.0;
                            break;

                        case 'dom':
                            $type = 'dom';
                            // Disable type checking
                            $nextExpectedElements = null;
                            $aggregates[$depth + 1] = $xml->readInnerXml();
                            break;
                    }
                    break;

                case \XMLReader::END_ELEMENT:
                    switch ($tagName) {
                        case 'params':
                        case 'fault':
                            break 3;

                        case 'param':
                            // Next: params, param
                            $nextExpectedElements = 0b000000000000000000000001010;
                            break;

                        case 'value':

                            $nextExpectedElements = 0b100100000011100100011011100;
                            $aggregates[$depth][] = $aggregates[$depth + 1];
                            break;

                        case 'array':
                        case 'struct':
                            --$depth;
                            // Break intentionally omitted
                        case 'string':
                        case 'int':
                        case 'biginteger':
                        case 'i8':
                        case 'i4':
                        case 'i2':
                        case 'i1':
                        case 'boolean':
                        case 'double':
                        case 'float':
                        case 'bigdecimal':
                        case 'dateTime.iso8601':
                        case 'dateTime':
                        case 'base64':
                        case 'nil':
                            // Next: value
                            $nextExpectedElements = 0b000000000000000000000010000;
                            break;

                        case 'data':
                            // Next: array
                            $nextExpectedElements = 0b000000000000000000000100000;
                            break;

                        case 'name':

                            // Next: value, member
                            $nextExpectedElements = 0b000000000000000000001010000;
                            $aggregates[$depth]['name'] = $aggregates[$depth + 1];
                            break;

                        case 'member':
                            // Next: struct, member
                            $nextExpectedElements = 0b000000000000000010001000000;
                            $aggregates[$depth - 1][$aggregates[$depth]['name']] = $aggregates[$depth][0];
                            unset($aggregates[$depth], $aggregates[$depth + 1]);
                            --$depth;
                            break;
                    }
                    break;

                case \XMLReader::TEXT:
                case \XMLReader::SIGNIFICANT_WHITESPACE:
                    switch ($type) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        case 'int':
                        case 'i4':
                        case 'i2':
                        case 'i1':
                            $value = (int) $xml->value;
                            break;

                        case 'boolean':
                            $value = $xml->value === '1';
                            break;

                        case 'double':
                        case 'float':
                        case 'bigdecimal':
                            $value = (float) $xml->value;
                            break;

                        case 'dateTime.iso8601':

                            $value = \DateTime::createFromFormat(
                                'Ymd\TH:i:s',
                                $xml->value,
                                isset($timezone) ? $timezone : $timezone = new \DateTimeZone('UTC')
                            );
                            break;

                        case 'dateTime':

                            $value = \DateTime::createFromFormat(
                                'Y-m-d\TH:i:s.uP',
                                $xml->value,
                                isset($timezone) ? $timezone : $timezone = new \DateTimeZone('UTC')
                            );
                            break;

                        case 'base64':
                            $value = Base64Value::deserialize($xml->value);
                            break;

                        case 'dom':
                            $doc = new \DOMDocument('1.0', 'UTF-8');
                            $doc->loadXML($aggregates[$depth + 1]);
                            $value = $doc;
                            break;

                        default:
                            $value = &$xml->value;
                            break;
                    }

                    $aggregates[$depth + 1] = $value;
                    if ($nextExpectedElements === null) {
                        break;
                    }
                    // Next: any
                    $nextExpectedElements = 0b111111111111111111111111111;
                    break;
            }

            if ($xml->isEmptyElement && $nodeType !== \XMLReader::END_ELEMENT) {
                $nodeType = \XMLReader::END_ELEMENT;
                goto processing;
            }
        }

        libxml_use_internal_errors($useErrors);

        $result = $aggregates ? array_pop($aggregates[0]) : null;

        if ($isFault) {
            throw FaultException::createFromResponse($result);
        }

        return $result;
    }
}


Issues (11)

Security Analysis no request data

src/Parser/XmlReaderParser.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1		<?php
2
3		namespace Fxmlrpc\Serialization\Parser;
4
5		use Fxmlrpc\Serialization\Exception\FaultException;
6		use Fxmlrpc\Serialization\Exception\UnexpectedTagException;
7		use Fxmlrpc\Serialization\Parser;
8		use Fxmlrpc\Serialization\Value\Base64Value;
9		use Fxmlrpc\Serialization\XmlChecker;
10
11		/**
12		* Parser to parse XML responses into its PHP representation using XML Reader extension.
13		*
14		* @author Lars Strojny <[email protected]>
15		*/
16		final class XmlReaderParser implements Parser
17		{
18		/**
19		* @var bool
20		*/
21		private $validateResponse;
22
23		/**
24		* @param bool $validateResponse
25		*/
26		public function __construct($validateResponse = true)
27		{
28		$this->validateResponse = $validateResponse;
29		}
30
31		/**
32		* {@inheritdoc}
33		*/
34		public function parse($xmlString)
35		{
36		if ($this->validateResponse) {
37		XmlChecker::isValid($xmlString);
38		}
39
40		$useErrors = libxml_use_internal_errors(true);
41
42		$xml = new \XMLReader();
43		$xml->xml($xmlString, 'UTF-8', LIBXML_COMPACT \| LIBXML_NOCDATA \| LIBXML_NOBLANKS \| LIBXML_PARSEHUGE);
44		$xml->setParserProperty(\XMLReader::VALIDATE, false);
45		$xml->setParserProperty(\XMLReader::LOADDTD, false);
46
47		// This following assignments are auto-generated using Fxmlrpc\Serialization\CodeGenerator\XmlReaderParserBitmaskGenerator
48		// Don’t edit manually
49		static $flagmethodResponse = 0b000000000000000000000000001;
50		static $flagparams = 0b000000000000000000000000010;
51		static $flagfault = 0b000000000000000000000000100;
52		static $flagparam = 0b000000000000000000000001000;
53		static $flagvalue = 0b000000000000000000000010000;
54		static $flagarray = 0b000000000000000000000100000;
55		static $flagmember = 0b000000000000000000001000000;
56		static $flagname = 0b000000000000000000010000000;
57		${'flag#text'} = 0b000000000000000000100000000;
58		static $flagstring = 0b000000000000000001000000000;
59		static $flagstruct = 0b000000000000000010000000000;
60		static $flagint = 0b000000000000000100000000000;
61		static $flagbiginteger = 0b000000000000001000000000000;
62		static $flagi8 = 0b000000000000010000000000000;
63		static $flagi4 = 0b000000000000100000000000000;
64		static $flagi2 = 0b000000000001000000000000000;
65		static $flagi1 = 0b000000000010000000000000000;
66		static $flagboolean = 0b000000000100000000000000000;
67		static $flagdouble = 0b000000001000000000000000000;
68		static $flagfloat = 0b000000010000000000000000000;
69		static $flagbigdecimal = 0b000000100000000000000000000;
70		${'flagdateTime.iso8601'} = 0b000001000000000000000000000;
71		static $flagdateTime = 0b000010000000000000000000000;
72		static $flagbase64 = 0b000100000000000000000000000;
73		static $flagnil = 0b001000000000000000000000000;
74		static $flagdom = 0b010000000000000000000000000;
75		static $flagdata = 0b100000000000000000000000000;
76		// End of auto-generated code
77
78		$aggregates = [];
79		$depth = 0;
80		$nextExpectedElements = 0b000000000000000000000000001;
81		$i = 0;
82		$isFault = false;
83
84		while ($xml->read()) {
85		++$i;
86		$nodeType = $xml->nodeType;
87
88		if (($nodeType === \XMLReader::COMMENT \|\| $nodeType === \XMLReader::DOC_TYPE) \|\|
89		(
90		$nodeType === \XMLReader::SIGNIFICANT_WHITESPACE &&
91		($nextExpectedElements & 0b000000000000000000100000000) !== 0b000000000000000000100000000)
92		) {
93		continue;
94		}
95
96		if ($nodeType === \XMLReader::ENTITY_REF) {
97		return '';
98		}
99
100		$tagName = $xml->localName;
101
102		if ($nextExpectedElements !== null &&
103		($flag = isset(${'flag'.$tagName}) ? ${'flag'.$tagName} : -1) &&
104		($nextExpectedElements & $flag) !== $flag
105		) {
106		throw new UnexpectedTagException(
107		$tagName,
108		$nextExpectedElements,
109		get_defined_vars(),
110		$xml->depth,
111		$xml->readOuterXml()
112		);
113		}
114
115		processing:
116		switch ($nodeType) {
117		case \XMLReader::ELEMENT:
118		switch ($tagName) {
119		case 'methodResponse':
120		// Next: params, fault
121		$nextExpectedElements = 0b000000000000000000000000110;
122		break;
123
124		case 'params':
125		// Next: param
126		$nextExpectedElements = 0b000000000000000000000001000;
127		$aggregates[$depth] = [];
128		break;
129
130		case 'fault':
131		$isFault = true;
132		// Break intentionally omitted
133		case 'param':
134		// Next: value
135		$nextExpectedElements = 0b000000000000000000000010000;
136		break;
137
138		case 'array':
139		$aggregates[++$depth] = [];
140		// Break intentionally omitted
141		case 'data':
142		// Next: array, data, value
143		$nextExpectedElements = 0b100000000000000000000110000;
144		break;
145
146		case 'struct':
147		// Next: struct, member, value
148		$nextExpectedElements = 0b000000000000000010001010000;
149		$aggregates[++$depth] = [];
150		break;
151
152		case 'member':
153		// Next: name, value
154		$nextExpectedElements = 0b000000000000000000010010000;
155		$aggregates[++$depth] = [];
156		break;
157
158		case 'name':
159		// Next: #text
160		$nextExpectedElements = 0b000000000000000000100000000;
161		$type = 'name';
162		break;
163
164		case 'value':
165		$nextExpectedElements = 0b011111111111111111100110000;
166		$type = 'value';
167		$aggregates[$depth + 1] = '';
168		break;
169
170		case 'base64':
171		case 'string':
172		case 'biginteger':
173		case 'i8':
174		case 'dateTime.iso8601':
175	View Code Duplication	case 'dateTime':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		// Next: value, $tagName, #text
177		$nextExpectedElements = 0b000000000000000000100010000 \| ${'flag'.$tagName};
178		$type = $tagName;
179		$aggregates[$depth + 1] = '';
180		break;
181
182	View Code Duplication	case 'nil':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
183		// Next: value, $tagName
184		$nextExpectedElements = 0b001000000000000000000010000 \| ${'flag'.$tagName};
185		$type = $tagName;
186		$aggregates[$depth + 1] = null;
187		break;
188
189		case 'int':
190		case 'i4':
191		case 'i2':
192	View Code Duplication	case 'i1':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
193		// Next: value, #text, $tagName
194		$nextExpectedElements = 0b000000000000000000100010000 \| ${'flag'.$tagName};
195		$type = $tagName;
196		$aggregates[$depth + 1] = 0;
197		break;
198
199	View Code Duplication	case 'boolean':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
200		// Next: value, #text, $tagName
201		$nextExpectedElements = 0b000000000000000000100010000 \| ${'flag'.$tagName};
202		$type = 'boolean';
203		$aggregates[$depth + 1] = false;
204		break;
205
206		case 'double':
207		case 'float':
208	View Code Duplication	case 'bigdecimal':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
209		// Next: value, #text, $tagName
210		$nextExpectedElements = 0b000000000000000000100010000 \| ${'flag'.$tagName};
211		$type = $tagName;
212		$aggregates[$depth + 1] = 0.0;
213		break;
214
215		case 'dom':
216		$type = 'dom';
217		// Disable type checking
218		$nextExpectedElements = null;
219		$aggregates[$depth + 1] = $xml->readInnerXml();
220		break;
221		}
222		break;
223
224		case \XMLReader::END_ELEMENT:
225		switch ($tagName) {
226		case 'params':
227		case 'fault':
228		break 3;
229
230		case 'param':
231		// Next: params, param
232		$nextExpectedElements = 0b000000000000000000000001010;
233		break;
234
235	View Code Duplication	case 'value':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
236		$nextExpectedElements = 0b100100000011100100011011100;
237		$aggregates[$depth][] = $aggregates[$depth + 1];
238		break;
239
240		case 'array':
241		case 'struct':
242		--$depth;
243		// Break intentionally omitted
244		case 'string':
245		case 'int':
246		case 'biginteger':
247		case 'i8':
248		case 'i4':
249		case 'i2':
250		case 'i1':
251		case 'boolean':
252		case 'double':
253		case 'float':
254		case 'bigdecimal':
255		case 'dateTime.iso8601':
256		case 'dateTime':
257		case 'base64':
258		case 'nil':
259		// Next: value
260		$nextExpectedElements = 0b000000000000000000000010000;
261		break;
262
263		case 'data':
264		// Next: array
265		$nextExpectedElements = 0b000000000000000000000100000;
266		break;
267
268	View Code Duplication	case 'name':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
269		// Next: value, member
270		$nextExpectedElements = 0b000000000000000000001010000;
271		$aggregates[$depth]['name'] = $aggregates[$depth + 1];
272		break;
273
274		case 'member':
275		// Next: struct, member
276		$nextExpectedElements = 0b000000000000000010001000000;
277		$aggregates[$depth - 1][$aggregates[$depth]['name']] = $aggregates[$depth][0];
278		unset($aggregates[$depth], $aggregates[$depth + 1]);
279		--$depth;
280		break;
281		}
282		break;
283
284		case \XMLReader::TEXT:
285		case \XMLReader::SIGNIFICANT_WHITESPACE:
286		switch ($type) {
		0 ignored issues – show Bug introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$type` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
287		case 'int':
288		case 'i4':
289		case 'i2':
290		case 'i1':
291		$value = (int) $xml->value;
292		break;
293
294		case 'boolean':
295		$value = $xml->value === '1';
296		break;
297
298		case 'double':
299		case 'float':
300		case 'bigdecimal':
301		$value = (float) $xml->value;
302		break;
303
304	View Code Duplication	case 'dateTime.iso8601':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
305		$value = \DateTime::createFromFormat(
306		'Ymd\TH:i:s',
307		$xml->value,
308		isset($timezone) ? $timezone : $timezone = new \DateTimeZone('UTC')
309		);
310		break;
311
312	View Code Duplication	case 'dateTime':
		0 ignored issues – show Duplication introduced 2016-01-01 12:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
313		$value = \DateTime::createFromFormat(
314		'Y-m-d\TH:i:s.uP',
315		$xml->value,
316		isset($timezone) ? $timezone : $timezone = new \DateTimeZone('UTC')
317		);
318		break;
319
320		case 'base64':
321		$value = Base64Value::deserialize($xml->value);
322		break;
323
324		case 'dom':
325		$doc = new \DOMDocument('1.0', 'UTF-8');
326		$doc->loadXML($aggregates[$depth + 1]);
327		$value = $doc;
328		break;
329
330		default:
331		$value = &$xml->value;
332		break;
333		}
334
335		$aggregates[$depth + 1] = $value;
336		if ($nextExpectedElements === null) {
337		break;
338		}
339		// Next: any
340		$nextExpectedElements = 0b111111111111111111111111111;
341		break;
342		}
343
344		if ($xml->isEmptyElement && $nodeType !== \XMLReader::END_ELEMENT) {
345		$nodeType = \XMLReader::END_ELEMENT;
346		goto processing;
347		}
348		}
349
350		libxml_use_internal_errors($useErrors);
351
352		$result = $aggregates ? array_pop($aggregates[0]) : null;
353
354		if ($isFault) {
355		throw FaultException::createFromResponse($result);
356		}
357
358		return $result;
359		}
360		}
361

fxmlrpc / serialization

Issues (11)

Security Analysis no request data

src/Parser/XmlReaderParser.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like