Issues in BenchmarkTest.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/FwlibTest/Test/Benchmark/BenchmarkTest.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace FwlibTest\Test\Benchmark;

use Fwlib\Test\Benchmark\Benchmark;
use Fwlib\Test\Benchmark\Group;
use Fwlib\Test\Benchmark\Marker;
use Fwlib\Test\Benchmark\RendererInterface;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class BenchmarkTest extends PHPUnitTestCase
{
    /**
     * @param   string[]    $methods
     * @return  MockObject|Benchmark
     */
    protected function buildMock(array $methods = null)
    {
        $mock = $this->getMock(
            Benchmark::class,
            $methods
        );

        return $mock;
    }


    public function testAutoStop()

    {
        $benchmark = $this->buildMock(['getCurrentGroup', 'stop']);

        $group = (new Group(0))->setBeginTime(42);
        $benchmark->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getCurrentGroup')
            ->willReturn($group);

        $benchmark->expects($this->once())
            ->method('stop');


        $this->reflectionCall($benchmark, 'autoStop');
    }


    public function testDisplay()
    {
        $benchmark = $this->buildMock(['getOutput']);
        $benchmark->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getOutput')
            ->willReturn('dummy output');

        $this->expectOutputString('dummy output');
        $benchmark->display();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }


    public function testGetCurrentGroup()
    {
        $group = new Group(3);
        $benchmark = $this->buildMock();
        $this->reflectionSet($benchmark, 'groups', [3 => $group]);

        $this->reflectionSet($benchmark, 'groupId', 1);
        $this->assertNull($this->reflectionCall($benchmark, 'getCurrentGroup'));

        $this->reflectionSet($benchmark, 'groupId', 3);
        $this->assertInstanceOf(
            Group::class,
            $this->reflectionCall($benchmark, 'getCurrentGroup')
        );
    }


    public function testGetOutput()
    {
        $benchmark = $this->buildMock(['autoStop']);
        $benchmark->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('autoStop');

        $benchmark->getOutput();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }


    public function testGetTime()
    {
        $benchmark = $this->buildMock();

        $time = $this->reflectionCall($benchmark, 'getTime');
        // Convert float to string with strval() will loose precision
        $timeStr = sprintf('%f', $time);

        $this->assertRegExp('/\d+\.\d{3,}/', $timeStr);
    }


    public function testMark()
    {
        $benchmark = $this->buildMock();

        $benchmark->start();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $benchmark->mark('m1');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $benchmark->mark('', 'red');

        $markerId = $this->reflectionGet($benchmark, 'markerId');
        $this->assertEquals(2, $markerId);

        // When stop, marker id is reset
        $benchmark->stop();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $markerId = $this->reflectionGet($benchmark, 'markerId');
        $this->assertEquals(0, $markerId);

        /** @var Marker[] $markers */
        $markers = $this->reflectionGet($benchmark, 'markers')[0];
        $marker0 = $markers[0];
        $marker1 = $markers[1];
        $this->assertEquals('m1', $marker0->getDescription());
        $this->assertNotEmpty($marker1->getDescription());
        $this->assertEquals('red', $marker1->getColor());
    }


    public function testSetGetRenderer()
    {
        $benchmark = $this->buildMock();

        /** @var MockObject|RendererInterface $renderer */
        $renderer = $this->getMockBuilder(RendererInterface::class)
            ->getMockForAbstractClass();

        $benchmark->setRenderer($renderer);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $newRenderer = $this->reflectionCall($benchmark, 'getRenderer');

        $this->assertInstanceOf(RendererInterface::class, $newRenderer);
    }
}


1		<?php
2		namespace FwlibTest\Test\Benchmark;
3
4		use Fwlib\Test\Benchmark\Benchmark;
5		use Fwlib\Test\Benchmark\Group;
6		use Fwlib\Test\Benchmark\Marker;
7		use Fwlib\Test\Benchmark\RendererInterface;
8		use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
9		use PHPUnit_Framework_MockObject_MockObject as MockObject;
10
11		/**
12		* @copyright Copyright 2015 Fwolf
13		* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
14		*/
15		class BenchmarkTest extends PHPUnitTestCase
16		{
17		/**
18		* @param string[] $methods
19		* @return MockObject\|Benchmark
20		*/
21		protected function buildMock(array $methods = null)
22		{
23		$mock = $this->getMock(
24		Benchmark::class,
25		$methods
26		);
27
28		return $mock;
29		}
30
31
32	View Code Duplication	public function testAutoStop()
		0 ignored issues – show Duplication introduced 2018-01-24 08:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		$benchmark = $this->buildMock(['getCurrentGroup', 'stop']);
35
36		$group = (new Group(0))->setBeginTime(42);
37		$benchmark->expects($this->once())
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Fwlib\Test\Benchmark\Benchmark`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38		->method('getCurrentGroup')
39		->willReturn($group);
40
41		$benchmark->expects($this->once())
42		->method('stop');
43
44
45		$this->reflectionCall($benchmark, 'autoStop');
46		}
47
48
49		public function testDisplay()
50		{
51		$benchmark = $this->buildMock(['getOutput']);
52		$benchmark->expects($this->once())
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Fwlib\Test\Benchmark\Benchmark`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		->method('getOutput')
54		->willReturn('dummy output');
55
56		$this->expectOutputString('dummy output');
57		$benchmark->display();
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `display` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58		}
59
60
61		public function testGetCurrentGroup()
62		{
63		$group = new Group(3);
64		$benchmark = $this->buildMock();
65		$this->reflectionSet($benchmark, 'groups', [3 => $group]);
66
67		$this->reflectionSet($benchmark, 'groupId', 1);
68		$this->assertNull($this->reflectionCall($benchmark, 'getCurrentGroup'));
69
70		$this->reflectionSet($benchmark, 'groupId', 3);
71		$this->assertInstanceOf(
72		Group::class,
73		$this->reflectionCall($benchmark, 'getCurrentGroup')
74		);
75		}
76
77
78		public function testGetOutput()
79		{
80		$benchmark = $this->buildMock(['autoStop']);
81		$benchmark->expects($this->once())
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Fwlib\Test\Benchmark\Benchmark`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
82		->method('autoStop');
83
84		$benchmark->getOutput();
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getOutput` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
85		}
86
87
88		public function testGetTime()
89		{
90		$benchmark = $this->buildMock();
91
92		$time = $this->reflectionCall($benchmark, 'getTime');
93		// Convert float to string with strval() will loose precision
94		$timeStr = sprintf('%f', $time);
95
96		$this->assertRegExp('/\d+\.\d{3,}/', $timeStr);
97		}
98
99
100		public function testMark()
101		{
102		$benchmark = $this->buildMock();
103
104		$benchmark->start();
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `start` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
105		$benchmark->mark('m1');
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `mark` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
106		$benchmark->mark('', 'red');
107
108		$markerId = $this->reflectionGet($benchmark, 'markerId');
109		$this->assertEquals(2, $markerId);
110
111		// When stop, marker id is reset
112		$benchmark->stop();
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `stop` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
113		$markerId = $this->reflectionGet($benchmark, 'markerId');
114		$this->assertEquals(0, $markerId);
115
116		/** @var Marker[] $markers */
117		$markers = $this->reflectionGet($benchmark, 'markers')[0];
118		$marker0 = $markers[0];
119		$marker1 = $markers[1];
120		$this->assertEquals('m1', $marker0->getDescription());
121		$this->assertNotEmpty($marker1->getDescription());
122		$this->assertEquals('red', $marker1->getColor());
123		}
124
125
126		public function testSetGetRenderer()
127		{
128		$benchmark = $this->buildMock();
129
130		/** @var MockObject\|RendererInterface $renderer */
131		$renderer = $this->getMockBuilder(RendererInterface::class)
132		->getMockForAbstractClass();
133
134		$benchmark->setRenderer($renderer);
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$renderer` defined by `$this->getMockBuilder(\F...tMockForAbstractClass()` on line `131` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Fwlib\Test\Benchmark\Benchmark::setRenderer()` does only seem to accept `object<Fwlib\Test\Benchmark\RendererInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setRenderer` does only exist in `Fwlib\Test\Benchmark\Benchmark`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
135		$newRenderer = $this->reflectionCall($benchmark, 'getRenderer');
136
137		$this->assertInstanceOf(RendererInterface::class, $newRenderer);
138		}
139		}
140

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

tests/FwlibTest/Test/Benchmark/BenchmarkTest.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like