Issues in SyncDbSchemaTest.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/FwlibTest/Db/SyncDbSchemaTest.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace FwlibTest\Db;

use Fwlib\Db\SyncDbSchema;
use Fwlib\Test\AbstractDbRelateTest;

/**
 * @copyright   Copyright 2013-2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class SyncDbSchemaTest extends AbstractDbRelateTest
{
    protected static $dbUsing = 'default';
    private static $logTable = 'log_sync_db_schema';

    /** @var SyncDbSchema */
    private static $sds = null;


    public static function setUpBeforeClass()
    {
        parent::setUpBeforeClass();

        // Delete log table if exists
        if (self::$db->isTableExist(self::$logTable)) {
            self::$db->execute('DROP TABLE ' . self::$logTable);
        }
    }


    public function testConstruct()
    {
        $this->assertFalse(self::$db->isTableExist(self::$logTable));

        $this->expectOutputRegex(
            '/Log table \w+ does not exists, create it, done\./'
        );

        self::$sds = (new SyncDbSchema)
            ->setLogTable(self::$logTable)
            ->setDb($this->getServiceContainer()->getDb());

        $this->assertEquals(self::$logTable, self::$sds->getLogTable());
        $this->assertTrue(self::$db->isTableExist(self::$logTable));

        self::$sds->charsetPhp = 'UTF-8';

    }


    public function testConstruct2()
    {
        $this->expectOutputRegex('/Log table \w+ already exists\./');
        $sds = (new SyncDbSchema)
            ->setLogTable(self::$logTable)
            ->setDb($this->getServiceContainer()->getDb());
        unset($sds);
    }


    /**
     * 1
     */
    public function testExecuteFirstSql()
    {
        $arColumn = self::$db->getMetaColumn(self::$tableUser);
        $this->assertFalse(isset($arColumn['temp1']));

        $this->expectOutputRegex('/Total \d+ SQL executed successful./');
        self::$sds->setSql(
            42,
            'ALTER TABLE ' . self::$tableUser . '
                ADD COLUMN temp1 INT NOT NULL DEFAULT 0'
        );
        self::$sds->execute();

        $arColumn = self::$db->getMetaColumn(self::$tableUser, true);
        $this->assertTrue(isset($arColumn['temp1']));
    }


    /**
     * 2 No more SQL
     */
    public function testExecuteNoUnDoneSql()
    {
        $this->expectOutputRegex('/No un-done SQL to do./');
        self::$sds->execute();
    }


    /**
     * 3 Add an error SQL
     */
    public function testExecuteErrorSql()

    {
        $this->expectOutputRegex('/Execute abort./');
        self::$sds->setSql(
            43,
            'ALTER TABLE ' . self::$tableUser . '
                ADD COLUMN temp1 INT NOT NULL DEFAULT 0'
        );
        self::$sds->execute();

        $this->assertEquals(43, self::$sds->lastId);
        $this->assertEquals(42, self::$sds->lastIdDone);
    }


    /**
     * 4 Add SQL with smaller id, will not execute
     */
    public function testExecuteSmallId()

    {
        $this->expectOutputRegex('/No un-done SQL to do./');
        self::$sds->setSql(
            22,
            'ALTER TABLE ' . self::$tableUser . '
                ADD COLUMN temp2 INT NOT NULL DEFAULT 0'
        );
        self::$sds->execute();

        // Error SQL 43 is cleared by execute()
        $this->assertEquals(42, self::$sds->getLastId());
        $this->assertEquals(42, self::$sds->getLastIdDone());
    }
}


1		<?php
2		namespace FwlibTest\Db;
3
4		use Fwlib\Db\SyncDbSchema;
5		use Fwlib\Test\AbstractDbRelateTest;
6
7		/**
8		* @copyright Copyright 2013-2015 Fwolf
9		* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
10		*/
11		class SyncDbSchemaTest extends AbstractDbRelateTest
12		{
13		protected static $dbUsing = 'default';
14		private static $logTable = 'log_sync_db_schema';
15
16		/** @var SyncDbSchema */
17		private static $sds = null;
18
19
20		public static function setUpBeforeClass()
21		{
22		parent::setUpBeforeClass();
23
24		// Delete log table if exists
25		if (self::$db->isTableExist(self::$logTable)) {
26		self::$db->execute('DROP TABLE ' . self::$logTable);
27		}
28		}
29
30
31		public function testConstruct()
32		{
33		$this->assertFalse(self::$db->isTableExist(self::$logTable));
34
35		$this->expectOutputRegex(
36		'/Log table \w+ does not exists, create it, done\./'
37		);
38
39		self::$sds = (new SyncDbSchema)
40		->setLogTable(self::$logTable)
41		->setDb($this->getServiceContainer()->getDb());
42
43		$this->assertEquals(self::$logTable, self::$sds->getLogTable());
44		$this->assertTrue(self::$db->isTableExist(self::$logTable));
45
46		self::$sds->charsetPhp = 'UTF-8';
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `charsetPhp` does not seem to exist in `Fwlib\Db\SyncDbSchema`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
47		}
48
49
50		public function testConstruct2()
51		{
52		$this->expectOutputRegex('/Log table \w+ already exists\./');
53		$sds = (new SyncDbSchema)
54		->setLogTable(self::$logTable)
55		->setDb($this->getServiceContainer()->getDb());
56		unset($sds);
57		}
58
59
60		/**
61		* 1
62		*/
63		public function testExecuteFirstSql()
64		{
65		$arColumn = self::$db->getMetaColumn(self::$tableUser);
66		$this->assertFalse(isset($arColumn['temp1']));
67
68		$this->expectOutputRegex('/Total \d+ SQL executed successful./');
69		self::$sds->setSql(
70		42,
71		'ALTER TABLE ' . self::$tableUser . '
72		ADD COLUMN temp1 INT NOT NULL DEFAULT 0'
73		);
74		self::$sds->execute();
75
76		$arColumn = self::$db->getMetaColumn(self::$tableUser, true);
77		$this->assertTrue(isset($arColumn['temp1']));
78		}
79
80
81		/**
82		* 2 No more SQL
83		*/
84		public function testExecuteNoUnDoneSql()
85		{
86		$this->expectOutputRegex('/No un-done SQL to do./');
87		self::$sds->execute();
88		}
89
90
91		/**
92		* 3 Add an error SQL
93		*/
94	View Code Duplication	public function testExecuteErrorSql()
		0 ignored issues – show Duplication introduced 2018-01-24 08:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		{
96		$this->expectOutputRegex('/Execute abort./');
97		self::$sds->setSql(
98		43,
99		'ALTER TABLE ' . self::$tableUser . '
100		ADD COLUMN temp1 INT NOT NULL DEFAULT 0'
101		);
102		self::$sds->execute();
103
104		$this->assertEquals(43, self::$sds->lastId);
105		$this->assertEquals(42, self::$sds->lastIdDone);
106		}
107
108
109		/**
110		* 4 Add SQL with smaller id, will not execute
111		*/
112	View Code Duplication	public function testExecuteSmallId()
		0 ignored issues – show Duplication introduced 2018-01-24 08:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		$this->expectOutputRegex('/No un-done SQL to do./');
115		self::$sds->setSql(
116		22,
117		'ALTER TABLE ' . self::$tableUser . '
118		ADD COLUMN temp2 INT NOT NULL DEFAULT 0'
119		);
120		self::$sds->execute();
121
122		// Error SQL 43 is cleared by execute()
123		$this->assertEquals(42, self::$sds->getLastId());
124		$this->assertEquals(42, self::$sds->getLastIdDone());
125		}
126		}
127

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

tests/FwlibTest/Db/SyncDbSchemaTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like