Issues in AdodbMysqlTest.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/FwlibTest/Bridge/AdodbMysqlTest.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace FwlibTest\Bridge;

use Fwlib\Bridge\Adodb;
use Fwlib\Config\GlobalConfig;
use Fwlib\Db\SqlGenerator;
use Fwlib\Test\AbstractDbRelateTest;
use Fwlib\Util\UtilContainerAwareTrait;

/**
 * @copyright   Copyright 2013-2015, 2017 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class AdodbMysqlTest extends AbstractDbRelateTest
{
    use UtilContainerAwareTrait;


    protected static $dbUsing = 'mysql';


    public function generateUuid()
    {
        return $this->getUtilContainer()->getUuidBase16()->generate();
    }


    /**
     * Notice: Parameter type in adodb::SetFetchMode() is wrong, version 5.07
     * - 5.19
     */
    public function testCall()
    {
        /** @var \ADOConnection $dbMysql */
        $dbMysql = self::$dbMysql;

        $fetchMode = $dbMysql->fetchMode;
        $dbMysql->setFetchMode(3);    // Both

        $ar = $dbMysql->GetAll('SELECT 1 AS a');
        $y = [['1', 'a' => '1']];
        $this->assertEqualArray($y, $ar);

        $ar = $dbMysql->CacheGetAll(1, 'SELECT 1 AS a');
        $y = [['1', 'a' => '1']];
        $this->assertEqualArray($y, $ar);

        $dbMysql->setFetchMode($fetchMode);
    }


    public function testConstruct()
    {
        $profile = GlobalConfig::getInstance()->get('dbserver.mysql');
        $db = new Adodb($profile);

        $this->assertEqualArray($profile, $db->getProfile());

        // SqlGenerator is not instanced now, see testGenerateSql()
        $this->assertNull($this->reflectionGet($db, 'sqlGenerator'));
    }


    public function testConnect()
    {
        // Clone doesn't affect property object conn
        //$conn = clone self::$dbMysql;

        // Check connection is reused
        $y = self::$dbMysql->_connectionID->thread_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::$dbMysql->connect(false);
        $x = self::$dbMysql->_connectionID->thread_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertEquals($y, $x);

        // Force re-connect
        self::$dbMysql->connect(true);
        $x = self::$dbMysql->_connectionID->thread_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertNotEquals($y, $x);
    }


    public function testConvertEncodingResult()

    {
        // Backup original charset
        $originalCharsetPhp = self::$dbMysql->charsetPhp;
        $originalCharsetDb = self::$dbMysql->profile['lang'];

        self::$dbMysql->setCharsetPhp('UTF-8');
        self::$dbMysql->profile['lang'] = 'GB2312';

        $x = [null, '你好'];
        $y = [null, mb_convert_encoding('你好', 'UTF-8', 'GB2312')];
        $this->assertEquals(
            $y,
            self::$dbMysql->convertEncodingResult($x)
        );


        // Recover original charset
        self::$dbMysql->setCharsetPhp($originalCharsetPhp);
        self::$dbMysql->profile['lang'] = $originalCharsetDb;
    }


    public function testConvertEncodingSql()

    {
        // Backup original charset
        $originalCharsetPhp = self::$dbMysql->charsetPhp;
        $originalCharsetDb = self::$dbMysql->profile['lang'];

        self::$dbMysql->setCharsetPhp('UTF-8');
        self::$dbMysql->profile['lang'] = 'GB2312';

        $x = [null, '你好'];
        $y = [null, mb_convert_encoding('你好', 'GB2312', 'UTF-8')];
        $this->assertEquals(
            $y,
            self::$dbMysql->convertEncodingSql($x)
        );


        // Recover original charset
        self::$dbMysql->setCharsetPhp($originalCharsetPhp);
        self::$dbMysql->profile['lang'] = $originalCharsetDb;
    }


    /**
     * @expectedException \PHPUnit_Framework_Error
     */
    public function testDeleteRow()
    {
        $i = self::$dbMysql->deleteRow(self::$tableUser, '');
        $this->assertEquals(-1, $i);

        $i = self::$dbMysql->deleteRow(
            self::$tableUser,
            'WHERE FALSE'
        );
        $this->assertEquals(0, $i);

        // When use executePrepare(), error was detected and rollback, so
        // return 0 instead of -1, throw exception.
        self::$dbMysql->deleteRow(
            self::$tableUser,
            'WHERE ERROR_CLAUSE'
        );
    }


    public function testError()
    {
        self::$dbMysql->execute('SELECT 1');
        $this->assertEquals('', self::$dbMysql->getErrorMessage());
        $this->assertEquals('', self::$dbMysql->errorMsg());
        $this->assertEquals(0, self::$dbMysql->getErrorCode());
        $this->assertEquals(0, self::$dbMysql->errorNo());
    }


    public function testExecute()
    {
        self::$dbMysql->execute(
            [
                'SELECT'    => 'uuid',
                'FROM'      => self::$tableUser,
                'LIMIT'     => 1
            ]
        );
        $this->assertEquals(0, self::$dbMysql->getErrorCode());
    }


    /**
     * @expectedException \PHPUnit_Framework_Error
     */
    public function testExecutePrepare()
    {
        self::$dbMysql->executePrepare(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'SELECT'    => 'uuid',
                'FROM'      => self::$tableUser,
                'LIMIT'     => 1
            ]
        );
        $this->assertEquals(0, self::$dbMysql->getErrorCode());

        self::$dbMysql->executePrepare(
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'SELECT'    => 'uuid',
                'FROM'      => self::$tableUser,
                'WHERE'     => 'Error Clause',
            ]
        );
    }


    /**
     * Test for Mysql db only
     */
    public function testForMysqlOnly()
    {
        if (!self::$dbMysql->isDbMysql()) {
            $this->markTestSkipped('Skip mysql only test.');
        }

        $this->assertEquals(
            ";\n",
            self::$dbMysql->getSqlDelimiter()
        );

        $this->assertEquals(
            false,
            self::$dbMysql->isTimestampUnique()
        );
    }


    public function testGenerateSql()
    {
        $userTable = self::$tableUser;

        $x = self::$dbMysql->generateSql('');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals('', $x);


        // SqlGenerator is instanced now
        $this->assertInstanceOf(
            SqlGenerator::class,
            $this->reflectionGet(self::$dbMysql, 'sqlGenerator')
        );


        $ar = [
            'SELECT'    => 'title',
            'FROM'      => $userTable,
        ];
        $x = self::$dbMysql->generateSql($ar);
        $y = "SELECT title FROM $userTable";
        $this->assertEquals($y, $x);
    }


    public function testGenerateSqlPrepared()
    {
        $userTable = self::$tableUser;

        $x = self::$dbMysql->generateSqlPrepared('');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertEquals('', $x);

        $ar = [
            'INSERT'    => self::$tableUser,
            'VALUES'    => [
                'uuid'  => self::$dbMysql->param('uuid'),
                'title' => self::$dbMysql->param('title'),
                'age'   => self::$dbMysql->param('age'),
            ],
        ];
        $x = self::$dbMysql->generateSqlPrepared($ar);
        $y = "INSERT INTO $userTable(uuid, title, age) VALUES (?, ?, ?)";
        $this->assertEquals($y, $x);
    }


    /**
     * @expectedException \PHPUnit_Framework_Error_Warning
     */
    public function testGetByKey()
    {
        // Normal getByKey() tested with write()

        // Prepare data
        $uuid = $this->generateUuid();
        $ar = [
            'uuid'  => $uuid,
            'title' => 'Title',
            'age'   => 42,
        ];
        self::$dbMysql->write(self::$tableUser, $ar);


        // Different way to read one column
        $this->assertEquals(
            'Title',
            self::$dbMysql->getByKey(self::$tableUser, $uuid, 'title')
        );
        $this->assertEquals(
            'Title',
            self::$dbMysql->getByKey(self::$tableUser, $uuid, 'title', 'uuid')
        );
        $this->assertEquals(
            'Title',
            self::$dbMysql->getByKey(
                self::$tableUser,
                [$uuid],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'title',
                ['uuid']
            )
        );

        // Read more than one column
        $this->assertEqualArray(
            ['title' => 'Title', 'age' => '42'],
            self::$dbMysql->getByKey(self::$tableUser, $uuid, 'title, age')
        );

        // * col
        $data = self::$dbMysql->getByKey(self::$tableUser, $uuid);
        $this->assertEquals('Title', $data['title']);
        $this->assertEquals(42, $data['age']);

        // Not exists data
        $data = self::$dbMysql->getByKey(self::$tableUser, $uuid . 'foo');
        $this->assertEquals(null, $data);

        // More PK value than column, throw exception
        $this->assertEquals(
            null,
            self::$dbMysql->getByKey(self::$tableUser, [1, 2], 'title')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }


    public function testGetMetaPrimaryKey()
    {
        // Normal test completed by other method

        $this->assertEquals(
            null,
            self::$dbMysql->getMetaPrimaryKey(self::$tableUser . '_not_exists')
        );
    }


    public function testGetMetaTimestamp()
    {
        $this->assertEquals(
            '',
            self::$dbMysql->getMetaTimeStamp(self::$tableUser . '_not_exists')
        );

        $this->assertEquals(
            '',
            self::$dbMysql->getMetaTimeStamp(self::$tableGroup)
        );
    }


    public function testGetProfileString()
    {
        $profileString = self::$dbMysql->getProfileString('-');
        $this->assertEquals(2, substr_count($profileString, '-'));
    }


    public function testGetQueryCount()
    {
        /** @var \ADOConnection|\Fwlib\Bridge\Adodb $db */
        $db = self::$dbMysql;
        $i = $db->getQueryCount();

        $db->GetAll('SELECT 1 AS a');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertEquals($i + 1, $db->getQueryCount());

        $db->CacheGetAll(0, 'SELECT 1 AS a');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertEquals($i + 1, $db->getQueryCount());

        $db->GetAll('SELECT 1 AS a');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertEquals($i + 2, $db->getQueryCount());
    }


    public function testGetSet()
    {
        self::$dbMysql->debug = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->assertFalse(self::$dbMysql->debug);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    public function testGetSqlTrans()
    {
        $this->assertEquals(
            'TRANSACTION',
            substr(self::$dbMysql->getSqlTransBegin(), 6, 11)
        );
        $this->assertStringStartsWith(
            'COMMIT',
            self::$dbMysql->getSqlTransCommit()
        );
        $this->assertStringStartsWith(
            'ROLLBACK',
            self::$dbMysql->getSqlTransRollback()
        );
    }


    public function testIsTblExist()
    {
        $this->assertTrue(self::$dbMysql->isTableExist(self::$tableUser));
        $this->assertFalse(
            self::$dbMysql->isTableExist(self::$tableUser . '_not_exists')
        );
    }


    /**
     * @expectedException \PHPUnit_Framework_Error_Warning
     */
    public function testQuoteValue()
    {
        // Normal test completed by other method

        // Quote un-exists column
        // Compare will not execute because exception will be caught by PHPUnit
        $col = 'not_exists';
        $this->assertEquals(
            '\'' . $col . '\'',
            self::$dbMysql->quoteValue(self::$tableUser, $col, $col)
        );
    }


    /**
     * @expectedException \PHPUnit_Framework_Error_Warning
     */
    public function testWrite()
    {
        $uuid = $this->generateUuid();

        // Auto INSERT
        $ar = [
            'uuid'  => $uuid,
            'title' => 'Title',
            'age'   => 42,
        ];
        self::$dbMysql->write(self::$tableUser, $ar);
        $this->assertEquals(
            'Title',
            self::$dbMysql->getByKey(self::$tableUser, $uuid, 'title')
        );

        // Auto UPDATE
        $ar['age'] = 24;
        self::$dbMysql->write(self::$tableUser, $ar);
        $this->assertEquals(
            24,
            self::$dbMysql->getByKey(self::$tableUser, $uuid, 'age')
        );

        // Write without PK, will fail
        unset($ar['uuid']);
        $this->assertEquals(
            -1,
            self::$dbMysql->write(self::$tableUser, $ar)
        );

        // For INSERT, will fail and throw exception
        $ar['uuid'] = $uuid;
        $this->assertEquals(
            -1,
            self::$dbMysql->write(self::$tableUser, $ar, 'I')
        );
    }
}


fwolf / fwlib

Issues (1752)

Security Analysis not enabled

tests/FwlibTest/Bridge/AdodbMysqlTest.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like