Issues in RequestTrait.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Fwlib/Web/RequestTrait.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Fwlib\Web;

use Fwlib\Base\SingletonTrait;
use Fwlib\Util\UtilContainer;

/**
 * Request content holder
 *
 * Content are cached as property. They can also be modified via setter, to
 * implement default module/action etc.
 *
 * @see         \Fwlib\Web\RequestInterface
 *
 * @property    string $actionParameter
 * @property    string $moduleParameter
 *
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
trait RequestTrait
{
    use SingletonTrait;


    /**
     * @var string
     */
    protected $action = null;

    /**
     * @var string
     */
    protected $module = null;


    /**
     * @see RequestInterface::getAction()
     *
     * @return  string
     */
    public function getAction()
    {
        if (is_null($this->action)) {
            $this->action = UtilContainer::getInstance()->getHttp()
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                ->getGet($this->actionParameter);
        }

        return $this->action;
    }


    /**
     * @see RequestInterface::getActionParameter()
     *
     * @return  string
     */
    public function getActionParameter()
    {
        return $this->actionParameter;
    }


    /**
     * @see RequestInterface::getModule()
     *
     * @return  string
     */
    public function getModule()
    {
        if (is_null($this->module)) {
            $this->module = UtilContainer::getInstance()->getHttp()
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                ->getGet($this->moduleParameter);
        }

        return $this->module;
    }


    /**
     * @see RequestInterface::getModuleParameter()
     *
     * @return  string
     */
    public function getModuleParameter()
    {
        return $this->moduleParameter;
    }


    /**
     * @see RequestInterface::setAction()
     *
     * @param   string $action
     * @return  $this
     */
    public function setAction($action)
    {
        $this->action = $action;

        return $this;
    }


    /**
     * @see RequestInterface::setActionParameter()
     *
     * @param   string $param
     * @return  $this
     */
    public function setActionParameter($param)
    {
        $this->actionParameter = $param;

        return $this;
    }


    /**
     * @see RequestInterface::setModule()
     *
     * @param   string $module
     * @return  $this
     */
    public function setModule($module)
    {
        $this->module = $module;

        return $this;
    }


    /**
     * @see RequestInterface::setModuleParameter()
     *
     * @param   string $param
     * @return  $this
     */
    public function setModuleParameter($param)
    {
        $this->moduleParameter = $param;

        return $this;
    }
}


1			<?php
2			namespace Fwlib\Web;
3
4			use Fwlib\Base\SingletonTrait;
5			use Fwlib\Util\UtilContainer;
6
7			/**
8			* Request content holder
9			*
10			* Content are cached as property. They can also be modified via setter, to
11			* implement default module/action etc.
12			*
13			* @see \Fwlib\Web\RequestInterface
14			*
15			* @property string $actionParameter
16			* @property string $moduleParameter
17			*
18			* @copyright Copyright 2015 Fwolf
19			* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
20			*/
21			trait RequestTrait
22			{
23			use SingletonTrait;
24
25
26			/**
27			* @var string
28			*/
29			protected $action = null;
30
31			/**
32			* @var string
33			*/
34			protected $module = null;
35
36
37			/**
38			* @see RequestInterface::getAction()
39			*
40			* @return string
41			*/
42			public function getAction()
43			{
44			if (is_null($this->action)) {
45			$this->action = UtilContainer::getInstance()->getHttp()
			0 ignored issues – show Documentation Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Fwlib\Util\UtilContaine...$this->actionParameter)` can also be of type `integer`. However, the property `$action` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
46			->getGet($this->actionParameter);
47			}
48
49			return $this->action;
50			}
51
52
53			/**
54			* @see RequestInterface::getActionParameter()
55			*
56			* @return string
57			*/
58			public function getActionParameter()
59			{
60			return $this->actionParameter;
61			}
62
63
64			/**
65			* @see RequestInterface::getModule()
66			*
67			* @return string
68			*/
69			public function getModule()
70			{
71			if (is_null($this->module)) {
72			$this->module = UtilContainer::getInstance()->getHttp()
			0 ignored issues – show Documentation Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Fwlib\Util\UtilContaine...$this->moduleParameter)` can also be of type `integer`. However, the property `$module` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
73			->getGet($this->moduleParameter);
74			}
75
76			return $this->module;
77			}
78
79
80			/**
81			* @see RequestInterface::getModuleParameter()
82			*
83			* @return string
84			*/
85			public function getModuleParameter()
86			{
87			return $this->moduleParameter;
88			}
89
90
91			/**
92			* @see RequestInterface::setAction()
93			*
94			* @param string $action
95			* @return $this
96			*/
97			public function setAction($action)
98			{
99			$this->action = $action;
100
101			return $this;
102			}
103
104
105			/**
106			* @see RequestInterface::setActionParameter()
107			*
108			* @param string $param
109			* @return $this
110			*/
111			public function setActionParameter($param)
112			{
113			$this->actionParameter = $param;
114
115			return $this;
116			}
117
118
119			/**
120			* @see RequestInterface::setModule()
121			*
122			* @param string $module
123			* @return $this
124			*/
125			public function setModule($module)
126			{
127			$this->module = $module;
128
129			return $this;
130			}
131
132
133			/**
134			* @see RequestInterface::setModuleParameter()
135			*
136			* @param string $param
137			* @return $this
138			*/
139			public function setModuleParameter($param)
140			{
141			$this->moduleParameter = $param;
142
143			return $this;
144			}
145			}
146

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

src/Fwlib/Web/RequestTrait.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like