Issues in regex_match.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

func/regex_match.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package		fwolflib
 * @copyright	Copyright 2007-2010, Fwolf
 * @author		Fwolf <[email protected]>
 * @since		2007-08-15
 */


require_once(dirname(__FILE__) . '/../fwolflib.php');


/**
 * Match content using preg, return result array or '' if non-match
 * To read content currectly, content parsing is nesessary
 * Return value maybe string or array, use careful and
 *   remind which value you use it for.
 *
 * @deprecated      Use Fwlib\Util\StringUtil::matchRegex()
 * @param	string	$preg
 * @param	string	$str
 * @param 	boolean	$csrts	Convert single result to str(array -> str) ?
 * @return	mixed
 * @access	public
 */
function RegexMatch($preg, $str = '', $csrts = true) {
	if (empty($preg) || empty($str)) return '';
	$i = preg_match_all($preg, $str, $ar, PREG_SET_ORDER);
	if (0 == $i || false === $i)

		// Got none match or Got error
		$ar = '';
	elseif (1 == $i)
	{
		// Got 1 match, return as string or array(2 value in 1 match)
		$ar = $ar[0];
		array_shift($ar);
		if (1 == count($ar) && true == $csrts)

			$ar = $ar[0];
	}
	else
	{
		// Got more than 1 match return array contains string or sub-array
		foreach ($ar as &$row)
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
		{
			array_shift($row);
			if (1 == count($row))
				$row = $row[0];
		}
	}
	return $ar;
} // end of func RegexMatch
?>



1		<?php
2		/**
3		* @package fwolflib
4		* @copyright Copyright 2007-2010, Fwolf
5		* @author Fwolf <[email protected]>
6		* @since 2007-08-15
7		*/
8
9
10		require_once(dirname(__FILE__) . '/../fwolflib.php');
11
12
13		/**
14		* Match content using preg, return result array or '' if non-match
15		* To read content currectly, content parsing is nesessary
16		* Return value maybe string or array, use careful and
17		* remind which value you use it for.
18		*
19		* @deprecated Use Fwlib\Util\StringUtil::matchRegex()
20		* @param string $preg
21		* @param string $str
22		* @param boolean $csrts Convert single result to str(array -> str) ?
23		* @return mixed
24		* @access public
25		*/
26		function RegexMatch($preg, $str = '', $csrts = true) {
27		if (empty($preg) \|\| empty($str)) return '';
28		$i = preg_match_all($preg, $str, $ar, PREG_SET_ORDER);
29	View Code Duplication	if (0 == $i \|\| false === $i)
		0 ignored issues – show Duplication introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		// Got none match or Got error
31		$ar = '';
32		elseif (1 == $i)
33		{
34		// Got 1 match, return as string or array(2 value in 1 match)
35		$ar = $ar[0];
36		array_shift($ar);
37		if (1 == count($ar) && true == $csrts)
		0 ignored issues – show Coding Style Best Practice introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
38		$ar = $ar[0];
39		}
40		else
41		{
42		// Got more than 1 match return array contains string or sub-array
43		foreach ($ar as &$row)
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$ar` of type `null\|array<integer,array<integer,string>>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
44		{
45		array_shift($row);
46		if (1 == count($row))
47		$row = $row[0];
48		}
49		}
50		return $ar;
51		} // end of func RegexMatch
52		?>
		0 ignored issues – show Best Practice introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
53

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

func/regex_match.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like