Issues in client.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

func/client.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Funcs about client side info
 *
 * @package		fwolflib
 * @subpackage	func
 * @copyright	Copyright 2003-2009, Fwolf
 * @author		Fwolf <[email protected]>
 * @since		2006-07-03
 */


require_once(dirname(__FILE__) . '/../fwolflib.php');


/**
 * Convert user ip from hex string
 *
 * @deprecated      Use Fwlib\Util\Ip::fromHex()
 * @param	string	$hex
 * @return	string
 * @link	http://us.php.net/uniqid
 */
function ClientIpFromHex($hex) {

	$ip = "";
	if (8 == strlen($hex)) {
		$ip .= hexdec(substr($hex ,0 ,2)) . '.';
		$ip .= hexdec(substr($hex ,2 ,2)) . '.';
		$ip .= hexdec(substr($hex ,4 ,2)) . '.';
		$ip .= hexdec(substr($hex ,6 ,2));
	}
    return $ip;
} // end of func ClientIpFromHex


/**
 * Convert user ip to hex string
 *
 * @deprecated      Use Fwlib\Util\Ip::toHex()
 * @param	string	$ip
 * @return	string
 * @link	http://us.php.net/uniqid
 */
function ClientIpToHex($ip = "") {
	$hex = "";
	if('' == $ip)
		//$ip = getenv('REMOTE_ADDR');
		$ip = GetClientIp();

	if (false == ip2long($ip))

		return '';
	else {
		$part = explode('.', $ip);
		if (4 != count($part))
			return '';
		else
			for ($i=0; $i<=count($part)-1; $i++) {
				$hex .= substr('0' . dechex($part[$i]), -2);
			}
	}
	return $hex;
} // end of func ClientIpToHex


/**
 * 检查客户端的浏览器是NS还是IE
 *
 * @deprecated      Use Fwlib\Util\HttpUtil::getBrowserType()
 * @return	string
 */
function GetBrowserType()
{
	$str = isset($_SERVER['HTTP_USER_AGENT']) ? $_SERVER['HTTP_USER_AGENT'] : '';
	if (false === strpos($str, 'MSIE')) {
	    return('NS');
	}
	else {
	    return('IE');
	}
} // end func GetBrowserType


/**
 * Get ip of client
 *
 * @deprecated      Use Fwlib\Util\HttpUtil::getClientIp()
 * @return	string
 * @link http://roshanbh.com.np/2007/12/getting-real-ip-address-in-php.html
 */
function GetClientIp() {
	$s = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	// Original way: check ip from share internet
	if (!empty($_SERVER['HTTP_CLIENT_IP'])) {
		$s = $_SERVER['HTTP_CLIENT_IP'];
	}
	// Using proxy ?
	elseif (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
		$s = $_SERVER['HTTP_X_FORWARDED_FOR'];
	}
	// Another way
	elseif (!empty($_SERVER['REMOTE_ADDR'])) {
		$s = $_SERVER['REMOTE_ADDR'];
	}
	else {
		$s = '';
	}
	return $s;
} // end of func GetClientIp


?>



1		<?php
2		/**
3		* Funcs about client side info
4		*
5		* @package fwolflib
6		* @subpackage func
7		* @copyright Copyright 2003-2009, Fwolf
8		* @author Fwolf <[email protected]>
9		* @since 2006-07-03
10		*/
11
12
13		require_once(dirname(__FILE__) . '/../fwolflib.php');
14
15
16		/**
17		* Convert user ip from hex string
18		*
19		* @deprecated Use Fwlib\Util\Ip::fromHex()
20		* @param string $hex
21		* @return string
22		* @link http://us.php.net/uniqid
23		*/
24	View Code Duplication	function ClientIpFromHex($hex) {
		0 ignored issues – show Duplication introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		$ip = "";
26		if (8 == strlen($hex)) {
27		$ip .= hexdec(substr($hex ,0 ,2)) . '.';
28		$ip .= hexdec(substr($hex ,2 ,2)) . '.';
29		$ip .= hexdec(substr($hex ,4 ,2)) . '.';
30		$ip .= hexdec(substr($hex ,6 ,2));
31		}
32		return $ip;
33		} // end of func ClientIpFromHex
34
35
36		/**
37		* Convert user ip to hex string
38		*
39		* @deprecated Use Fwlib\Util\Ip::toHex()
40		* @param string $ip
41		* @return string
42		* @link http://us.php.net/uniqid
43		*/
44		function ClientIpToHex($ip = "") {
45		$hex = "";
46		if('' == $ip)
47		//$ip = getenv('REMOTE_ADDR');
48		$ip = GetClientIp();
		0 ignored issues – show Deprecated Code introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `GetClientIp()` has been deprecated with message: Use Fwlib\Util\HttpUtil::getClientIp() This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
49	View Code Duplication	if (false == ip2long($ip))
		0 ignored issues – show Bug Best Practice introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `ip2long($ip)` of type `integer` to the boolean `false`. If you are specifically checking for 0, consider using something more explicit like `=== 0` instead. Loading history... Duplication introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		return '';
51		else {
52		$part = explode('.', $ip);
53		if (4 != count($part))
54		return '';
55		else
56		for ($i=0; $i<=count($part)-1; $i++) {
57		$hex .= substr('0' . dechex($part[$i]), -2);
58		}
59		}
60		return $hex;
61		} // end of func ClientIpToHex
62
63
64		/**
65		* 检查客户端的浏览器是NS还是IE
66		*
67		* @deprecated Use Fwlib\Util\HttpUtil::getBrowserType()
68		* @return string
69		*/
70		function GetBrowserType()
71		{
72		$str = isset($_SERVER['HTTP_USER_AGENT']) ? $_SERVER['HTTP_USER_AGENT'] : '';
73		if (false === strpos($str, 'MSIE')) {
74		return('NS');
75		}
76		else {
77		return('IE');
78		}
79		} // end func GetBrowserType
80
81
82		/**
83		* Get ip of client
84		*
85		* @deprecated Use Fwlib\Util\HttpUtil::getClientIp()
86		* @return string
87		* @link http://roshanbh.com.np/2007/12/getting-real-ip-address-in-php.html
88		*/
89		function GetClientIp() {
90		$s = '';
		0 ignored issues – show Unused Code introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$s` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
91
92		// Original way: check ip from share internet
93		if (!empty($_SERVER['HTTP_CLIENT_IP'])) {
94		$s = $_SERVER['HTTP_CLIENT_IP'];
95		}
96		// Using proxy ?
97		elseif (!empty($_SERVER['HTTP_X_FORWARDED_FOR'])) {
98		$s = $_SERVER['HTTP_X_FORWARDED_FOR'];
99		}
100		// Another way
101		elseif (!empty($_SERVER['REMOTE_ADDR'])) {
102		$s = $_SERVER['REMOTE_ADDR'];
103		}
104		else {
105		$s = '';
106		}
107		return $s;
108		} // end of func GetClientIp
109
110
111		?>
		0 ignored issues – show Best Practice introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
112

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

func/client.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like