Issues in mvc-module.test.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/mvc-module.test.php (19 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Test - MVC Module class
 *
 * @package		fwolflib
 * @subpackage	class.test
 * @copyright	Copyright 2012, Fwolf
 * @author      Fwolf <[email protected]>
 * @since		2012-12-10
 */


// Define like this, so test can run both under eclipse and web alone.
// {{{
if (! defined('SIMPLE_TEST')) {
	define('SIMPLE_TEST', 'simpletest/');
	require_once(SIMPLE_TEST . 'autorun.php');
}
// Then set output encoding
//header('Content-Type: text/html; charset=utf-8');
// }}}

// Require library define file which need test
require_once(dirname(__FILE__) . '/fwolflib.php');
require_once(dirname(__FILE__) . '/adodb.php');
require_once(dirname(__FILE__) . '/mvc-module.php');
require_once(dirname(__FILE__) . '/../func/ecl.php');
require_once(dirname(__FILE__) . '/../func/request.php');
require_once(dirname(__FILE__) . '/../func/uuid.php');


class TestModule extends UnitTestCase {

	/**
	 * Module object
	 * @var	object
	 */
	protected $oModule = NULL;


	/**
	 * Constructor
	 */
	public function __construct () {
		$this->oModule = new ModuleTest();

		// Define dbprofile
		$this->oModule->SetCfg('dbprofile', array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			'type'	=> 'mysqli',
			'host'	=> 'localhost',
			'user'	=> 'test',
			'pass'	=> '',
			'name'	=> 'test',
			'lang'	=> 'utf-8',
		));
		$this->oModule->oDb;
	} // end of func __construct


	function TestDbDiff () {

		// Create test table
		$this->oModule->oDb->Execute('
			CREATE TABLE t1 (
				uuid	CHAR(36) NOT NULL,
				i		INTEGER NOT NULL DEFAULT 0,
				ii		INTEGER NULL DEFAULT 0,
				s		VARCHAR(20) NULL,
				d		DATETIME NULL,
				PRIMARY KEY (uuid, i)
			);
		');
		$this->oModule->oDb->Execute('
			CREATE TABLE t2 (
				uuid	CHAR(36) NOT NULL,
				i		INTEGER NULL DEFAULT 0,
				ii		INTEGER NULL DEFAULT 0,
				s		VARCHAR(20) NULL,
				d		DATETIME NULL,
				PRIMARY KEY (uuid)
			);
		');


		// Test Adodb::GetDataByPk()
		$uuid = Uuid();

		$this->oModule->oDb->Execute('
			INSERT INTO t1
			VALUES ("' . $uuid . '", 12, 11, "blah"
				, "' . date('Y-m-d H:i:s') . '")
		');
		$this->assertEqual(12, $this->oModule->oDb->GetDataByPk(
			't1', $uuid, 'i', 'uuid'));
		$this->assertEqual(array('i' => 12, 's' => 'blah')
			, $this->oModule->oDb->GetDataByPk(
			't1', array($uuid, 12), ' i , s ,'));


		// Write data using DbDiff()
		$uuid = Uuid();

		$uuid2 = Uuid();


		// Error: New array has few PK
		$ar_new = array(
			'uuid'	=> $uuid,
//			'i'		=> mt_rand(0, 100),
			's'		=> RandomString(10),

			'd'		=> date('Y-m-d H:i:s'),
		);
		$ar_diff = $this->oModule->DbDiff(array('t1' => $ar_new));
		$this->assertEqual(-2, $ar_diff['code']);

		// New array has only PK
		$ar_new = array(
			'uuid'	=> $uuid,
			'i'		=> mt_rand(0, 100),
		);
		$ar_diff = $this->oModule->DbDiff(array('t1' => $ar_new));
		$this->assertEqual($ar_diff['diff']['t1'][0]['mode'], 'INSERT');
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['pk']), 2);
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['col']), 0);
		$ar_new = array(
			'uuid'	=> $uuid,
		);
		$ar_diff = $this->oModule->DbDiff(array('t2' => $ar_new));
		$this->assertEqual($ar_diff['diff']['t2'][0]['mode'], 'INSERT');
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['pk']), 1);
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['col']), 0);

		// Insert data
		$ar_new = array(
			'uuid'	=> $uuid,
			'i'		=> mt_rand(0, 100),
			's'		=> RandomString(10),

			'd'		=> date('Y-m-d H:i:s'),
		);
		$ar_diff = $this->oModule->DbDiffExec(array('t1' => $ar_new));
		$this->assertEqual($ar_diff['diff']['t1'][0]['mode'], 'INSERT');
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['pk']), 2);
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['col']), 2);
		$this->assertEqual($ar_diff['code'], 1);
		$this->assertEqual($ar_diff['flag'], 100);
		$ar_diff = $this->oModule->DbDiffExec(array('t2' => $ar_new));
		$this->assertEqual($ar_diff['diff']['t2'][0]['mode'], 'INSERT');
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['pk']), 1);
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['col']), 3);
		$this->assertEqual($ar_diff['code'], 1);
		$this->assertEqual($ar_diff['flag'], 100);

		// Insert mixed with update, multi table
		$ar_new2 = array($ar_new, array(
			'uuid'	=> $uuid2,
			'i'		=> mt_rand(0, 100),
			's'		=> RandomString(10),

			'd'		=> date('Y-m-d H:i:s'),
		));
		$ar_new3 = $ar_new2;
		$ar_new2[0]['s'] = RandomString(10);	// Make a update in t1

		$ar_diff = $this->oModule->DbDiffExec(array(
			't1' => $ar_new2,
			't2' => $ar_new3,
		));
		$this->assertEqual($ar_diff['diff']['t1'][0]['mode'], 'UPDATE');
		$this->assertEqual($ar_diff['diff']['t1'][1]['mode'], 'INSERT');
		$this->assertEqual($ar_diff['diff']['t2'][0]['mode'], 'INSERT');
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['pk']), 2);
		$this->assertEqual(count($ar_diff['diff']['t1'][0]['col']), 1);
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['pk']), 1);
		$this->assertEqual(count($ar_diff['diff']['t2'][0]['col']), 3);
		$this->assertEqual($ar_diff['code'], 3);
		$this->assertEqual($ar_diff['flag'], 100);

		// Db query fail
//		$ar_new2[1]['ii'] = 'blah';
//		$ar_diff = $this->oModule->DbDiffExec(array(
//			't1' => $ar_new2,
//			't2' => $ar_new2,
//		));
//		$this->assertEqual($ar_diff['diff']['t1'][0]['mode'], 'UPDATE');
//		$this->assertEqual($ar_diff['diff']['t2'][1]['mode'], 'UPDATE');
//		// Unknow column in fields list
//		$this->assertEqual($ar_diff['code'], -1054);
//		$this->assertEqual($ar_diff['flag'], 0);

		// Delete op
		// PK value NULL means delete
		$ar_new4 = array($ar_new, array(
			'uuid'	=> NULL,
			'i'		=> NULL,
		));
		$ar_diff = $this->oModule->DbDiffExec(array(
				't1' => $ar_new4,
				't2' => $ar_new4,
			), NULL, array(
				't1' => $ar_new3,	// Notice: Not same with exists value
				't2' => $ar_new3,
		));
		$this->assertEqual($ar_diff['diff']['t1'][0]['mode'], 'DELETE');
		$this->assertEqual($ar_diff['diff']['t2'][0]['mode'], 'DELETE');
		$this->assertEqual($ar_diff['code'], 2);
		$this->assertEqual($ar_diff['flag'], 100);


		// Rollback
		$uuid = Uuid();

		$ar_new = array(
			'uuid'	=> $uuid,
			'i'		=> mt_rand(100, 200),
			's'		=> 'aaa',
			'd'		=> date('Y-m-d H:i:s'),
		);
		$ar_new2 = array(
			'uuid'	=> $uuid2,
			'i'		=> mt_rand(100, 200),
			's'		=> 'aaa',
			'd'		=> date('Y-m-d H:i:s'),
		);
		// 1. insert
		$ar_new3 = array($ar_new, $ar_new2);
		$ar_diff_ins = $this->oModule->DbDiffExec(array(
				't1' => $ar_new3,
				't2' => $ar_new3,
		));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new['uuid'], $ar_new['i']), 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new2['uuid'], $ar_new2['i']), 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new['uuid'], 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new2['uuid'], 's'));
		// 2. update 1, delete 1
		$ar_new4 = $ar_new3;
		$ar_new4[0]['s'] = 'bbb';
		$ar_new4[0]['s'] = 'bbb';
		$ar_new4[1]['uuid'] = NULL;
		$ar_new4[1]['i'] = NULL;
		$ar_diff = $this->oModule->DbDiffExec(array(
				't1' => $ar_new4,
				't2' => $ar_new4,
			), NULL, array(
				't1' => $ar_new3,
				't2' => $ar_new3,
		));
		$this->assertEqual('bbb', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new['uuid'], $ar_new['i']), 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new2['uuid'], $ar_new2['i']), 's'));
		$this->assertEqual('bbb', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new['uuid'], 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new2['uuid'], 's'));
		// 3. rollback update and delete
		$i = $this->oModule->DbDiffRollback($ar_diff);
		$this->assertEqual($i, 4);
		$this->assertEqual($ar_diff['flag'], -100);
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new['uuid'], $ar_new['i']), 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new2['uuid'], $ar_new2['i']), 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new['uuid'], 's'));
		$this->assertEqual('aaa', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new2['uuid'], 's'));
		// 4. after rollback, re-commit
		$i = $this->oModule->DbDiffCommit($ar_diff);
		$this->assertEqual($i, 4);
		$this->assertEqual($ar_diff['flag'], 100);
		$this->assertEqual('bbb', $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new['uuid'], $ar_new['i']), 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new2['uuid'], $ar_new2['i']), 's'));
		$this->assertEqual('bbb', $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new['uuid'], 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new2['uuid'], 's'));
		// 5. rollback insert done at beginning
		$i = $this->oModule->DbDiffRollback($ar_diff_ins);
		$this->assertEqual($i, 2);	// 2 rows is alread deleted previous
		$this->assertEqual($ar_diff_ins['flag'], -100);
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new['uuid'], $ar_new['i']), 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t1'
			, array($ar_new2['uuid'], $ar_new2['i']), 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new['uuid'], 's'));
		$this->assertEqual(NULL, $this->oModule->oDb->GetDataByPk('t2'
			, $ar_new2['uuid'], 's'));

		// :DEBUG:
		//$this->oModule->oDb->debug = true;
		///Ecl('<pre>' . var_export($ar_diff, true) . '</pre>');


		// Clean up
		$this->oModule->oDb->Execute('
			DROP TABLE t1;
		');
		$this->oModule->oDb->Execute('
			DROP TABLE t2;
		');
    } // end of func TestDbDiff


} // end of class TestModule


class ModuleTest extends Module {



	/**
	 * Constructor
	 */
	public function __construct () {
		parent::__construct();

	} // end of func __construct


	/**
	 * Connect to db, using func defined in include file, check error here.
	 *
	 * <code>
	 * $s = array(type, host, user, pass, name, lang);
	 * type is mysql/sybase_ase etc,
	 * name is dbname to select,
	 * lang is db server charset.
	 * </code>
	 *
	 * Useing my extended ADODB class now, little difference when new object.
	 * @var array	$dbprofile	Server config array
	 * @return object			Db connection object
	 */
	protected function DbConn ($dbprofile) {
		$conn = new Adodb($dbprofile);

		$conn->Connect();

		if (0 !=$conn->ErrorNo()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			// Display error
			$s = 'ErrorNo: ' . $conn->ErrorNo() . "<br />\nErrorMsg: " . $conn->ErrorMsg();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
			return NULL;
		}
		else
			return $conn;
	} // end of func DbConn


	public function Init () {
		parent::Init();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

		return $this;
	} // end of func Init


} // end of class ModuleTest


// Change output charset in this way.
// {{{
$s_url = GetSelfUrl(false);

$s_url = substr($s_url, strrpos($s_url, '/') + 1);
if ('mvc-module.test.php' == $s_url) {
	$test = new TestModule();
	$test->run(new HtmlReporter('utf-8'));
}
// }}}
?>



fwolf / fwlib

Issues (1752)

Security Analysis not enabled

class/mvc-module.test.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like