Issues in cache.test.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/cache.test.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Test - Cache class
 * @package     fwolflib
 * @subpackage	class-test
 * @copyright   Copyright 2010, Fwolf
 * @author      Fwolf <[email protected]>
 * @since		2010-01-07
 */

// Define like this, so test can run both under eclipse and web alone.
// {{{
if (! defined('SIMPLE_TEST')) {
	define('SIMPLE_TEST', 'simpletest/');
	require_once(SIMPLE_TEST . 'autorun.php');
}
// Then set output encoding
//header('Content-Type: text/html; charset=utf-8');
// }}}

// Require library define file which need test
require_once(dirname(__FILE__) . '/fwolflib.php');
require_once(FWOLFLIB . 'class/cache.php');
require_once(FWOLFLIB . 'func/ecl.php');
require_once(FWOLFLIB . 'func/request.php');
require_once(FWOLFLIB . 'func/string.php');

class TestCache extends UnitTestCase {

	/**
	 * Cache object
	 * @var	object
	 */
	protected $oCh = null;


	/**
	 * Constructor
	 */
	public function __construct () {
		$ar_cfg = array(
			'cache-file-dir'	=> '/tmp/cache/',
			'cache-file-rule'	=> '1142',
		);
		$this->oCh = new CacheTest($ar_cfg);
	} // end of func __construct


    function TestCacheFilePath () {
		$this->oCh->SetCfg(array(
			'cache-type'		=> 'file',
			'cache-file-dir'	=> '/tmp/cache/',
			'cache-file-rule'	=> '1140',
		));
		$key = 'site/index';

		//Ecl(md5($key));

		$x = '/tmp/cache/d0/ex/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		$this->oCh->SetCfg(array('cache-file-rule' => '1131'));
		$x = '/tmp/cache/d0/te/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		// Notice: Directly use key's part as path may cause wrong
		$this->oCh->SetCfg(array('cache-file-rule' => '2342'));
		$x = '/tmp/cache/57//i/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		// Common usage
		$this->oCh->SetCfg(array('cache-file-rule' => '1011'));
		$x = '/tmp/cache/3e/d0/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		// Common usage 2
		$this->oCh->SetCfg(array('cache-file-rule' => '2021'));
		$x = '/tmp/cache/b6/9c/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		// Common usage 3
		$this->oCh->SetCfg(array('cache-file-rule' => '55'));
		$x = '/tmp/cache/89/3ed0dc6e';
		$y = $this->oCh->CacheFilePath($key);
		$this->assertEqual($x, $y);

		//Ecl($y);

		// Read/write
		$v = $this->oCh->CacheGet($key, 1);
		var_dump($v);
		Ecl(hash('crc32', $key)
			. '|'
			. $this->oCh->CacheFilePath($key));
    } // end of func TestCacheFilePath


} // end of class TestCache


class CacheTest extends Cache {
	protected function CacheGenVal ($key) {
		$this->sDummy = RandomString(30, 'a0');
class MyClass { }

$x = new MyClass();
$x->foo = true;
		return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	} // end of func CacheGenVal

	public function CacheLifetime ($key) {
		return 0;
	} // end of func CacheLifetime
} // end of class CacheTest


// Change output charset in this way.
// {{{
$s_url = GetSelfUrl(false);
$s_url = substr($s_url, strrpos($s_url, '/') + 1);
if ('cache.test.php' == $s_url) {
	$test = new TestCache();
	$test->run(new HtmlReporter('utf-8'));
}
// }}}
?>


1			<?php
2			/**
3			* Test - Cache class
4			* @package fwolflib
5			* @subpackage class-test
6			* @copyright Copyright 2010, Fwolf
7			* @author Fwolf <[email protected]>
8			* @since 2010-01-07
9			*/
10
11			// Define like this, so test can run both under eclipse and web alone.
12			// {{{
13			if (! defined('SIMPLE_TEST')) {
14			define('SIMPLE_TEST', 'simpletest/');
15			require_once(SIMPLE_TEST . 'autorun.php');
16			}
17			// Then set output encoding
18			//header('Content-Type: text/html; charset=utf-8');
19			// }}}
20
21			// Require library define file which need test
22			require_once(dirname(__FILE__) . '/fwolflib.php');
23			require_once(FWOLFLIB . 'class/cache.php');
24			require_once(FWOLFLIB . 'func/ecl.php');
25			require_once(FWOLFLIB . 'func/request.php');
26			require_once(FWOLFLIB . 'func/string.php');
27
28			class TestCache extends UnitTestCase {
29
30			/**
31			* Cache object
32			* @var object
33			*/
34			protected $oCh = null;
35
36
37			/**
38			* Constructor
39			*/
40			public function __construct () {
41			$ar_cfg = array(
42			'cache-file-dir' => '/tmp/cache/',
43			'cache-file-rule' => '1142',
44			);
45			$this->oCh = new CacheTest($ar_cfg);
46			} // end of func __construct
47
48
49			function TestCacheFilePath () {
50			$this->oCh->SetCfg(array(
51			'cache-type' => 'file',
52			'cache-file-dir' => '/tmp/cache/',
53			'cache-file-rule' => '1140',
54			));
55			$key = 'site/index';
56
57			//Ecl(md5($key));
58
59			$x = '/tmp/cache/d0/ex/3ed0dc6e';
60			$y = $this->oCh->CacheFilePath($key);
61			$this->assertEqual($x, $y);
62
63			$this->oCh->SetCfg(array('cache-file-rule' => '1131'));
64			$x = '/tmp/cache/d0/te/3ed0dc6e';
65			$y = $this->oCh->CacheFilePath($key);
66			$this->assertEqual($x, $y);
67
68			// Notice: Directly use key's part as path may cause wrong
69			$this->oCh->SetCfg(array('cache-file-rule' => '2342'));
70			$x = '/tmp/cache/57//i/3ed0dc6e';
71			$y = $this->oCh->CacheFilePath($key);
72			$this->assertEqual($x, $y);
73
74			// Common usage
75			$this->oCh->SetCfg(array('cache-file-rule' => '1011'));
76			$x = '/tmp/cache/3e/d0/3ed0dc6e';
77			$y = $this->oCh->CacheFilePath($key);
78			$this->assertEqual($x, $y);
79
80			// Common usage 2
81			$this->oCh->SetCfg(array('cache-file-rule' => '2021'));
82			$x = '/tmp/cache/b6/9c/3ed0dc6e';
83			$y = $this->oCh->CacheFilePath($key);
84			$this->assertEqual($x, $y);
85
86			// Common usage 3
87			$this->oCh->SetCfg(array('cache-file-rule' => '55'));
88			$x = '/tmp/cache/89/3ed0dc6e';
89			$y = $this->oCh->CacheFilePath($key);
90			$this->assertEqual($x, $y);
91
92			//Ecl($y);
93
94			// Read/write
95			$v = $this->oCh->CacheGet($key, 1);
96			var_dump($v);
97			Ecl(hash('crc32', $key)
98			. '\|'
99			. $this->oCh->CacheFilePath($key));
100			} // end of func TestCacheFilePath
101
102
103			} // end of class TestCache
104
105
106			class CacheTest extends Cache {
107			protected function CacheGenVal ($key) {
108			$this->sDummy = RandomString(30, 'a0');
			0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `sDummy` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
109			return $this;
			0 ignored issues – show Bug Best Practice introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this;` (`CacheTest`) is incompatible with the return type declared by the abstract method `Cache::CacheGenVal` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
110			} // end of func CacheGenVal
111
112			public function CacheLifetime ($key) {
113			return 0;
114			} // end of func CacheLifetime
115			} // end of class CacheTest
116
117
118			// Change output charset in this way.
119			// {{{
120			$s_url = GetSelfUrl(false);
121			$s_url = substr($s_url, strrpos($s_url, '/') + 1);
122			if ('cache.test.php' == $s_url) {
123			$test = new TestCache();
124			$test->run(new HtmlReporter('utf-8'));
125			}
126			// }}}
127			?>
128

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

class/cache.test.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like