Issues in util-container.php (master) - Issues in master - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1752)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

benchmark/util-container.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * UtilContainer is common used like this:
 *
 * $arrayUtil = UtilContainer::getInstance()->getArray();
 * $arrayUtil->getIdx();
 *
 * Will this be slower than Class::method() ? How slow ?
 *
 *
 * Result:
 *
 * 1. Get UtilContainer instance then use it to get util instance is about 2
 * times slower.
 *
 * 2. If initial a variable to stores util instance, method call through '->'
 * is about 1% faster than through '::'.
 *
 * So, operate around UtilContainer is slow, should store its instance local
 * for reuse. Consider dependence injection, UtilContainer can inject to its
 * client, and use it to get util instance for usage, this have some speed
 * cost, but helpful for test or extend. For speedup util usage in loop, store
 * instance in local variable.
 *
 * Util class are helper class, their client class have dependence on it, but
 * this is different with other object dependence, util class can be replaced
 * by other ways, like function with namespace, like replace with copied
 * private method, so I'm not treat util class as normal dependence inject (in
 * constructor), just declare a protected property $utilContainer and public
 * setter setUtilContainer(), then invoke setter in constructor is enough.
 *
 * @see \Fwlib\Util\UtilContainerAwareTrait
 */

use Fwlib\Dummy\ArrayUtil;
use Fwlib\Test\Benchmark\Benchmark;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Fwlib\Util\UtilContainer;

require __DIR__ . '/../autoload.php';

require __DIR__ . '/dummy/ArrayUtil.php';


// Instance ArrayUtil, will reuse in below get
UtilContainer::getInstance()->getArray();


$bench = new Benchmark;
$loopCount = 10000;


$bench->start("Test loop $loopCount times");


// Use static call
for ($i = 0; $i < $loopCount; $i ++) {
    ArrayUtil::getIdx([], 'foo', 'bar');
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
}
$bench->mark('ArrayUtil::getIdx()');


// Use UtilContainer instance
$utilContainer = UtilContainer::getInstance();
for ($i = 0; $i < $loopCount; $i ++) {
    $utilContainer->getArray()->getIdx([], 'foo', 'bar');
}
$bench->mark('$utilContainer->getArray()->getIdx()');


// Use util instance
$arrayUtil = $utilContainer->getArray();
for ($i = 0; $i < $loopCount; $i ++) {
    $arrayUtil->getIdx([], 'foo', 'bar');
}
$bench->mark('$arrayUtil->getIdx()');


$bench->display();


1			<?php
2			/**
3			* UtilContainer is common used like this:
4			*
5			* $arrayUtil = UtilContainer::getInstance()->getArray();
6			* $arrayUtil->getIdx();
7			*
8			* Will this be slower than Class::method() ? How slow ?
9			*
10			*
11			* Result:
12			*
13			* 1. Get UtilContainer instance then use it to get util instance is about 2
14			* times slower.
15			*
16			* 2. If initial a variable to stores util instance, method call through '->'
17			* is about 1% faster than through '::'.
18			*
19			* So, operate around UtilContainer is slow, should store its instance local
20			* for reuse. Consider dependence injection, UtilContainer can inject to its
21			* client, and use it to get util instance for usage, this have some speed
22			* cost, but helpful for test or extend. For speedup util usage in loop, store
23			* instance in local variable.
24			*
25			* Util class are helper class, their client class have dependence on it, but
26			* this is different with other object dependence, util class can be replaced
27			* by other ways, like function with namespace, like replace with copied
28			* private method, so I'm not treat util class as normal dependence inject (in
29			* constructor), just declare a protected property $utilContainer and public
30			* setter setUtilContainer(), then invoke setter in constructor is enough.
31			*
32			* @see \Fwlib\Util\UtilContainerAwareTrait
33			*/
34
35			use Fwlib\Dummy\ArrayUtil;
36			use Fwlib\Test\Benchmark\Benchmark;
			0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Benchmark`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
37			use Fwlib\Util\UtilContainer;
38
39			require __DIR__ . '/../autoload.php';
40
41			require __DIR__ . '/dummy/ArrayUtil.php';
42
43
44			// Instance ArrayUtil, will reuse in below get
45			UtilContainer::getInstance()->getArray();
46
47
48			$bench = new Benchmark;
49			$loopCount = 10000;
50
51
52			$bench->start("Test loop $loopCount times");
53
54
55			// Use static call
56			for ($i = 0; $i < $loopCount; $i ++) {
57			ArrayUtil::getIdx([], 'foo', 'bar');
			0 ignored issues – show Unused Code introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to the method `Fwlib\Dummy\ArrayUtil::getIdx()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
58			}
59			$bench->mark('ArrayUtil::getIdx()');
60
61
62			// Use UtilContainer instance
63			$utilContainer = UtilContainer::getInstance();
64			for ($i = 0; $i < $loopCount; $i ++) {
65			$utilContainer->getArray()->getIdx([], 'foo', 'bar');
66			}
67			$bench->mark('$utilContainer->getArray()->getIdx()');
68
69
70			// Use util instance
71			$arrayUtil = $utilContainer->getArray();
72			for ($i = 0; $i < $loopCount; $i ++) {
73			$arrayUtil->getIdx([], 'foo', 'bar');
74			}
75			$bench->mark('$arrayUtil->getIdx()');
76
77
78			$bench->display();
79

fwolf / fwlib

Issues (1752)

Security Analysis not enabled

benchmark/util-container.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like