KeyValueDictionaryTest::testFixDictionaryIndex() - Code Metrics - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

KeyValueDictionaryTest::testFixDictionaryIndex() A
last analyzed 2019-05-09 15:53 UTC

↳ Parent: KeyValueDictionaryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	22
rs	9.568
c	0
b	0
f	0

<?php
namespace FwlibTest\Db;

use Fwlib\Db\KeyValueDictionary;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class KeyValueDictionaryTest extends PHPUnitTestCase
{
    /**
     * @param   string[] $methods
     * @return  MockObject|KeyValueDictionary
     */
    protected function buildMock(array $methods = null)
    {
        $mock = $this->getMockBuilder(KeyValueDictionary::class)
            ->setMethods($methods)
            ->disableOriginalConstructor()
            ->getMock();

        return $mock;
    }


    public function testFixDictionaryIndex()
    {
        $dict = $this->buildMock();

        $this->reflectionSet($dict, 'dictionary', [
            'foo' => 21,
            'bar' => 42,
        ]);
        $this->reflectionCall($dict, 'fixDictionaryIndex');

        $dictAr = $this->reflectionGet($dict, 'dictionary');
        $this->assertEqualArray($dictAr, [
            'foo' => [
                'code'  => 'foo',
                'title' => 21,
            ],
            'bar' => [
                'code'  => 'bar',
                'title' => 42,
            ],
        ]);
    }


    public function testGetSingleColumn()
    {
        $dict = $this->buildMock();
        $dict->set([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ['foo', 21],
            ['bar', 42],
        ]);

        $this->assertEqualArray($dict->getSingleColumn(), [
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'foo' => 21,
            'bar' => 42,
        ]);
    }
}


KeyValueDictionaryTest::testFixDictionaryIndex() A
last analyzed 2019-05-09 15:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			namespace FwlibTest\Db;
3
4			use Fwlib\Db\KeyValueDictionary;
5			use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
6			use PHPUnit_Framework_MockObject_MockObject as MockObject;
7
8			/**
9			* @copyright Copyright 2015 Fwolf
10			* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
11			*/
12			class KeyValueDictionaryTest extends PHPUnitTestCase
13			{
14			/**
15			* @param string[] $methods
16			* @return MockObject\|KeyValueDictionary
17			*/
18			protected function buildMock(array $methods = null)
19			{
20			$mock = $this->getMockBuilder(KeyValueDictionary::class)
21			->setMethods($methods)
22			->disableOriginalConstructor()
23			->getMock();
24
25			return $mock;
26			}
27
28
29			public function testFixDictionaryIndex()
30			{
31			$dict = $this->buildMock();
32
33			$this->reflectionSet($dict, 'dictionary', [
34			'foo' => 21,
35			'bar' => 42,
36			]);
37			$this->reflectionCall($dict, 'fixDictionaryIndex');
38
39			$dictAr = $this->reflectionGet($dict, 'dictionary');
40			$this->assertEqualArray($dictAr, [
41			'foo' => [
42			'code' => 'foo',
43			'title' => 21,
44			],
45			'bar' => [
46			'code' => 'bar',
47			'title' => 42,
48			],
49			]);
50			}
51
52
53			public function testGetSingleColumn()
54			{
55			$dict = $this->buildMock();
56			$dict->set([
			0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `set` does only exist in `Fwlib\Db\KeyValueDictionary`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
57			['foo', 21],
58			['bar', 42],
59			]);
60
61			$this->assertEqualArray($dict->getSingleColumn(), [
			0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `getSingleColumn` does only exist in `Fwlib\Db\KeyValueDictionary`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62			'foo' => 21,
63			'bar' => 42,
64			]);
65			}
66			}
67

fwolf / fwlib

KeyValueDictionaryTest::testFixDictionaryIndex() A last analyzed 2019-05-09 15:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

KeyValueDictionaryTest::testFixDictionaryIndex() A
last analyzed 2019-05-09 15:53 UTC