WithVersionTraitTest::buildMock() - Code Metrics - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

WithVersionTraitTest::buildMock() A
last analyzed 2019-05-09 15:53 UTC

↳ Parent: WithVersionTraitTest

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	1
nop	0
dl	0
loc	25
rs	9.52
c	0
b	0
f	0

<?php
namespace FwlibTest\Cache\Handler\Helper;

use Fwlib\Cache\Handler\Helper\WithVersionTrait;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class WithVersionTraitTest extends PHPUnitTestCase
{
    /**
     * @var int[]
     */
    protected $versions = [];


    /**
     * @return MockObject | \Fwlib\Cache\Handler\Helper\WithVersionTrait
     */
    protected function buildMock()
    {
        $mock = $this->getMockBuilder(WithVersionTrait::class)
            ->setMethods(['get', 'set'])
            ->getMockForTrait();

        $mock->expects($this->any())
            ->method('get')
            ->willReturnCallback(function($key) {
                return array_key_exists($key, $this->versions)
                    ? $this->versions[$key]
                    : null;
            });

        $mock->expects($this->any())
            ->method('set')
            ->willReturnCallback(function($key, $value) {
                $this->versions[$key] = $value;
            });

        /** @noinspection PhpUndefinedFieldInspection */
        $mock->versionSuffix = '-ver';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $mock;
    }


    public function test()
    {
        $handler = $this->buildMock();

        $key = 'foo';
        $this->assertEquals(1, $handler->getVersion($key));
        $this->assertEquals(2, $handler->increaseVersion($key));
        $this->assertEquals(2, $handler->getVersion($key));

        $this->versions['foo-ver'] = 65534;
        $this->assertEquals(65535, $handler->increaseVersion($key));
        $this->assertEquals(1, $handler->increaseVersion($key));
    }
}


1			<?php
2			namespace FwlibTest\Cache\Handler\Helper;
3
4			use Fwlib\Cache\Handler\Helper\WithVersionTrait;
5			use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
6			use PHPUnit_Framework_MockObject_MockObject as MockObject;
7
8			/**
9			* @copyright Copyright 2015 Fwolf
10			* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
11			*/
12			class WithVersionTraitTest extends PHPUnitTestCase
13			{
14			/**
15			* @var int[]
16			*/
17			protected $versions = [];
18
19
20			/**
21			* @return MockObject \| \Fwlib\Cache\Handler\Helper\WithVersionTrait
22			*/
23			protected function buildMock()
24			{
25			$mock = $this->getMockBuilder(WithVersionTrait::class)
26			->setMethods(['get', 'set'])
27			->getMockForTrait();
28
29			$mock->expects($this->any())
30			->method('get')
31			->willReturnCallback(function($key) {
32			return array_key_exists($key, $this->versions)
33			? $this->versions[$key]
34			: null;
35			});
36
37			$mock->expects($this->any())
38			->method('set')
39			->willReturnCallback(function($key, $value) {
40			$this->versions[$key] = $value;
41			});
42
43			/** @noinspection PhpUndefinedFieldInspection */
44			$mock->versionSuffix = '-ver';
			0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report Accessing `versionSuffix` on the interface `PHPUnit_Framework_MockObject_MockObject` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45
46			return $mock;
47			}
48
49
50			public function test()
51			{
52			$handler = $this->buildMock();
53
54			$key = 'foo';
55			$this->assertEquals(1, $handler->getVersion($key));
56			$this->assertEquals(2, $handler->increaseVersion($key));
57			$this->assertEquals(2, $handler->getVersion($key));
58
59			$this->versions['foo-ver'] = 65534;
60			$this->assertEquals(65535, $handler->increaseVersion($key));
61			$this->assertEquals(1, $handler->increaseVersion($key));
62			}
63			}
64

fwolf / fwlib

WithVersionTraitTest::buildMock() A last analyzed 2019-05-09 15:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

WithVersionTraitTest::buildMock() A
last analyzed 2019-05-09 15:53 UTC