SessionHandlerAwareTraitTest::testSetGet() - Code Metrics - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

SessionHandlerAwareTraitTest::testSetGet() A
last analyzed 2019-05-09 15:53 UTC

↳ Parent: SessionHandlerAwareTraitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	11
rs	9.9
c	0
b	0
f	0

<?php
namespace FwlibTest\Auth;

use Fwlib\Auth\SessionHandlerAwareTrait;
use Fwlib\Auth\SessionHandlerInterface;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class SessionHandlerAwareTraitTest extends PHPUnitTestCase
{
    /**
     * @return MockObject|SessionHandlerAwareTrait
     */
    protected function buildMock()
    {
        $mock = $this->getMockBuilder(SessionHandlerAwareTrait::class)
            ->setMethods(null)
            ->getMockForTrait();

        return $mock;
    }


    /**
     * @return MockObject|SessionHandlerInterface
     */
    protected function buildSessionHandlerMock()
    {
        $mock = $this->getMock(
            SessionHandlerInterface::class,
            []
        );

        return $mock;
    }


    public function testSetGet()
    {
        $handlerAware = $this->buildMock();
        $handler = $this->buildSessionHandlerMock();

        $handlerAware->setSessionHandler($handler);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->assertInstanceOf(
            SessionHandlerInterface::class,
            $handlerAware->getSessionHandler()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        );
    }
}


1			<?php
2			namespace FwlibTest\Auth;
3
4			use Fwlib\Auth\SessionHandlerAwareTrait;
5			use Fwlib\Auth\SessionHandlerInterface;
6			use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
7			use PHPUnit_Framework_MockObject_MockObject as MockObject;
8
9			/**
10			* @copyright Copyright 2015 Fwolf
11			* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
12			*/
13			class SessionHandlerAwareTraitTest extends PHPUnitTestCase
14			{
15			/**
16			* @return MockObject\|SessionHandlerAwareTrait
17			*/
18			protected function buildMock()
19			{
20			$mock = $this->getMockBuilder(SessionHandlerAwareTrait::class)
21			->setMethods(null)
22			->getMockForTrait();
23
24			return $mock;
25			}
26
27
28			/**
29			* @return MockObject\|SessionHandlerInterface
30			*/
31			protected function buildSessionHandlerMock()
32			{
33			$mock = $this->getMock(
34			SessionHandlerInterface::class,
35			[]
36			);
37
38			return $mock;
39			}
40
41
42			public function testSetGet()
43			{
44			$handlerAware = $this->buildMock();
45			$handler = $this->buildSessionHandlerMock();
46
47			$handlerAware->setSessionHandler($handler);
			0 ignored issues – show Bug introduced 2017-01-07 05:16 UTC by Report Bug Copy Issue Report It seems like `$handler` defined by `$this->buildSessionHandlerMock()` on line `45` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Fwlib\Auth\SessionHandle...it::setSessionHandler()` does only seem to accept `object<Fwlib\Auth\SessionHandlerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2017-01-07 05:16 UTC by Report Bug Copy Issue Report The method `setSessionHandler` does only exist in `Fwlib\Auth\SessionHandlerAwareTrait`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /* * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48			$this->assertInstanceOf(
49			SessionHandlerInterface::class,
50			$handlerAware->getSessionHandler()
			0 ignored issues – show Bug introduced 2017-01-07 05:16 UTC by Report Bug Copy Issue Report The method `getSessionHandler` does only exist in `Fwlib\Auth\SessionHandlerAwareTrait`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
51			);
52			}
53			}
54

fwolf / fwlib

SessionHandlerAwareTraitTest::testSetGet() A last analyzed 2019-05-09 15:53 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

SessionHandlerAwareTraitTest::testSetGet() A
last analyzed 2019-05-09 15:53 UTC