FwlibTest\Web\RequestTraitTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	85
Duplicated Lines	21.18 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	buildMock()	0	14	1
A	setUpBeforeClass()	18	18	1
A	tearDownAfterClass()	0	6	1
A	testAccessors()	0	24	1

<?php
namespace FwlibTest\Web;

use Fwlib\Util\Common\HttpUtil;
use Fwlib\Util\UtilContainer;
use Fwlib\Web\RequestTrait;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class RequestTraitTest extends PHPUnitTestCase
{
    /**
     * @var string
     */
    protected static $getGet = '';

    /**
     * @var HttpUtil
     */
    protected static $httpUtilBackup = null;


    /**
     * @return MockObject | RequestTrait
     */
    protected function buildMock()
    {
        $mock = $this->getMockBuilder(RequestTrait::class)
            ->disableOriginalConstructor()
            ->getMockForTrait();

        /** @noinspection PhpUndefinedFieldInspection */
        {
            $mock->actionParameter = 'a';

Accessing actionParameter on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

            $mock->moduleParameter = 'm';

Accessing moduleParameter on the interface PHPUnit_Framework_MockObject_MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        return $mock;
    }


    public static function setUpBeforeClass()

This method seems to be duplicated in your project.

    {
        $utilContainer = UtilContainer::getInstance();
        self::$httpUtilBackup = $utilContainer->getHttp();

        $testCase = new self;
        $httpUtil = $testCase->getMock(
            HttpUtil::class,
            ['getGet']
        );
        $httpUtil->expects($testCase->any())
            ->method('getGet')
            ->willReturnCallback(function () {
                return RequestTraitTest::$getGet;
            });

        $utilContainer->register('Http', $httpUtil);
    }


    public static function tearDownAfterClass()
    {
        $utilContainer = UtilContainer::getInstance();

        $utilContainer->register('Http', self::$httpUtilBackup);
    }


    public function testAccessors()
    {
        $request = $this->buildMock();

        self::$getGet = 'foo';
        $this->assertEquals('foo', $request->getAction());

        $request->setAction('foo1');
        $this->assertEquals('foo1', $request->getAction());

        self::$getGet = 'bar';
        $this->assertEquals('bar', $request->getModule());

        $request->setModule('bar1');
        $this->assertEquals('bar1', $request->getModule());


        // Action and module parameter
        $request->setActionParameter('aa');
        $this->assertEquals('aa', $request->getActionParameter());

        $request->setModuleParameter('mm');
        $this->assertEquals('mm', $request->getModuleParameter());
    }
}