SubmitButtonTest - Code Metrics - fwolf/fwlib - Measure and Improve Code Quality continuously with Scrutinizer

SubmitButtonTest A
last analyzed 2019-05-09 15:53 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	28.21 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	11
loc	39
rs	10
c	0
b	0
f	0
wmc	3
lcom	1
cbo	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	buildMock()	0	9	1
A	testGetOutputWithJs()	0	8	1
A	testGetOutputWithoutJs()	11	11	1

How to fix Duplicated Code

<?php
namespace FwlibTest\Html\Generator\Element;

use Fwlib\Html\Generator\Element\SubmitButton;
use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
use PHPUnit_Framework_MockObject_MockObject as MockObject;

/**
 * @copyright   Copyright 2015 Fwolf
 * @license     http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
 */
class SubmitButtonTest extends PHPUnitTestCase
{
    /**
     * @param   string[] $methods
     * @return  MockObject|SubmitButton
     */
    protected function buildMock(array $methods = null)
    {
        $mock = $this->getMock(
            SubmitButton::class,
            $methods
        );

        return $mock;
    }


    public function testGetOutputWithJs()
    {
        $element = $this->buildMock();

        $element->setId('foo')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->setConfig('sleepTime', 3000);
        $this->assertRegExp('/<script /', $element->getOutput());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }


    public function testGetOutputWithoutJs()

    {
        $element = $this->buildMock();

        $element->setId('');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertNotRegExp('/<script /', $element->getOutput());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $element->setId('foo')
            ->setConfig('sleepTime', 0);
        $this->assertNotRegExp('/<script /', $element->getOutput());
    }
}


SubmitButtonTest A
last analyzed 2019-05-09 15:53 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		namespace FwlibTest\Html\Generator\Element;
3
4		use Fwlib\Html\Generator\Element\SubmitButton;
5		use Fwolf\Wrapper\PHPUnit\PHPUnitTestCase;
6		use PHPUnit_Framework_MockObject_MockObject as MockObject;
7
8		/**
9		* @copyright Copyright 2015 Fwolf
10		* @license http://www.gnu.org/licenses/lgpl.html LGPL-3.0+
11		*/
12		class SubmitButtonTest extends PHPUnitTestCase
13		{
14		/**
15		* @param string[] $methods
16		* @return MockObject\|SubmitButton
17		*/
18		protected function buildMock(array $methods = null)
19		{
20		$mock = $this->getMock(
21		SubmitButton::class,
22		$methods
23		);
24
25		return $mock;
26		}
27
28
29		public function testGetOutputWithJs()
30		{
31		$element = $this->buildMock();
32
33		$element->setId('foo')
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `setId` does only exist in `Fwlib\Html\Generator\Element\SubmitButton`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34		->setConfig('sleepTime', 3000);
35		$this->assertRegExp('/<script /', $element->getOutput());
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `getOutput` does only exist in `Fwlib\Html\Generator\Element\SubmitButton`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
36		}
37
38
39	View Code Duplication	public function testGetOutputWithoutJs()
		0 ignored issues – show Duplication introduced 2018-01-24 08:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		$element = $this->buildMock();
42
43		$element->setId('');
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `setId` does only exist in `Fwlib\Html\Generator\Element\SubmitButton`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44		$this->assertNotRegExp('/<script /', $element->getOutput());
		0 ignored issues – show Bug introduced 2016-06-01 06:17 UTC by Report Bug Copy Issue Report The method `getOutput` does only exist in `Fwlib\Html\Generator\Element\SubmitButton`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45
46		$element->setId('foo')
47		->setConfig('sleepTime', 0);
48		$this->assertNotRegExp('/<script /', $element->getOutput());
49		}
50		}
51

fwolf / fwlib

SubmitButtonTest A last analyzed 2019-05-09 15:53 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

SubmitButtonTest A
last analyzed 2019-05-09 15:53 UTC