fwolf /
fwlib
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DispListTable often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DispListTable, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 63 | class DispListTable |
||
| 64 | { |
||
| 65 | /** |
||
| 66 | * 显示列表之前是否重置模板数据 |
||
| 67 | * @access public |
||
| 68 | * @var boolean |
||
| 69 | */ |
||
| 70 | var $mListClearAllAssign = true; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * 列表的标题 |
||
| 74 | * @access public |
||
| 75 | * @var string |
||
| 76 | */ |
||
| 77 | var $mListTitle = ''; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * 索引的提示信息数组 |
||
| 81 | * 第一组的内容将被作为提示信息 |
||
| 82 | * @access private |
||
| 83 | * @var array |
||
| 84 | */ |
||
| 85 | var $mIndexTips = array(array('第一页', '上一页', '下一页', '最后页'), |
||
| 86 | array('|<', '<<', '>>', '>|'), |
||
| 87 | array('<b>|</b><font face="Wingdings 3" style="font-family: \'Wingdings 3\';">¡</font>', '<font face="Wingdings 3" style="font-family: \'Wingdings 3\';">¡</font>', '<font face="Wingdings 3" style="font-family: \'Wingdings 3\';">¢</font>', '<font face="Wingdings 3" style="font-family: \'Wingdings 3\';">¢</font><b>|</b>'), // 197/198 |
||
| 88 | array('<font face="Webdings" style="font-family: \'Webdings\';">9</font>', '<font face="Webdings" style="font-family: \'Webdings\';">7</font>', '<font face="Webdings" style="font-family: \'Webdings\';">8</font>', '<font face="Webdings" style="font-family: \'Webdings\';">:</font>')); |
||
| 89 | |||
| 90 | /** |
||
| 91 | * 使用哪组索引提示信息，默认用第一组 |
||
| 92 | * @access public |
||
| 93 | * @var int |
||
| 94 | */ |
||
| 95 | var $mIndexTipsId = 0; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * 是否显示标题部分 |
||
| 99 | * @access public |
||
| 100 | * @var int |
||
| 101 | */ |
||
| 102 | var $mIsDispTitle = true; |
||
| 103 | /** |
||
| 104 | * 是否显示分页代码部分 |
||
| 105 | * @access public |
||
| 106 | * @var int |
||
| 107 | */ |
||
| 108 | var $mIsDispIndex = true; |
||
| 109 | /** |
||
| 110 | * 是否显示表头 |
||
| 111 | * @access public |
||
| 112 | * @var int |
||
| 113 | */ |
||
| 114 | var $mIsDispHead = true; |
||
| 115 | /** |
||
| 116 | * 当前页数 |
||
| 117 | * @access public |
||
| 118 | * @var int |
||
| 119 | */ |
||
| 120 | var $mCurPage = 1; |
||
| 121 | /** |
||
| 122 | * 每页显示多少条记录 |
||
| 123 | * @access public |
||
| 124 | * @var int |
||
| 125 | */ |
||
| 126 | var $mRowsPerPage = 20; |
||
| 127 | /** |
||
| 128 | * 一共有多少条记录 |
||
| 129 | * @access public |
||
| 130 | * @var int |
||
| 131 | */ |
||
| 132 | var $mTotalRows = 0; |
||
| 133 | /** |
||
| 134 | * 分页代码将要链接到的页面地址 |
||
| 135 | * |
||
| 136 | * 此参数如省略，默认为$_SERVER['REQUEST_URI']，带参数的当前页 |
||
| 137 | * @access public |
||
| 138 | * @var string |
||
| 139 | */ |
||
| 140 | var $mSubmitUrl = ''; |
||
| 141 | /** |
||
| 142 | * 最终生成的HTML字符串 |
||
| 143 | * @access private |
||
| 144 | * @var string |
||
| 145 | */ |
||
| 146 | var $mHtmlStr = ''; |
||
| 147 | /** |
||
| 148 | * 模板变量，指向在构造函数中传入的全局模板变量 |
||
| 149 | * @access private |
||
| 150 | * @var array |
||
| 151 | */ |
||
| 152 | var $mrTpl; |
||
| 153 | /** |
||
| 154 | * 数组变量，指向要显示数据存放的数组，其格式见类说明 |
||
| 155 | * @access private |
||
| 156 | * @var array |
||
| 157 | */ |
||
| 158 | var $mrAr; |
||
| 159 | |||
| 160 | // {{{ 列表显示样式等 |
||
| 161 | |||
| 162 | /** |
||
| 163 | * 表格的宽度 |
||
| 164 | * @access private |
||
| 165 | * @var string |
||
| 166 | */ |
||
| 167 | var $mTableWidth = '80%'; |
||
| 168 | |||
| 169 | /** |
||
| 170 | * 表格的背景颜色 |
||
| 171 | * @access private |
||
| 172 | * @var string |
||
| 173 | */ |
||
| 174 | var $mTableBgcolor = '#ffffff'; |
||
| 175 | |||
| 176 | /** |
||
| 177 | * 表格边框的宽度，一般为2px |
||
| 178 | * @access private |
||
| 179 | * @var string |
||
| 180 | */ |
||
| 181 | var $mTableBorderWidth = '2px'; |
||
| 182 | |||
| 183 | /** |
||
| 184 | * 表格边框的颜色 |
||
| 185 | * @access private |
||
| 186 | * @var string |
||
| 187 | */ |
||
| 188 | var $mTableBorderColor = '#006699'; |
||
| 189 | |||
| 190 | /** |
||
| 191 | * 表格边框的线型 |
||
| 192 | * @access private |
||
| 193 | * @var string |
||
| 194 | */ |
||
| 195 | var $mTableBorderLineStyle = 'solid'; |
||
| 196 | |||
| 197 | /** |
||
| 198 | * 表格表头部分颜色 |
||
| 199 | * @access private |
||
| 200 | * @var string |
||
| 201 | */ |
||
| 202 | var $mThColor = '#FFA34F'; |
||
| 203 | |||
| 204 | /** |
||
| 205 | * 表格表头部分字体大小 |
||
| 206 | * @access private |
||
| 207 | * @var string |
||
| 208 | */ |
||
| 209 | var $mThFontSize = '9pt'; |
||
| 210 | |||
| 211 | /** |
||
| 212 | * 表格表头部分字体粗细 |
||
| 213 | * @access private |
||
| 214 | * @var string |
||
| 215 | */ |
||
| 216 | var $mThFontWeight = 'bold'; |
||
| 217 | |||
| 218 | /** |
||
| 219 | * 表格表头部分背景颜色 |
||
| 220 | * @access private |
||
| 221 | * @var string |
||
| 222 | */ |
||
| 223 | var $mThBgcolor = '#006699'; |
||
| 224 | |||
| 225 | /** |
||
| 226 | * 表格表头部分高度 |
||
| 227 | * @access private |
||
| 228 | * @var string |
||
| 229 | */ |
||
| 230 | var $mThHeight = '25px'; |
||
| 231 | |||
| 232 | /** |
||
| 233 | * 表格行背景选用颜色1 |
||
| 234 | * @access private |
||
| 235 | * @var string |
||
| 236 | */ |
||
| 237 | var $mTrBgcolor1 = '#EFEFEF'; |
||
| 238 | |||
| 239 | /** |
||
| 240 | * 表格行背景选用颜色2 |
||
| 241 | * @access private |
||
| 242 | * @var string |
||
| 243 | */ |
||
| 244 | var $mTrBgcolor2 = '#DEE3E7'; |
||
| 245 | |||
| 246 | /** |
||
| 247 | * 表格行背景鼠标指向时的颜色 |
||
| 248 | * @access private |
||
| 249 | * @var string |
||
| 250 | */ |
||
| 251 | var $mTrPointedColor = '#CCFFCC'; |
||
| 252 | |||
| 253 | /** |
||
| 254 | * 表格行背景被标记时的颜色 |
||
| 255 | * @access private |
||
| 256 | * @var string |
||
| 257 | */ |
||
| 258 | var $mTrMarkedColor = '#FFCC99'; |
||
| 259 | |||
| 260 | /** |
||
| 261 | * 单元格线型 |
||
| 262 | * @access private |
||
| 263 | * @var string |
||
| 264 | */ |
||
| 265 | var $mTdLineStyle = 'solid'; |
||
| 266 | |||
| 267 | /** |
||
| 268 | * 单元格高度 |
||
| 269 | * @access private |
||
| 270 | * @var string |
||
| 271 | */ |
||
| 272 | var $mTdHeight = '20px'; |
||
| 273 | |||
| 274 | // }}} |
||
| 275 | |||
| 276 | /** |
||
| 277 | * 模板文件的路径 |
||
| 278 | * @access private |
||
| 279 | * @var string |
||
| 280 | */ |
||
| 281 | var $mTemplatePath = 'class/disp_list_table.html'; |
||
| 282 | |||
| 283 | |||
| 284 | /** |
||
| 285 | * 类构造函数 |
||
| 286 | * |
||
| 287 | * @param array &$tpl 传入的模板变量，要赋值给{@link $mrTpl}。 |
||
| 288 | * @param array &$ar 传入的数组变量，要赋值给{@link $mrAr}。 |
||
| 289 | */ |
||
| 290 | function DispListTable(&$tpl, &$ar) |
||
| 295 | |||
| 296 | |||
| 297 | /** |
||
| 298 | * 设置列表中的数据，当new一个实例后，要显示多个列表时，就要通过设置新的列表中的数据和改变相应的类变量来实现。而此时模板变量不变（其值会改变）。 |
||
| 299 | * @access public |
||
| 300 | * @param object &$ar 传入的数组变量，要赋值给{@link $mrAr}。 |
||
| 301 | */ |
||
| 302 | function SetData(&$ar) |
||
| 318 | |||
| 319 | /** |
||
| 320 | * 显示最终表格 |
||
| 321 | * |
||
| 322 | * @access public |
||
| 323 | * @param boolean $isDirectOutput 是否直接输出 |
||
| 324 | */ |
||
| 325 | function Disp($isDirectOutput = true) |
||
| 333 | |||
| 334 | /** |
||
| 335 | * 生成分页索引代码 |
||
| 336 | * |
||
| 337 | * 所有参数使用相关的类变量，如果类变量没有事先赋值，则会使用默认值 |
||
| 338 | * @access private |
||
| 339 | * @return string |
||
| 340 | */ |
||
| 341 | function GetIndex() |
||
| 390 | |||
| 391 | /** |
||
| 392 | * 生成最终的HTML代码 |
||
| 393 | * |
||
| 394 | * @access private |
||
| 395 | * @param boolean $isDirectOutput 是否直接输出 |
||
| 396 | * @return string |
||
| 397 | */ |
||
| 398 | function GerHtml($isDirectOutput = false) |
||
| 534 | |||
| 535 | |||
| 536 | /** |
||
| 537 | * 设置列表的模板文件 |
||
| 538 | * |
||
| 539 | * @param string $fileName |
||
| 540 | */ |
||
| 541 | function SetTemplate($fileName) |
||
| 548 | |||
| 549 | |||
| 550 | //--------------------------以下为从func_url.php中的URL函数---------------- |
||
| 551 | /** |
||
| 552 | * 增加或设置/更改URL参数 |
||
| 553 | * @access private |
||
| 554 | * @see UnsetUrlParam() |
||
| 555 | * @param string $urlStr 要进行处理的URL地址 |
||
| 556 | * @param string $strName 要添加的参数等号左边，参数名 |
||
| 557 | * @param string $strValue 要添加的参数等号右边，参数值 |
||
| 558 | * @return string |
||
| 559 | */ |
||
| 560 | function SetUrlParam($urlStr, $strName, $strValue = '') |
||
| 586 | |||
| 587 | /** |
||
| 588 | * 去掉URL参数 |
||
| 589 | * @access private |
||
| 590 | * @see SetUrlParam() |
||
| 591 | * @param string $urlStr 要进行处理的URL地址 |
||
| 592 | * @param string $strName 要删除的参数名 |
||
| 593 | * @return string |
||
| 594 | */ |
||
| 595 | function UnsetUrlParam($urlStr, $strName) |
||
| 616 | |||
| 617 | /** |
||
| 618 | * 将URL地址转换为数组 |
||
| 619 | * |
||
| 620 | * {@source 4 21} |
||
| 621 | * @access private |
||
| 622 | * @see ArrayToUrl() |
||
| 623 | * @param string $urlStr URL地址 |
||
| 624 | * @return array |
||
| 625 | */ |
||
| 626 | function UrlToArray($urlStr) |
||
| 683 | |||
| 684 | /** |
||
| 685 | * 将数组转换为URL地址 |
||
| 686 | * |
||
| 687 | * 要进行转换的源数组必须是{@link UrlToArray()}结果的格式，即数组的第一个元素为文件地址，其余为各参数 |
||
| 688 | * @access private |
||
| 689 | * @see UrlToArray() |
||
| 690 | * @param array $ar 数组 |
||
| 691 | * @return string |
||
| 692 | */ |
||
| 693 | View Code Duplication | function ArrayToUrl(&$ar) |
|
| 716 | //-------------------------------------end--------------------------------- |
||
| 717 | |||
| 718 | } // end class DispListTable |
||
| 719 | |||
| 841 |
Loading history...
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.