Fwk\Core\Action\ControllerActionProxy

Complexity

Total Complexity

4

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

1

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	1	Features	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	3
A	instantiate()	0	6	1

<?php
/**
 * Fwk
 *
 * Copyright (c) 2011-2014, Julien Ballestracci <julien@nitronet.org>.
 * All rights reserved.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
 * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
 * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
 * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
 * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 *
 * PHP Version 5.3
 *
 * @category  Core
 * @package   Fwk\Core
 * @author    Julien Ballestracci <julien@nitronet.org>
 * @copyright 2011-2014 Julien Ballestracci <julien@nitronet.org>
 * @license   http://www.opensource.org/licenses/bsd-license.php  BSD License
 * @link      http://www.fwk.pw
 */
namespace Fwk\Core\Action;

use Fwk\Core\Application;

/**
 * ActionProxy to a Controller class
 *
 * @category ActionProxy
 * @package  Fwk\Core
 * @author   Julien Ballestracci <julien@nitronet.org>
 * @license  http://www.opensource.org/licenses/bsd-license.php  BSD License
 * @link     http://www.fwk.pw
 */
class ControllerActionProxy extends AbstractControllerActionProxy
{
    /**
     * Controller's full class name
     * 
     * @var string
     */
    protected $className;
    
    /**
     * Controller's method
     * 
     * @var string
     */
    protected $method;

    /**
     * Constructor
     * 
     * @param string $className Controller's full class name
     * @param string $method    Controller's method
     * 
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     * @throws \InvalidArgumentException if $className or $method is empty
     */
    public function __construct($className, $method)
    {
        if (empty($className) || empty($method)) {
            throw new \InvalidArgumentException(
                "Controller class name and method cannot be empty"
            );
        }
        
        $this->className    = $className;
        $this->method       = $method;
    }
    
    /**
     * Instanciates the controller class
     * 
     * @param Application $app The running application
     * 
     * @return mixed Controller's instance

Consider making the return type a bit more specific; maybe use object.

     */
    protected function instantiate(Application $app)
    {
        $refClass = new \ReflectionClass($this->className);
        
        return $refClass->newInstanceArgs();
    }
}