Fwk\Core\Accessor

Complexity

Total Complexity

47

Size/Duplication

Total Lines	309
Duplicated Lines	0 %

Coupling/Cohesion

Dependencies

0

Test Coverage

Coverage

100%

Importance

Changes	9
Bugs	4	Features	4

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
C	get()	0	30	12
C	set()	0	38	11
A	setValues()	0	6	2
A	getReflector()	0	8	2
A	toArray()	0	18	3
B	getClassProperties()	0	28	4
A	getAttributes()	0	11	2
A	hashCode()	0	16	3
A	everythingAsArrayModifier()	0	15	4
A	factory()	0	4	1
A	overrideVisibility()	0	4	1

<?php
/**
 * Fwk
 *
 * Copyright (c) 2011-2012, Julien Ballestracci <julien@nitronet.org>.
 * All rights reserved.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
 * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
 * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
 * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
 * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
 * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 *
 * PHP Version 5.3
 *
 * @category  Core
 * @package   Fwk\Core
 * @author    Julien Ballestracci <julien@nitronet.org>
 * @copyright 2011-2012 Julien Ballestracci <julien@nitronet.org>
 * @license   http://www.opensource.org/licenses/bsd-license.php  BSD License
 * @link      http://www.fwk.pw
 */
namespace Fwk\Core;

/**
 * This class is a simple accessor for values of objects
 *
 * If getters/setters are found, we use them first.
 * If not, we try to directly get/set the value (\ArrayAccess or \stdClass)
 *
 * @category Utilities
 * @package  Fwk\Core
 * @author   Julien Ballestracci <julien@nitronet.org>
 * @license  http://www.opensource.org/licenses/bsd-license.php  BSD License
 * @link     http://www.phpfwk.com
 */
class Accessor
{
    /**
     * The object to access
     *
     * @var mixed
     */
    protected $object;

    /**
     * Reflector for the object
     *
     * @var \ReflectionObject
     */
    protected $reflector;

    /**
     * Override properties visibility ?
     *
     * @var boolean
     */
    protected $force = false;

    /**
     * Constructor
     *
     * @param mixed $object The object we want to access
     *
     * @throws \InvalidArgumentException if $object is not an object
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($object)
    {
        if (!is_object($object)) {
            throw new \InvalidArgumentException("Argument is not an object");
        }

        $this->object   = $object;
    }

    /**
     * Try to retrieve a value from the object
     *
     * @param string $key Propertie's name
     *
     * @return mixed Actual value if reached or false
     */
    public function get($key)
    {
        $obj        = $this->object;
        $getter     = "get". ucfirst($key);

        if (\method_exists($obj, $getter) && \is_callable(array($obj, $getter))) {
            return $obj->{$getter}();
        } elseif ($obj instanceof \stdClass && isset($obj->{$key})) {
            return  $obj->{$key};
        } elseif ($obj instanceof \ArrayAccess && $obj->offsetExists($key)) {
            return  $obj->offsetGet($key);
        } else {
            $this->getReflector();
            try {
                $props   = $this->getClassProperties($this->reflector->getName());
                if (!isset($props[$key])) {
                    return false;
                }
                $prop    = $props[$key];
                if (($prop->isPrivate() || $prop->isProtected()) && $this->force) {
                    $prop->setAccessible(true);
                }

                return $prop->getValue($obj);
            } catch (\ReflectionException $e) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        return false;
    }

    /**
     * Try to set a value
     *
     * @param string $key   Propertie's name
     * @param mixed  $value Desired value
     *
     * @return boolean true if successful
     */
    public function set($key, $value)

function set() does not seem to conform to the naming convention (^(?:is|has|should|may|supports|register|unregister|exists)).

    {
        $obj        = $this->object;
        $setter     = "set". ucfirst($key);

        if (\method_exists($obj, $setter) && \is_callable(array($obj, $setter))) {
            $obj->{$setter}($value);
            return true;
        }

        if ($obj instanceof \stdClass) {
            $obj->{$key}    = $value;
            return true;
        }

        if ($obj instanceof \ArrayAccess) {
            $obj->offsetSet($key, $value);
            return true;
        }

        $reflector  = $this->getReflector();
        try {
            $prop   = $reflector->getProperty($key);

            if (($prop->isPrivate() || $prop->isProtected()) && $this->force) {
                $prop->setAccessible(true);
            }

            if ($prop->isPublic() || $this->force === true) {
                $prop->setValue($obj, $value);

                return true;
            }
        } catch (\ReflectionException $e) {

Consider adding a comment why this CATCH block is empty.

        }

        return false;
    }

    /**
     * Set multiple values at once
     *
     * @param array $values Array of keys->values to be set
     *
     * @return void
     */
    public function setValues(array $values)
    {
        foreach ($values as $key => $value) {
            $this->set($key, $value);
        }
    }

    /**
     * Gets a reflector for the object
     *
     * @return \ReflectionObject
     */
    public function getReflector()
    {
        if (!isset($this->reflector)) {
            $this->reflector = new \ReflectionObject($this->object);
        }

        return $this->reflector;
    }

    /**
     * Make an array of keys->values (eventually filtered by $modifier) from
     * object's properties.
     *
     * @param mixed $modifier Filtering callable
     *
     * @return array The resulting array
     */
    public function toArray($modifier = null)
    {
        $this->getReflector();
        $final      = array();
        $props      = $this->getClassProperties($this->reflector->getName());

        foreach ($props as $property) {
            $value = $this->get($property->getName());

            if (\is_callable($modifier)) {
                $value  = \call_user_func_array($modifier, array($value));
            }

            $final[$property->getName()] = $value;
        }

        return $final;
    }
    
    /**
     * Recursive function to get an associative array of class properties by 
     * property name => ReflectionProperty() object including inherited ones 
     * from extended classes.
     * 
     * @param string  $className Class name
     * @param integer $filter    ReflectionProperty filter

Should the type for parameter $filter not be integer|null?

     * 
     * @author muratyaman at gmail dot com
     * @return array
     */
    protected function getClassProperties($className, $filter = null)
    {
        $ref            = new \ReflectionClass($className);
        if (null === $filter) {
            $filter = \ReflectionProperty::IS_PUBLIC 
                    | \ReflectionProperty::IS_PRIVATE 
                    | \ReflectionProperty::IS_PROTECTED 
                    | \ReflectionProperty::IS_STATIC;
        }
        
        $props          = $ref->getProperties($filter);
        $props_arr      = array();

$props_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $parentClass    = $ref->getParentClass();
        
        foreach ($props as $prop) {
            $f              = $prop->getName();
            $props_arr[$f]  = $prop;

$props_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        
        if ($parentClass) {
            $props_arr = array_merge(

$props_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $this->getClassProperties($parentClass->getName(), $filter), 
                $props_arr

$props_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            );
        }
        
        return $props_arr;

$props_arr does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } 

    /**
     * Returns class attributes
     *
     * @return array The resulting array
     */
    public function getAttributes()
    {
        $reflector  = $this->getReflector();
        $final      = array();

        foreach ($reflector->getProperties() as $property) {
            $final[] = $property->getName();
        }

        return $final;
    }

    /**
     * Produces a unique hash code based on values
     *
     * @param string $algo Desired algorythm
     *
     * @return string
     */
    public function hashCode($algo  = 'md5')
    {
        $old    = $this->force;
        $this->overrideVisibility(true);
        $array  = $this->toArray(array($this, 'everythingAsArrayModifier'));
        \ksort($array);
        $str    = \get_class($this->object);

        foreach ($array as $value) {
            $str .= (is_array($value) ? json_encode($value) : $value);
        }

        $this->overrideVisibility($old);

        return \hash($algo, $str);
    }

    /**
     * Static toArray() modifier to handle objects and relations.
     * {@see Accessor::toArray()}
     *
     * @param mixed $value Actual value
     *
     * @return mixed Filtered value

Consider making the return type a bit more specific; maybe use integer|double|string|null|boolean|resource|array.

     */
    public function everythingAsArrayModifier($value)
    {
        if (is_object($value)) {
            $accessor   = self::factory($value);
            $value      = $accessor->toArray(array($this, __METHOD__));
        }

        if (is_array($value)) {
            foreach ($value as $key => $val) {
                $value[$key] = $val;
            }
        }

        return $value;
    }

    /**
     * Factory utility
     *
     * @param mixed $object The object we want to access
     *
     * @return Accessor
     */
    public static function factory($object)
    {
        return new static($object);
    }

    /**
     * Should we force properties visibility ?
     *
     * @param boolean $bool yes or no
     *
     * @return void
     */
    public function overrideVisibility($bool)
    {
        $this->force = (bool) $bool;
    }
}