SessionHandler.has_media_changed() - Code Metrics - Inspection of "Implemented multi-part scrobbling of OEM mappings" - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — beta ( 918fe2...7d3e07 )

by Dean

created 2016-07-23 13:04 UTC

SessionHandler.has_media_changed() B

↳ Parent: SessionHandler

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	5.9256

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	12
ccs	2
cts	3
cp	0.6667
rs	8.5454
c	1
b	0
f	0
cc	5
crap	5.9256

class Handler(object):
    __event__ = None

    __src__ = []
    __dst__ = []

    @classmethod
    def is_valid_source(cls, state):
        return state in cls.__src__

    @classmethod
    def is_valid_destination(cls, state):
        return state in cls.__dst__

    @classmethod
    def process(cls, obj, payload):
        pass


class SessionHandler(Handler):
    @staticmethod
    def has_finished(session, payload):
        if not session or not session.duration:
            return False

        # Calculate session progress
        # TODO update to support multi-part sessions

        progress = float(payload.get('view_offset')) / session.duration

        # Session is finished when `progress` reaches at least 100%
        return progress >= 1.0

    @staticmethod
    def has_media_changed(session, payload):
        if not session or not session.rating_key:
            return False

        if session.rating_key != payload.get('rating_key'):
            return True

        if session.part != payload.get('part', 1):
            return True

        return False


1	1	class Handler(object):
2	1	__event__ = None
3
4	1	__src__ = []
5	1	__dst__ = []
6
7	1	@classmethod
8		def is_valid_source(cls, state):
9	1	return state in cls.__src__
10
11	1	@classmethod
12		def is_valid_destination(cls, state):
13		return state in cls.__dst__
14
15	1	@classmethod
16		def process(cls, obj, payload):
17		pass
18
19
20	1	class SessionHandler(Handler):
21	1	@staticmethod
22		def has_finished(session, payload):
23	1	if not session or not session.duration:
24		return False
25
26		# Calculate session progress
27	1	# TODO update to support multi-part sessions
		0 ignored issues – show Coding Style introduced 2016-07-23 13:07 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
28		progress = float(payload.get('view_offset')) / session.duration
29
30	1	# Session is finished when `progress` reaches at least 100%
31		return progress >= 1.0
32	1
33		@staticmethod
34	1	def has_media_changed(session, payload):
35		if not session or not session.rating_key:
36		return False
37	1
38		if session.rating_key != payload.get('rating_key'):
39		return True
40
41		if session.part != payload.get('part', 1):
42		return True
43
44		return False
45

fuzeman / Plex-Trakt-Scrobbler

Push — beta ( 918fe2...7d3e07 )

SessionHandler.has_media_changed() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like