ErrorStorage

Complexity

Total Complexity

6

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	emit()	0	16	5
A	__init__()	0	2	1

from plugin.managers.exception import ExceptionManager

from exception_wrappers import DisabledError
import logging

log = logging.getLogger(__name__)


class ErrorStorage(logging.Handler):
    def __init__(self):
        super(ErrorStorage, self).__init__()

    def emit(self, record):
        if record.levelno < logging.ERROR:
            return

        try:
            if record.exc_info:
                ExceptionManager.create.from_exc_info(record.exc_info)
                return

            self.format(record)

            ExceptionManager.create.from_message(record.message)

It seems like a value for argument message is missing in the unbound method call.

        except DisabledError:

This except handler seems to be unused and could be removed.

            pass
        except Exception as ex:

Catching very general exceptions such as Exception is usually not recommended.

            log.warn('Unable to store exception message: %s', ex, exc_info=True)

ERROR_STORAGE_HANDLER = ErrorStorage()