PlexBasicCredential.refresh_details() - Code Metrics - Inspection of "Updated the `Mapper` module to support oem-client..." - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — beta ( a8392a...918fe2 )

by Dean

created 2016-07-19 04:24 UTC

PlexBasicCredential.refresh_details() F

↳ Parent: PlexBasicCredential

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	79.8826

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	42
ccs	1
cts	23
cp	0.0434
rs	3
cc	9
crap	79.8826

from plugin.core.environment import Environment
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from plugin.models.m_plex.account import PlexAccount
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from plugin.models.core import db

from playhouse.apsw_ext import *

from xml.etree import ElementTree
import logging
import requests

log = logging.getLogger(__name__)


class PlexBasicCredential(Model):
    class Meta:
        database = db
        db_table = 'plex.credential.basic'

    account = ForeignKeyField(PlexAccount, 'basic_credentials', unique=True)

    password = CharField(null=True)

    # Authorization
    token_plex = CharField(null=True)
    token_server = CharField(null=True)

    @property
    def state(self):
        if self.token_plex is not None and self.token_server is not None:
            return 'valid'

        if self.password is not None:
            return 'warning'

        return 'empty'

    def refresh(self, force=False, save=True):
        # Refresh account details
        if not self.refresh_details(force):
            return False

        # Store changes in database
        if save:
            self.save()

        return True

    def refresh_details(self, force=False):
        if self.token_plex is None:
            # Missing token
            return False

        if not force and self.token_server:
            # Already authenticated
            return True

        if self.token_plex == 'anonymous':
            return self.refresh_anonymous()

        log.info('Refreshing plex credential: %r', self)

        # Fetch server token
        response = requests.get('https://plex.tv/api/resources?includeHttps=1', headers={
            'X-Plex-Token': self.token_plex
        })

        if not (200 <= response.status_code < 300):

            log.warn('Unable to retrieve servers from plex.tv (status_code: %s)', response.status_code)
            return False

        devices = ElementTree.fromstring(response.content)

        # Find server
        server = None

        for s in devices.findall('Device'):
            if s.attrib.get('clientIdentifier') != Environment.platform.machine_identifier:
                continue

            server = s

        if server is None:
            log.warn('Unable to find server with identifier: %r', Environment.platform.machine_identifier)
            return False

        # Update `token_server`
        self.token_server = server.attrib.get('accessToken') or self.token_plex

        return True

    def refresh_anonymous(self):
        log.info('Refreshing plex credential: %r (anonymous)', self)

        self.token_server = 'anonymous'

        return True

    def to_json(self, account):
        result = {
            'state': self.state,

            'username': account.username
        }

        if self.password:
            result['password'] = '*' * len(self.password)
        elif self.token_plex:
            result['password'] = '*' * 8

        return result


Push — beta ( a8392a...918fe2 )

PlexBasicCredential.refresh_details() F

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1	1	from plugin.core.environment import Environment
		0 ignored issues – show Bug introduced 2016-06-12 12:39 UTC by Report Bug Copy Issue Report The name `environment` does not seem to exist in module `plugin.core`. Loading history... Configuration introduced 2016-07-01 11:50 UTC by Report Bug Copy Issue Report Unable to import 'plugin.core.environment' (invalid syntax (<string>, line 105)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
2	1	from plugin.models.m_plex.account import PlexAccount
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The name `account` does not seem to exist in module `plugin.models.m_plex`. Loading history... Configuration introduced 2016-07-04 22:51 UTC by Report Bug Copy Issue Report Unable to import 'plugin.models.m_plex.account' (invalid syntax (<string>, line 145)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
3	1	from plugin.models.core import db
4
5	1	from playhouse.apsw_ext import *
		0 ignored issues – show Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The usage of wildcard imports like `playhouse.apsw_ext` should generally be avoided. Loading history...
6	1	from xml.etree import ElementTree
7	1	import logging
8	1	import requests
9
10	1	log = logging.getLogger(__name__)
11
12
13	1	class PlexBasicCredential(Model):
14	1	class Meta:
15	1	database = db
16	1	db_table = 'plex.credential.basic'
17
18	1	account = ForeignKeyField(PlexAccount, 'basic_credentials', unique=True)
19
20	1	password = CharField(null=True)
21
22		# Authorization
23	1	token_plex = CharField(null=True)
24	1	token_server = CharField(null=True)
25
26	1	@property
27		def state(self):
28		if self.token_plex is not None and self.token_server is not None:
29		return 'valid'
30
31		if self.password is not None:
32		return 'warning'
33
34		return 'empty'
35
36	1	def refresh(self, force=False, save=True):
37		# Refresh account details
38		if not self.refresh_details(force):
39		return False
40
41		# Store changes in database
42		if save:
43		self.save()
44
45		return True
46
47	1	def refresh_details(self, force=False):
48		if self.token_plex is None:
49		# Missing token
50		return False
51
52		if not force and self.token_server:
53		# Already authenticated
54		return True
55
56		if self.token_plex == 'anonymous':
57		return self.refresh_anonymous()
58
59		log.info('Refreshing plex credential: %r', self)
60
61		# Fetch server token
62		response = requests.get('https://plex.tv/api/resources?includeHttps=1', headers={
63		'X-Plex-Token': self.token_plex
64		})
65
66		if not (200 <= response.status_code < 300):
		0 ignored issues – show Unused Code Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `not`. Loading history...
67		log.warn('Unable to retrieve servers from plex.tv (status_code: %s)', response.status_code)
68		return False
69
70		devices = ElementTree.fromstring(response.content)
71
72		# Find server
73		server = None
74
75		for s in devices.findall('Device'):
76		if s.attrib.get('clientIdentifier') != Environment.platform.machine_identifier:
77		continue
78
79		server = s
80
81		if server is None:
82		log.warn('Unable to find server with identifier: %r', Environment.platform.machine_identifier)
83		return False
84
85		# Update `token_server`
86		self.token_server = server.attrib.get('accessToken') or self.token_plex
87
88		return True
89
90	1	def refresh_anonymous(self):
91		log.info('Refreshing plex credential: %r (anonymous)', self)
92
93		self.token_server = 'anonymous'
94
95		return True
96
97	1	def to_json(self, account):
98		result = {
99		'state': self.state,
100
101		'username': account.username
102		}
103
104		if self.password:
105		result['password'] = '' len(self.password)
106		elif self.token_plex:
107		result['password'] = '' 8
108
109		return result
110

fuzeman / Plex-Trakt-Scrobbler

Push — beta ( a8392a...918fe2 )

PlexBasicCredential.refresh_details() F

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files

2. Missing init.py files