MethodManager.filter() - Code Metrics - Inspection of "Updated sortedcontainers (v1.5.3)" - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 3d8444...ce4f6d )

by Dean

created 2016-06-06 12:00 UTC

MethodManager.filter() B

↳ Parent: MethodManager

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	8
c	0
b	0
f	0
cc	6
crap	42

import logging

log = logging.getLogger(__name__)


class MethodManager(object):
    def __init__(self, methods, single=True):
        self.methods = [
            (m.name, m) for m in methods
        ]
        self.single = single

    def filter(self, enabled):
        for name, method in self.methods:
            if enabled is not None and name not in enabled:
                log.debug('Method %r has been disabled', name)
                continue

            if not hasattr(method, 'test'):
                log.warn('Method %r is missing a test() method')
                continue

            if not method.test():
                log.info("Method %r is not available" % name)

                continue

            yield method

    def start(self, enabled=None):
        started = []

        for method in self.filter(enabled):
            obj = method()

            # Store reference
            started.append(obj)

            if self.single:
                break

        log.info(
            'Started %s method(s): %s',
            len(started),
            ', '.join([m.__class__.__name__ for m in started])
        )

        return started


1			import logging
2
3			log = logging.getLogger(__name__)
4
5
6			class MethodManager(object):
7			def __init__(self, methods, single=True):
8			self.methods = [
9			(m.name, m) for m in methods
10			]
11			self.single = single
12
13			def filter(self, enabled):
14			for name, method in self.methods:
15			if enabled is not None and name not in enabled:
16			log.debug('Method %r has been disabled', name)
17			continue
18
19			if not hasattr(method, 'test'):
20			log.warn('Method %r is missing a test() method')
21			continue
22
23			if not method.test():
24			log.info("Method %r is not available" % name)
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report Specify string format arguments as logging function parameters Loading history...
25			continue
26
27			yield method
28
29			def start(self, enabled=None):
30			started = []
31
32			for method in self.filter(enabled):
33			obj = method()
34
35			# Store reference
36			started.append(obj)
37
38			if self.single:
39			break
40
41			log.info(
42			'Started %s method(s): %s',
43			len(started),
44			', '.join([m.__class__.__name__ for m in started])
45			)
46
47			return started
48

fuzeman / Plex-Trakt-Scrobbler

Push — develop ( 3d8444...ce4f6d )

MethodManager.filter() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like