Matcher.configure() - Code Metrics - Inspection of "Updated plex.database.py" - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( a80574...5ed66c )

by Dean

created 2016-11-10 04:15 UTC

Matcher.configure() C

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	7.1782

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	29
ccs	11
cts	13
cp	0.8462
rs	5.5
cc	7
crap	7.1782

from plugin.core.cache import CacheManager
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from plugin.core.enums import MatcherMode
from plugin.modules.core.base import Module
from plugin.preferences import Preferences

from plex import Plex
from plex.objects.library.metadata.episode import Episode
import plex_database.matcher
import plex_metadata.matcher
import logging

log = logging.getLogger(__name__)


class Matcher(Module):
    __key__ = 'matcher'

    def __init__(self):
        self._cache = None

        self._database_matcher = None
        self._metadata_matcher = None

    @property
    def database(self):
        return self._database_matcher

    @property
    def metadata(self):
        return self._metadata_matcher

    def configure(self):
        extended = Preferences.get('matcher.mode') == MatcherMode.PlexExtended

        # Configure matchers
        matchers = [
            self._database_matcher,
            self._metadata_matcher,

            # Default matchers
            plex_database.matcher.Default,
            plex_metadata.matcher.Default
        ]

        for matcher in matchers:
            if not matcher:
                continue

            # Update cache
            if self._cache:
                matcher.cache = self._cache

            # Configure features
            if matcher.caper_enabled != extended or matcher.extend_enabled != extended:
                matcher.caper_enabled = extended
                matcher.extend_enabled = extended

                log.info('Extended matcher has been %s on %r', 'enabled' if extended else 'disabled', matcher)

        return True

    def flush(self, force=False):
        if not self._cache:
            return False

        self._cache.flush(force=force)
        return True

    def prime(self, keys=None, force=False):
        if not self._cache:
            return DummyContext()

        return self._cache.prime(
            keys=keys,
            force=force
        )

    def process(self, episode):
        if not episode or not isinstance(episode, Episode):
            raise ValueError('Invalid value specified for the "episode" parameter: %r' % (episode,))

        if not self._metadata_matcher:
            return episode.season.index, [episode.index]

        # Process episode with matcher
        season, episodes = self._metadata_matcher.process(episode)

        log.debug('Matcher returned season: %r, episodes: %r', season, episodes)
        return season, episodes

    def start(self):
        if self._database_matcher and self._metadata_matcher:
            return

        if self._database_matcher is False or self._metadata_matcher is False:
            return

        try:
            self._cache = CacheManager.get('plex.matcher')

            self._database_matcher = plex_database.matcher.Matcher(self._cache, Plex.client)

            self._metadata_matcher = plex_metadata.matcher.Matcher(self._cache, Plex.client)

        except Exception as ex:

            log.warn('Unable to initialize matchers: %s', ex, exc_info=True)

            # Mark attributes as disabled
            self._cache = None
            self._database_matcher = None
            self._metadata_matcher = None
            return

        # Configure matchers
        self.configure()


class DummyContext(object):
    def __enter__(self):
        pass

    def __exit__(self, exc_type, exc_val, exc_tb):
        pass


Push — develop ( a80574...5ed66c )

Matcher.configure() C

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing init.py files

1	1	from plugin.core.cache import CacheManager
		0 ignored issues – show Bug introduced 2016-09-08 03:10 UTC by Report Bug Copy Issue Report The name `cache` does not seem to exist in module `plugin.core`. Loading history... Configuration introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report Unable to import 'plugin.core.cache' (invalid syntax (<string>, line 150)) This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
2	1	from plugin.core.enums import MatcherMode
3	1	from plugin.modules.core.base import Module
4	1	from plugin.preferences import Preferences
5
6	1	from plex import Plex
7	1	from plex.objects.library.metadata.episode import Episode
8	1	import plex_database.matcher
9	1	import plex_metadata.matcher
10	1	import logging
11
12	1	log = logging.getLogger(__name__)
13
14
15	1	class Matcher(Module):
16	1	__key__ = 'matcher'
17
18	1	def __init__(self):
19	1	self._cache = None
20
21	1	self._database_matcher = None
22	1	self._metadata_matcher = None
23
24	1	@property
25		def database(self):
26	1	return self._database_matcher
27
28	1	@property
29		def metadata(self):
30		return self._metadata_matcher
31
32	1	def configure(self):
33	1	extended = Preferences.get('matcher.mode') == MatcherMode.PlexExtended
34
35		# Configure matchers
36	1	matchers = [
37		self._database_matcher,
38		self._metadata_matcher,
39
40		# Default matchers
41		plex_database.matcher.Default,
42		plex_metadata.matcher.Default
43		]
44
45	1	for matcher in matchers:
46		if not matcher:
47	1	continue
48
49		# Update cache
50	1	if self._cache:
51	1	matcher.cache = self._cache
52	1
53		# Configure features
54	1	if matcher.caper_enabled != extended or matcher.extend_enabled != extended:
55		matcher.caper_enabled = extended
56	1	matcher.extend_enabled = extended
57
58	1	log.info('Extended matcher has been %s on %r', 'enabled' if extended else 'disabled', matcher)
59
60		return True
61
62		def flush(self, force=False):
63		if not self._cache:
64		return False
65	1
66		self._cache.flush(force=force)
67		return True
68
69		def prime(self, keys=None, force=False):
70		if not self._cache:
71		return DummyContext()
72
73		return self._cache.prime(
74	1	keys=keys,
75		force=force
76		)
77
78		def process(self, episode):
79		if not episode or not isinstance(episode, Episode):
80		raise ValueError('Invalid value specified for the "episode" parameter: %r' % (episode,))
81
82		if not self._metadata_matcher:
83		return episode.season.index, [episode.index]
84
85		# Process episode with matcher
86		season, episodes = self._metadata_matcher.process(episode)
87	1
88	1	log.debug('Matcher returned season: %r, episodes: %r', season, episodes)
89		return season, episodes
90
91	1	def start(self):
92		if self._database_matcher and self._metadata_matcher:
93		return
94	1
95	1	if self._database_matcher is False or self._metadata_matcher is False:
96		return
97	1
98	1	try:
99		self._cache = CacheManager.get('plex.matcher')
100
101		self._database_matcher = plex_database.matcher.Matcher(self._cache, Plex.client)
		0 ignored issues – show Bug introduced 2016-09-08 03:10 UTC by Report Bug Copy Issue Report The Class `Plex` does not seem to have a member named `client`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
102		self._metadata_matcher = plex_metadata.matcher.Matcher(self._cache, Plex.client)
		0 ignored issues – show Bug introduced 2016-09-08 03:10 UTC by Report Bug Copy Issue Report The Class `Plex` does not seem to have a member named `client`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
103		except Exception as ex:
		0 ignored issues – show Best Practice introduced 2016-09-08 03:10 UTC by Report Bug Copy Issue Report Catching very general exceptions such as `Exception` is usually not recommended. Generally, you would want to handle very specific errors in the exception handler. This ensure that you do not hide other types of errors which should be fixed. So, unless you specifically plan to handle any error, consider adding a more specific exception. Loading history...
104		log.warn('Unable to initialize matchers: %s', ex, exc_info=True)
105
106		# Mark attributes as disabled
107		self._cache = None
108		self._database_matcher = None
109	1	self._metadata_matcher = None
110		return
111
112	1	# Configure matchers
113	1	self.configure()
114
115
116	1	class DummyContext(object):
117		def __enter__(self):
118		pass
119
120		def __exit__(self, exc_type, exc_val, exc_tb):
121		pass
122

fuzeman / Plex-Trakt-Scrobbler

Push — develop ( a80574...5ed66c )

Matcher.configure() C

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

2. Missing init.py files