Create.__call__() - Code Metrics - Inspection of "Updated plex.database.py" - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( a80574...5ed66c )

by Dean

created 2016-11-10 04:15 UTC

Create.call() B

↳ Parent: Create

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	9.2876

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
ccs	4
cts	9
cp	0.4444
rs	8.5454
cc	5
crap	9.2876

from plugin.core.exceptions import PluginDisabledError
from plugin.core.message import InterfaceMessages
from plugin.models import db

import apsw
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import inspect
import logging
import peewee

log = logging.getLogger(__name__)


class Method(object):
    def __init__(self, manager, *args, **kwargs):

        self.manager = manager

    @property
    def model(self):
        return self.manager.model


class Get(Method):
    def __call__(self, *query, **kwargs):
        if InterfaceMessages.critical:

            raise PluginDisabledError()

        obj = self.model.get(*query, **kwargs)

        if obj:
            obj._created = False
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        return obj

    def all(self):
        if InterfaceMessages.critical:

            raise PluginDisabledError()

        return self.model.select()

    def by_id(self, id):

        return self(self.model.id == id)

    def or_create(self, *query, **kwargs):
        try:
            return self.manager.create(**kwargs)
        except (apsw.ConstraintError, peewee.IntegrityError) as ex:
            log.debug('or_create() - ex: %r', ex)

        return self(*query)

    def where(self, *query):
        if InterfaceMessages.critical:

            raise PluginDisabledError()

        return self.model.select().where(*query)


class Create(Method):
    def __call__(self, **kwargs):
        if not self.model:
            raise Exception('Manager %r has no "model" attribute defined' % self.manager)

        if InterfaceMessages.critical:

            raise PluginDisabledError()

        with db.transaction():
            obj = self.model.create(**kwargs)

        if obj:
            # Set flag
            obj._created = True
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

        return obj


class Update(Method):
    keys = []

    def __call__(self, obj, data, save=True):
        changed = False

        for key, value in data.items():
            if not hasattr(obj, key):
                raise KeyError('%r has no key %r' % (obj, key))

            if getattr(obj, key) == value:
                continue

            changed = True
            setattr(obj, key, value)

        if not changed:
            return False

        if save:
            if InterfaceMessages.critical:

                raise PluginDisabledError()

            obj.save()

        return True

    def from_dict(self, obj, changes, save=True):
        if not changes:
            return False

        # Resolve `account`
        if inspect.isfunction(obj):
            obj = obj()

        # Update `TraktAccount`
        data = {}

        for key in self.keys:
            if key not in changes:
                continue

            data[key] = changes[key]

        if data and not self(obj, data, save=save):
            log.debug('Unable to update %r (nothing changed?)', obj)

        return True


class ManagerMeta(type):
    def __init__(cls, name, bases, attributes):
        super(ManagerMeta, cls).__init__(name, bases, attributes)

        if '__metaclass__' in attributes:
            return

        # Construct manager methods
        for key in ['get', 'create', 'update']:
            value = getattr(cls, key)

            if not value or not inspect.isclass(value):
                continue

            # Construct method
            setattr(cls, key, value(cls))


class Manager(object):
    __metaclass__ = ManagerMeta

    create = Create
    get = Get
    update = Update

    model = None


1	1	from plugin.core.exceptions import PluginDisabledError
2	1	from plugin.core.message import InterfaceMessages
3		from plugin.models import db
4	1
5	1	import apsw
		0 ignored issues – show Configuration introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The import `apsw` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
6	1	import inspect
7	1	import logging
8		import peewee
9	1
10		log = logging.getLogger(__name__)
11
12	1
13	1	class Method(object):
14	1	def __init__(self, manager, args, *kwargs):
		0 ignored issues – show Unused Code introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history...
15		self.manager = manager
16	1
17		@property
18	1	def model(self):
19		return self.manager.model
20
21	1
22	1	class Get(Method):
23		def __call__(self, query, *kwargs):
24		if InterfaceMessages.critical:
		0 ignored issues – show Bug introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The Class `InterfaceMessages` does not seem to have a member named `critical`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
25		raise PluginDisabledError()
26
27		obj = self.model.get(query, *kwargs)
28
29		if obj:
30	1	obj._created = False
		0 ignored issues – show Coding Style Best Practice introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report It seems like `_created` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
31
32		return obj
33	1
34		def all(self):
35		if InterfaceMessages.critical:
		0 ignored issues – show Bug introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The Class `InterfaceMessages` does not seem to have a member named `critical`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
36	1	raise PluginDisabledError()
37	1
38	1	return self.model.select()
39
40		def by_id(self, id):
		0 ignored issues – show Bug Best Practice introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `id`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
41		return self(self.model.id == id)
42
43		def or_create(self, query, *kwargs):
44	1	try:
45		return self.manager.create(**kwargs)
46		except (apsw.ConstraintError, peewee.IntegrityError) as ex:
47		log.debug('or_create() - ex: %r', ex)
48	1
49	1	return self(*query)
50	1
51		def where(self, *query):
52		if InterfaceMessages.critical:
		0 ignored issues – show Bug introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The Class `InterfaceMessages` does not seem to have a member named `critical`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
53	1	raise PluginDisabledError()
54	1
55		return self.model.select().where(*query)
56	1
57
58	1	class Create(Method):
59		def __call__(self, **kwargs):
60	1	if not self.model:
61		raise Exception('Manager %r has no "model" attribute defined' % self.manager)
62
63	1	if InterfaceMessages.critical:
		0 ignored issues – show Bug introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The Class `InterfaceMessages` does not seem to have a member named `critical`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
64	1	raise PluginDisabledError()
65
66	1	with db.transaction():
67		obj = self.model.create(**kwargs)
68
69		if obj:
70		# Set flag
71		obj._created = True
		0 ignored issues – show Coding Style Best Practice introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report It seems like `_created` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
72
73		return obj
74
75
76		class Update(Method):
77		keys = []
78
79		def __call__(self, obj, data, save=True):
80		changed = False
81
82		for key, value in data.items():
83		if not hasattr(obj, key):
84		raise KeyError('%r has no key %r' % (obj, key))
85
86		if getattr(obj, key) == value:
87	1	continue
88
89		changed = True
90		setattr(obj, key, value)
91
92		if not changed:
93		return False
94
95		if save:
96		if InterfaceMessages.critical:
		0 ignored issues – show Bug introduced 2016-11-10 04:18 UTC by Report Bug Copy Issue Report The Class `InterfaceMessages` does not seem to have a member named `critical`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
97		raise PluginDisabledError()
98
99		obj.save()
100
101		return True
102
103		def from_dict(self, obj, changes, save=True):
104		if not changes:
105		return False
106
107		# Resolve `account`
108		if inspect.isfunction(obj):
109		obj = obj()
110	1
111	1	# Update `TraktAccount`
112	1	data = {}
113
114	1	for key in self.keys:
115	1	if key not in changes:
116		continue
117
118	1	data[key] = changes[key]
119	1
120		if data and not self(obj, data, save=save):
121	1	log.debug('Unable to update %r (nothing changed?)', obj)
122
123		return True
124
125	1
126		class ManagerMeta(type):
127		def __init__(cls, name, bases, attributes):
128	1	super(ManagerMeta, cls).__init__(name, bases, attributes)
129	1
130		if '__metaclass__' in attributes:
131	1	return
132	1
133	1	# Construct manager methods
134		for key in ['get', 'create', 'update']:
135	1	value = getattr(cls, key)
136
137		if not value or not inspect.isclass(value):
138		continue
139
140		# Construct method
141		setattr(cls, key, value(cls))
142
143
144		class Manager(object):
145		__metaclass__ = ManagerMeta
146
147		create = Create
148		get = Get
149		update = Update
150
151		model = None
152

fuzeman / Plex-Trakt-Scrobbler

Push — develop ( a80574...5ed66c )

Create.__call__() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

Create.call() B

2. Missing init.py files