Shows.run() - Code Metrics - Inspection of "Merge branch 'release/0.9.10.15-beta' into develop" - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — develop ( e459d6...12ef70 )

by Dean

created 2016-01-17 21:31 UTC

Shows.run() F

↳ Parent: Shows

Complexity

Conditions

Size

Total Lines

151

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	723.2603

Metric	Value
cc	27
dl	0
loc	151
ccs	1
cts	66
cp	0.0152
crap	723.2603
rs	2

How to fix Long Method Complexity

from plugin.sync.core.constants import GUID_AGENTS
from plugin.sync.core.enums import SyncData, SyncMedia, SyncMode
from plugin.sync.modes.core.base import Mode, log_unsupported, mark_unsupported

from plex_database.models import MetadataItem
from trakt_sync.cache.main import Cache
import elapsed
import logging

log = logging.getLogger(__name__)


class Shows(Mode):
    mode = SyncMode.FastPull

    def __init__(self, task):
        super(Shows, self).__init__(task)

        # Sections
        self.p_sections = None
        self.p_sections_map = None

        # Shows
        self.p_shows = None
        self.p_shows_count = None
        self.p_shows_unsupported = None

        # Seasons
        self.p_seasons = None

        # Episodes
        self.p_episodes = None
        self.p_episodes_count = None

    @elapsed.clock
    def construct(self):
        # Retrieve show sections
        self.p_sections, self.p_sections_map = self.sections('show')


        # Determine number of shows that will be processed
        self.p_shows_count = self.plex.library.shows.count(

            self.p_sections
        )

        # Determine number of shows that will be processed
        self.p_episodes_count = self.plex.library.episodes.count_items(

            self.p_sections
        )

        # Increment progress steps total
        self.current.progress.group(Shows, 'shows').add(self.p_shows_count)

        self.current.progress.group(Shows, 'episodes').add(self.p_episodes_count)


    @elapsed.clock
    def start(self):
        # Fetch episodes with account settings
        self.p_shows, self.p_seasons, self.p_episodes = self.plex.library.episodes.mapped(

            self.p_sections, ([
                MetadataItem.library_section
            ], [], []),
            account=self.current.account.plex.key,

            parse_guid=True
        )

        # Reset state
        self.p_shows_unsupported = {}

    @elapsed.clock
    def run(self):
        # TODO process seasons


        with elapsed.clock(Shows, 'run:shows'):
            # Process shows
            for sh_id, guid, p_show in self.p_shows:
                # Increment one step
                self.current.progress.group(Shows, 'shows').step()


                # Ensure `guid` is available
                if not guid or guid.agent not in GUID_AGENTS:
                    mark_unsupported(self.p_shows_unsupported, sh_id, guid, p_show)
                    continue

                key = (guid.agent, guid.sid)

                log.debug('Processing show: %s', key)

                # Try retrieve `pk` for `key`
                pk = self.trakt.table.get(key)


                # Store in item map
                self.current.map.add(p_show.get('library_section'), sh_id, [key, pk])


                if pk is None:
                    # No `pk` found
                    continue

                # Iterate over changed data
                for key, result in self.trakt.changes:

                    media, data = key[0:2]

                    if media != SyncMedia.Shows:
                        # Ignore changes that aren't for episodes
                        continue

                    if data == SyncData.Watchlist:
                        # Ignore watchlist data
                        continue

                    if not self.is_data_enabled(data):

                        # Data type has been disabled
                        continue

                    data_name = Cache.Data.get(data)

                    if data_name not in result.changes:
                        # No changes for collection
                        continue

                    for action, shows in result.changes[data_name].items():
                        t_show = shows.get(pk)

                        if t_show is None:
                            # Unable to find matching show in trakt data
                            continue

                        # Execute show handlers
                        self.execute_handlers(

                            SyncMedia.Shows, data,
                            action=action,

                            key=sh_id,

                            p_item=p_show,
                            t_item=t_show
                        )

        # Stop progress group
        self.current.progress.group(Shows, 'shows').stop()


        with elapsed.clock(Shows, 'run:episodes'):
            # Process episodes
            for ids, guid, (season_num, episode_num), p_show, p_season, p_episode in self.p_episodes:

                # Increment one step
                self.current.progress.group(Shows, 'episodes').step()


                # Ensure `guid` is available
                if not guid or guid.agent not in GUID_AGENTS:
                    mark_unsupported(self.p_shows_unsupported, ids['show'], guid, p_show)
                    continue

                key = (guid.agent, guid.sid)

                log.debug('Processing episode: %s - S%02dE%02d', key, season_num, episode_num)

                # Try retrieve `pk` for `key`
                pk = self.trakt.table.get(key)


                if pk is None:
                    # No `pk` found
                    continue

                if not ids.get('episode'):
                    # Missing `episode` rating key
                    continue

                for key, result in self.trakt.changes:

                    media, data = key[0:2]

                    if media != SyncMedia.Episodes:
                        # Ignore changes that aren't for episodes
                        continue

                    if not self.is_data_enabled(data):

                        # Data type has been disabled
                        continue

                    data_name = Cache.Data.get(data)

                    if data_name not in result.changes:
                        # No changes for collection
                        continue

                    for action, shows in result.changes[data_name].items():
                        t_show = shows.get(pk)

                        if t_show is None:
                            # Unable to find matching show in trakt data
                            continue

                        t_season = t_show.get('seasons', {}).get(season_num)

                        if t_season is None:
                            # Unable to find matching season in `t_show`
                            continue

                        t_episode = t_season.get('episodes', {}).get(episode_num)

                        if t_episode is None:
                            # Unable to find matching episode in `t_season`
                            continue

                        self.execute_handlers(

                            SyncMedia.Episodes, data,
                            action=action,
                            key=ids['episode'],

                            p_item=p_episode,
                            t_item=t_episode
                        )

                # Task checkpoint
                self.checkpoint()


        # Stop progress group
        self.current.progress.group(Shows, 'episodes').stop()


        # Log details
        log_unsupported(log, 'Found %d unsupported show(s)\n%s', self.p_shows_unsupported)


1	1	from plugin.sync.core.constants import GUID_AGENTS
2	1	from plugin.sync.core.enums import SyncData, SyncMedia, SyncMode
3	1	from plugin.sync.modes.core.base import Mode, log_unsupported, mark_unsupported
4
5	1	from plex_database.models import MetadataItem
6	1	from trakt_sync.cache.main import Cache
7	1	import elapsed
8	1	import logging
9
10	1	log = logging.getLogger(__name__)
11
12
13	1	class Shows(Mode):
14	1	mode = SyncMode.FastPull
15
16	1	def __init__(self, task):
17		super(Shows, self).__init__(task)
18
19		# Sections
20		self.p_sections = None
21		self.p_sections_map = None
22
23		# Shows
24		self.p_shows = None
25		self.p_shows_count = None
26		self.p_shows_unsupported = None
27
28		# Seasons
29		self.p_seasons = None
30
31		# Episodes
32		self.p_episodes = None
33		self.p_episodes_count = None
34
35	1	@elapsed.clock
36		def construct(self):
37		# Retrieve show sections
38		self.p_sections, self.p_sections_map = self.sections('show')
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `sections`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
39
40		# Determine number of shows that will be processed
41		self.p_shows_count = self.plex.library.shows.count(
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `plex`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
42		self.p_sections
43		)
44
45		# Determine number of shows that will be processed
46		self.p_episodes_count = self.plex.library.episodes.count_items(
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `plex`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
47		self.p_sections
48		)
49
50		# Increment progress steps total
51		self.current.progress.group(Shows, 'shows').add(self.p_shows_count)
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
52		self.current.progress.group(Shows, 'episodes').add(self.p_episodes_count)
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
53
54	1	@elapsed.clock
55		def start(self):
56		# Fetch episodes with account settings
57		self.p_shows, self.p_seasons, self.p_episodes = self.plex.library.episodes.mapped(
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `plex`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
58		self.p_sections, ([
59		MetadataItem.library_section
60		], [], []),
61		account=self.current.account.plex.key,
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
62		parse_guid=True
63		)
64
65		# Reset state
66		self.p_shows_unsupported = {}
67
68	1	@elapsed.clock
69		def run(self):
70		# TODO process seasons
		0 ignored issues – show Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
71
72		with elapsed.clock(Shows, 'run:shows'):
73		# Process shows
74		for sh_id, guid, p_show in self.p_shows:
75		# Increment one step
76		self.current.progress.group(Shows, 'shows').step()
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
77
78		# Ensure `guid` is available
79		if not guid or guid.agent not in GUID_AGENTS:
80		mark_unsupported(self.p_shows_unsupported, sh_id, guid, p_show)
81		continue
82
83		key = (guid.agent, guid.sid)
84
85		log.debug('Processing show: %s', key)
86
87		# Try retrieve `pk` for `key`
88		pk = self.trakt.table.get(key)
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `trakt`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
89
90		# Store in item map
91		self.current.map.add(p_show.get('library_section'), sh_id, [key, pk])
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
92
93		if pk is None:
94		# No `pk` found
95		continue
96
97		# Iterate over changed data
98		for key, result in self.trakt.changes:
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `trakt`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
99		media, data = key[0:2]
100
101		if media != SyncMedia.Shows:
102		# Ignore changes that aren't for episodes
103		continue
104
105		if data == SyncData.Watchlist:
106		# Ignore watchlist data
107		continue
108
109		if not self.is_data_enabled(data):
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `is_data_enabled`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
110		# Data type has been disabled
111		continue
112
113		data_name = Cache.Data.get(data)
114
115		if data_name not in result.changes:
116		# No changes for collection
117		continue
118
119		for action, shows in result.changes[data_name].items():
120		t_show = shows.get(pk)
121
122		if t_show is None:
123		# Unable to find matching show in trakt data
124		continue
125
126		# Execute show handlers
127		self.execute_handlers(
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `execute_handlers`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
128		SyncMedia.Shows, data,
129		action=action,
130
131		key=sh_id,
132
133		p_item=p_show,
134		t_item=t_show
135		)
136
137		# Stop progress group
138		self.current.progress.group(Shows, 'shows').stop()
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
139
140		with elapsed.clock(Shows, 'run:episodes'):
141		# Process episodes
142		for ids, guid, (season_num, episode_num), p_show, p_season, p_episode in self.p_episodes:
		0 ignored issues – show Unused Code introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The variable `p_season` seems to be unused. Loading history...
143		# Increment one step
144		self.current.progress.group(Shows, 'episodes').step()
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
145
146		# Ensure `guid` is available
147		if not guid or guid.agent not in GUID_AGENTS:
148		mark_unsupported(self.p_shows_unsupported, ids['show'], guid, p_show)
149		continue
150
151		key = (guid.agent, guid.sid)
152
153		log.debug('Processing episode: %s - S%02dE%02d', key, season_num, episode_num)
154
155		# Try retrieve `pk` for `key`
156		pk = self.trakt.table.get(key)
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `trakt`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
157
158		if pk is None:
159		# No `pk` found
160		continue
161
162		if not ids.get('episode'):
163		# Missing `episode` rating key
164		continue
165
166		for key, result in self.trakt.changes:
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `trakt`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
167		media, data = key[0:2]
168
169		if media != SyncMedia.Episodes:
170		# Ignore changes that aren't for episodes
171		continue
172
173		if not self.is_data_enabled(data):
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `is_data_enabled`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
174		# Data type has been disabled
175		continue
176
177		data_name = Cache.Data.get(data)
178
179		if data_name not in result.changes:
180		# No changes for collection
181		continue
182
183		for action, shows in result.changes[data_name].items():
184		t_show = shows.get(pk)
185
186		if t_show is None:
187		# Unable to find matching show in trakt data
188		continue
189
190		t_season = t_show.get('seasons', {}).get(season_num)
191
192		if t_season is None:
193		# Unable to find matching season in `t_show`
194		continue
195
196		t_episode = t_season.get('episodes', {}).get(episode_num)
197
198		if t_episode is None:
199		# Unable to find matching episode in `t_season`
200		continue
201
202		self.execute_handlers(
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `execute_handlers`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
203		SyncMedia.Episodes, data,
204		action=action,
205		key=ids['episode'],
206
207		p_item=p_episode,
208		t_item=t_episode
209		)
210
211		# Task checkpoint
212		self.checkpoint()
		0 ignored issues – show Bug introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `checkpoint`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
213
214		# Stop progress group
215		self.current.progress.group(Shows, 'episodes').stop()
		0 ignored issues – show Bug introduced 2016-01-17 02:06 UTC by Report Bug Copy Issue Report The Instance of `Shows` does not seem to have a member named `current`. This check looks for calls to members that are non-existent. These calls will fail. The member could have been renamed or removed. Loading history...
216
217		# Log details
218		log_unsupported(log, 'Found %d unsupported show(s)\n%s', self.p_shows_unsupported)
219

fuzeman / Plex-Trakt-Scrobbler

Push — develop ( e459d6...12ef70 )

Shows.run() F

Complexity

Size

Duplication

Code Coverage

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like