ClientRuleService.update()

Complexity

Conditions

10

Size

Total Lines

51

Duplication

Lines	51
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	110

from plugin.api.core.base import Service, expose
    @expose
    def update(self, current, full=False):

This method could be written as a function/class method.

        result = []

        # Build array of current ids
        current_ids = [
            r.get('id')
            for r in current
            if r.get('id') is not None
        ]

        # Delete rules
        deleted_rules = [
            rule
            for rule in ClientRuleManager.get.all()

It seems like a value for argument self is missing in the unbound method call.

            if rule.id not in current_ids
        ]

        for rule in deleted_rules:
            rule.delete_instance()

            log.debug('Deleted %r', rule)

        # Create/Update client rules
        for r in current:
            id = r.pop('id', None)

This seems to re-define the built-in id.

            if id is None:
                # Create new rule
                rule = ClientRuleManager.create(**r)

The Class ClientRuleManager does not seem to have a member named create.

                log.debug('Created %r', rule)
                result.append(rule)
                continue

            # Retrieve existing rule
            rule = ClientRuleManager.get(id=id)

            # Update rule
            ClientRuleManager.update(rule, r)

The Class ClientRuleManager does not seem to have a member named update.

            log.debug('Updated %r', rule)
            result.append(rule)

        # Ensure result is sorted by priority
        result = sorted(result, key=lambda item: item.priority)

        # Convert rules to serializable dictionaries
        return [
            r.to_json(full=full)
            for r in result
        ]