ClientRuleService.update() - Code Metrics - fuzeman/Plex-Trakt-Scrobbler - Measure and Improve Code Quality continuously with Scrutinizer

ClientRuleService.update() D
last analyzed 2018-03-05 01:11 UTC

↳ Parent: ClientRuleService

Complexity

Conditions

Size

Total Lines

Duplication

Lines	51
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

Metric	Value
dl	51
loc	51
ccs	0
cts	21
cp	0
rs	4.2352
c	0
b	0
f	0
cc	10
crap	110

How to fix Long Method Complexity

from plugin.api.core.base import Service, expose
from plugin.managers.client import ClientManager
from plugin.managers.client_rule import ClientRuleManager

import logging

log = logging.getLogger(__name__)


class ClientService(Service):
    __key__ = 'session.client'

    @expose
    def list(self, full=False):
class Foo:
    def some_method(self, x, y):
        return x + y;
        return [
            client.to_json(full=full)
            for client in ClientManager.get.all()
        ]


class ClientRuleService(Service):

    __key__ = 'session.client.rule'

    @expose
    def list(self, full=False):
class Foo:
    def some_method(self, x, y):
        return x + y;
        return [
            rule.to_json(full=full)
            for rule in ClientRuleManager.get.all()
        ]

    @expose
    def update(self, current, full=False):
class Foo:
    def some_method(self, x, y):
        return x + y;
        result = []

        # Build array of current ids
        current_ids = [
            r.get('id')
            for r in current
            if r.get('id') is not None
        ]

        # Delete rules
        deleted_rules = [
            rule
            for rule in ClientRuleManager.get.all()
            if rule.id not in current_ids
        ]

        for rule in deleted_rules:
            rule.delete_instance()

            log.debug('Deleted %r', rule)

        # Create/Update client rules
        for r in current:
            id = r.pop('id', None)


            if id is None:
                # Create new rule
                rule = ClientRuleManager.create(**r)

                log.debug('Created %r', rule)
                result.append(rule)
                continue

            # Retrieve existing rule
            rule = ClientRuleManager.get(id=id)

            # Update rule
            ClientRuleManager.update(rule, r)

            log.debug('Updated %r', rule)
            result.append(rule)

        # Ensure result is sorted by priority
        result = sorted(result, key=lambda item: item.priority)

        # Convert rules to serializable dictionaries
        return [
            r.to_json(full=full)
            for r in result
        ]


1		from plugin.api.core.base import Service, expose
2		from plugin.managers.client import ClientManager
3		from plugin.managers.client_rule import ClientRuleManager
4
5		import logging
6
7		log = logging.getLogger(__name__)
8
9
10		class ClientService(Service):
11		__key__ = 'session.client'
12
13		@expose
14		def list(self, full=False):
		0 ignored issues – show Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
15		return [
16		client.to_json(full=full)
17		for client in ClientManager.get.all()
18		]
19
20
21	View Code Duplication	class ClientRuleService(Service):
		0 ignored issues – show Duplication introduced 2016-05-19 03:26 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
22		__key__ = 'session.client.rule'
23
24		@expose
25		def list(self, full=False):
		0 ignored issues – show Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
26		return [
27		rule.to_json(full=full)
28		for rule in ClientRuleManager.get.all()
29		]
30
31		@expose
32		def update(self, current, full=False):
		0 ignored issues – show Coding Style introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
33		result = []
34
35		# Build array of current ids
36		current_ids = [
37		r.get('id')
38		for r in current
39		if r.get('id') is not None
40		]
41
42		# Delete rules
43		deleted_rules = [
44		rule
45		for rule in ClientRuleManager.get.all()
46		if rule.id not in current_ids
47		]
48
49		for rule in deleted_rules:
50		rule.delete_instance()
51
52		log.debug('Deleted %r', rule)
53
54		# Create/Update client rules
55		for r in current:
56		id = r.pop('id', None)
		0 ignored issues – show Bug Best Practice introduced 2015-12-19 01:32 UTC by Report Bug Copy Issue Report This seems to re-define the built-in `id`. It is generally discouraged to redefine built-ins as this makes code very hard to read. Loading history...
57
58		if id is None:
59		# Create new rule
60		rule = ClientRuleManager.create(**r)
61
62		log.debug('Created %r', rule)
63		result.append(rule)
64		continue
65
66		# Retrieve existing rule
67		rule = ClientRuleManager.get(id=id)
68
69		# Update rule
70		ClientRuleManager.update(rule, r)
71
72		log.debug('Updated %r', rule)
73		result.append(rule)
74
75		# Ensure result is sorted by priority
76		result = sorted(result, key=lambda item: item.priority)
77
78		# Convert rules to serializable dictionaries
79		return [
80		r.to_json(full=full)
81		for r in result
82		]
83

fuzeman / Plex-Trakt-Scrobbler

ClientRuleService.update() D last analyzed 2018-03-05 01:11 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like

ClientRuleService.update() D
last analyzed 2018-03-05 01:11 UTC