Issues in autoptimizeVersionUpdatesHandler.php (master) - Issues in master - futtta/autoptimize - Measure and Improve Code Quality continuously with Scrutinizer

Issues (280)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/autoptimizeVersionUpdatesHandler.php (5 issues)

Labels

Severity

Major 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Handles version updates and should only be instantiated in autoptimize.php if/when needed.
 */

if ( ! defined( 'ABSPATH' ) ) {
    exit;
}

class autoptimizeVersionUpdatesHandler
{
    /**
     * The current major version string.
     *
     * @var string
     */
    protected $current_major_version = null;

    public function __construct( $current_version )
    {
        $this->current_major_version = substr( $current_version, 0, 3 );
    }

    /**
     * Runs all needed upgrade procedures (depending on the
     * current major version specified during class instantiation)
     */
    public function run_needed_major_upgrades()
    {
        $major_update = false;

        switch ( $this->current_major_version ) {
            case '1.6':
                $this->upgrade_from_1_6();
                $major_update = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                // No break, intentionally, so all upgrades are ran during a single request...
            case '1.7':
                $this->upgrade_from_1_7();
                $major_update = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                // No break, intentionally, so all upgrades are ran during a single request...
            case '1.9':
                $this->upgrade_from_1_9();
                $major_update = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                // No break, intentionally, so all upgrades are ran during a single request...
            case '2.2':
                $this->upgrade_from_2_2();
                $major_update = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                // No break, intentionally, so all upgrades are ran during a single request...
            case '2.4':
                if ( autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' ) == '2.4.2' ) {
                    $this->upgrade_from_2_4_2();
                }
                $this->upgrade_from_2_4();
                $major_update = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                // No break, intentionally, so all upgrades are ran during a single request...
            case '2.7':
                $this->upgrade_from_2_7();
                $major_update = true;
                // No break, intentionally, so all upgrades are ran during a single request...
        }

        if ( true === $major_update ) {
            $this->on_major_version_update();
        }
    }

    /**
     * Checks specified version against the one stored in the database under `autoptimize_version` and performs
     * any major upgrade routines if needed.
     * Updates the database version to the specified $target if it's different to the one currently stored there.
     *
     * @param string $target Target version to check against (ie., the currently running one).
     */
    public static function check_installed_and_update( $target )
    {
        $db_version = autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' );
        if ( $db_version !== $target ) {
            if ( 'none' === $db_version ) {
                add_action( 'admin_notices', 'autoptimizeMain::notice_installed' );
            } else {
                $updater = new self( $db_version );
                $updater->run_needed_major_upgrades();
            }

            // Versions differed, upgrades happened if needed, store the new version.
            autoptimizeOptionWrapper::update_option( 'autoptimize_version', $target );
        }
    }

    /**
     * Called after any major version update (and it's accompanying upgrade procedure)
     * has happened. Clears cache and sets an admin notice.
     */
    protected function on_major_version_update()
    {
        // The transients guard here prevents stale object caches from busting the cache on every request.
        if ( false == get_transient( 'autoptimize_stale_option_buster' ) ) {
            set_transient( 'autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS );
            autoptimizeCache::clearall();
            add_action( 'admin_notices', 'autoptimizeMain::notice_updated' );
        }
    }

    /**
     * From back in the days when I did not yet consider multisite.
     */
    private function upgrade_from_1_6()
    {
        // If user was on version 1.6.x, force advanced options to be shown by default.
        autoptimizeOptionWrapper::update_option( 'autoptimize_show_adv', '1' );

        // And remove old options.
        $to_delete_options = array(
            'autoptimize_cdn_css',
            'autoptimize_cdn_css_url',
            'autoptimize_cdn_js',
            'autoptimize_cdn_js_url',
            'autoptimize_cdn_img',
            'autoptimize_cdn_img_url',
            'autoptimize_css_yui',
        );
        foreach ( $to_delete_options as $del_opt ) {
            delete_option( $del_opt );
        }
    }

    /**
     * Forces WP 3.8 dashicons in CSS exclude options when upgrading from 1.7 to 1.8
     *
     * @global $wpdb
     */
    private function upgrade_from_1_7()
    {
        if ( ! is_multisite() ) {
            $css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' );
            if ( empty( $css_exclude ) ) {
                $css_exclude = 'admin-bar.min.css, dashicons.min.css';
            } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
                $css_exclude .= ', dashicons.min.css';
            }
            autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude );
        } else {
            global $wpdb;
            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
            $original_blog_id = get_current_blog_id();
            foreach ( $blog_ids as $blog_id ) {
                switch_to_blog( $blog_id );
                $css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' );
                if ( empty( $css_exclude ) ) {
                    $css_exclude = 'admin-bar.min.css, dashicons.min.css';
                } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
                    $css_exclude .= ', dashicons.min.css';
                }
                autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude );
            }
            switch_to_blog( $original_blog_id );
        }
    }

    /**
     * 2.0 will not aggregate inline CSS/JS by default, but we want users
     * upgrading from 1.9 to keep their inline code aggregated by default.
     *
     * @global $wpdb
     */
    private function upgrade_from_1_9()
    {
        if ( ! is_multisite() ) {
            autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' );
            autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' );
        } else {
            global $wpdb;
            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
            $original_blog_id = get_current_blog_id();
            foreach ( $blog_ids as $blog_id ) {
                switch_to_blog( $blog_id );
                autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' );
                autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' );
            }
            switch_to_blog( $original_blog_id );
        }
    }

    /**
     * 2.3 has no "remove google fonts" in main screen, moved to "extra"
     *
     * @global $wpdb
     */
    private function upgrade_from_2_2()
    {
        if ( ! is_multisite() ) {
            $this->do_2_2_settings_update();
        } else {
            global $wpdb;
            $blog_ids         = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
            $original_blog_id = get_current_blog_id();
            foreach ( $blog_ids as $blog_id ) {
                switch_to_blog( $blog_id );
                $this->do_2_2_settings_update();
            }
            switch_to_blog( $original_blog_id );
        }
    }

    /**
     * Helper for 2.2 autoptimize_extra_settings upgrade to avoid duplicate code
     */
    private function do_2_2_settings_update()
    {
        $nogooglefont    = autoptimizeOptionWrapper::get_option( 'autoptimize_css_nogooglefont', '' );
        $ao_extrasetting = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' );
        if ( ( $nogooglefont ) && ( empty( $ao_extrasetting ) ) ) {
            autoptimizeOptionWrapper::update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() );
        }
        delete_option( 'autoptimize_css_nogooglefont' );
    }

    /**
     * 2.4.2 introduced too many cronned ao_cachecheckers, make this right
     */
    private function upgrade_from_2_4_2() {
        // below code by Thomas Sjolshagen (http://eighty20results.com/)
        // as found on https://www.paidmembershipspro.com/deleting-oldextra-cron-events/.
        $jobs = _get_cron_array();

        // Remove all ao_cachechecker cron jobs (for now).
        foreach ( $jobs as $when => $job ) {
            $name = key( $job );

            if ( false !== strpos( $name, 'ao_cachechecker' ) ) {
                unset( $jobs[ $when ] );
            }
        }

        // Save the data.
        _set_cron_array( $jobs );
    }

    /**
     * Migrate imgopt options from autoptimize_extra_settings to autoptimize_imgopt_settings
     */
    private function upgrade_from_2_4() {
        $extra_settings  = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' );
        $imgopt_settings = autoptimizeOptionWrapper::get_option( 'autoptimize_imgopt_settings', '' );
        if ( empty( $imgopt_settings ) && ! empty( $extra_settings ) ) {
            $imgopt_settings = autoptimizeConfig::get_ao_imgopt_default_options();
            if ( array_key_exists( 'autoptimize_extra_checkbox_field_5', $extra_settings ) ) {
                $imgopt_settings['autoptimize_imgopt_checkbox_field_1'] = $extra_settings['autoptimize_extra_checkbox_field_5'];
            }
            if ( array_key_exists( 'autoptimize_extra_select_field_6', $extra_settings ) ) {
                $imgopt_settings['autoptimize_imgopt_select_field_2'] = $extra_settings['autoptimize_extra_select_field_6'];
            }
            autoptimizeOptionWrapper::update_option( 'autoptimize_imgopt_settings', $imgopt_settings );
        }
    }

    /**
     * remove CCSS request limit option + update jquery exclusion to include WordPress 5.6 jquery.min.js.
     */    
    private function upgrade_from_2_7() {
        delete_option( 'autoptimize_ccss_rlimit' );
        $js_exclusions = get_option( 'autoptimize_js_exclude', '' );
        if ( strpos( $js_exclusions, 'js/jquery/jquery.js' ) !== false && strpos( $js_exclusions, 'js/jquery/jquery.min.js' ) === false ) {
            $js_exclusions .= ', js/jquery/jquery.min.js';
            update_option( 'autoptimize_js_exclude', $js_exclusions );
        }
    }
}


1		<?php
2		/**
3		* Handles version updates and should only be instantiated in autoptimize.php if/when needed.
4		*/
5
6		if ( ! defined( 'ABSPATH' ) ) {
7		exit;
8		}
9
10		class autoptimizeVersionUpdatesHandler
11		{
12		/**
13		* The current major version string.
14		*
15		* @var string
16		*/
17		protected $current_major_version = null;
18
19		public function __construct( $current_version )
20		{
21		$this->current_major_version = substr( $current_version, 0, 3 );
22		}
23
24		/**
25		* Runs all needed upgrade procedures (depending on the
26		* current major version specified during class instantiation)
27		*/
28		public function run_needed_major_upgrades()
29		{
30		$major_update = false;
31
32		switch ( $this->current_major_version ) {
33		case '1.6':
34		$this->upgrade_from_1_6();
35		$major_update = true;
		0 ignored issues – show Unused Code introduced 2018-10-07 12:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$major_update` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
36		// No break, intentionally, so all upgrades are ran during a single request...
37		case '1.7':
38		$this->upgrade_from_1_7();
39		$major_update = true;
		0 ignored issues – show Unused Code introduced 2018-10-07 12:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$major_update` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
40		// No break, intentionally, so all upgrades are ran during a single request...
41		case '1.9':
42		$this->upgrade_from_1_9();
43		$major_update = true;
		0 ignored issues – show Unused Code introduced 2018-10-07 12:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$major_update` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
44		// No break, intentionally, so all upgrades are ran during a single request...
45		case '2.2':
46		$this->upgrade_from_2_2();
47		$major_update = true;
		0 ignored issues – show Unused Code introduced 2018-12-02 19:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$major_update` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
48		// No break, intentionally, so all upgrades are ran during a single request...
49		case '2.4':
50		if ( autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' ) == '2.4.2' ) {
51		$this->upgrade_from_2_4_2();
52		}
53		$this->upgrade_from_2_4();
54		$major_update = false;
		0 ignored issues – show Unused Code introduced 2020-12-10 12:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$major_update` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55		// No break, intentionally, so all upgrades are ran during a single request...
56		case '2.7':
57		$this->upgrade_from_2_7();
58		$major_update = true;
59		// No break, intentionally, so all upgrades are ran during a single request...
60		}
61
62		if ( true === $major_update ) {
63		$this->on_major_version_update();
64		}
65		}
66
67		/**
68		* Checks specified version against the one stored in the database under `autoptimize_version` and performs
69		* any major upgrade routines if needed.
70		* Updates the database version to the specified $target if it's different to the one currently stored there.
71		*
72		* @param string $target Target version to check against (ie., the currently running one).
73		*/
74		public static function check_installed_and_update( $target )
75		{
76		$db_version = autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' );
77		if ( $db_version !== $target ) {
78		if ( 'none' === $db_version ) {
79		add_action( 'admin_notices', 'autoptimizeMain::notice_installed' );
80		} else {
81		$updater = new self( $db_version );
82		$updater->run_needed_major_upgrades();
83		}
84
85		// Versions differed, upgrades happened if needed, store the new version.
86		autoptimizeOptionWrapper::update_option( 'autoptimize_version', $target );
87		}
88		}
89
90		/**
91		* Called after any major version update (and it's accompanying upgrade procedure)
92		* has happened. Clears cache and sets an admin notice.
93		*/
94		protected function on_major_version_update()
95		{
96		// The transients guard here prevents stale object caches from busting the cache on every request.
97		if ( false == get_transient( 'autoptimize_stale_option_buster' ) ) {
98		set_transient( 'autoptimize_stale_option_buster', 'Mamsie & Liessie zehhe: ZWIJH!', HOUR_IN_SECONDS );
99		autoptimizeCache::clearall();
100		add_action( 'admin_notices', 'autoptimizeMain::notice_updated' );
101		}
102		}
103
104		/**
105		* From back in the days when I did not yet consider multisite.
106		*/
107		private function upgrade_from_1_6()
108		{
109		// If user was on version 1.6.x, force advanced options to be shown by default.
110		autoptimizeOptionWrapper::update_option( 'autoptimize_show_adv', '1' );
111
112		// And remove old options.
113		$to_delete_options = array(
114		'autoptimize_cdn_css',
115		'autoptimize_cdn_css_url',
116		'autoptimize_cdn_js',
117		'autoptimize_cdn_js_url',
118		'autoptimize_cdn_img',
119		'autoptimize_cdn_img_url',
120		'autoptimize_css_yui',
121		);
122		foreach ( $to_delete_options as $del_opt ) {
123		delete_option( $del_opt );
124		}
125		}
126
127		/**
128		* Forces WP 3.8 dashicons in CSS exclude options when upgrading from 1.7 to 1.8
129		*
130		* @global $wpdb
131		*/
132		private function upgrade_from_1_7()
133		{
134		if ( ! is_multisite() ) {
135		$css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' );
136	View Code Duplication	if ( empty( $css_exclude ) ) {
137		$css_exclude = 'admin-bar.min.css, dashicons.min.css';
138		} elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
139		$css_exclude .= ', dashicons.min.css';
140		}
141		autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude );
142		} else {
143		global $wpdb;
144		$blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
145		$original_blog_id = get_current_blog_id();
146		foreach ( $blog_ids as $blog_id ) {
147		switch_to_blog( $blog_id );
148		$css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' );
149	View Code Duplication	if ( empty( $css_exclude ) ) {
150		$css_exclude = 'admin-bar.min.css, dashicons.min.css';
151		} elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) {
152		$css_exclude .= ', dashicons.min.css';
153		}
154		autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude );
155		}
156		switch_to_blog( $original_blog_id );
157		}
158		}
159
160		/**
161		* 2.0 will not aggregate inline CSS/JS by default, but we want users
162		* upgrading from 1.9 to keep their inline code aggregated by default.
163		*
164		* @global $wpdb
165		*/
166		private function upgrade_from_1_9()
167		{
168		if ( ! is_multisite() ) {
169		autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' );
170		autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' );
171		} else {
172		global $wpdb;
173		$blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
174		$original_blog_id = get_current_blog_id();
175		foreach ( $blog_ids as $blog_id ) {
176		switch_to_blog( $blog_id );
177		autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' );
178		autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' );
179		}
180		switch_to_blog( $original_blog_id );
181		}
182		}
183
184		/**
185		* 2.3 has no "remove google fonts" in main screen, moved to "extra"
186		*
187		* @global $wpdb
188		*/
189		private function upgrade_from_2_2()
190		{
191		if ( ! is_multisite() ) {
192		$this->do_2_2_settings_update();
193		} else {
194		global $wpdb;
195		$blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
196		$original_blog_id = get_current_blog_id();
197		foreach ( $blog_ids as $blog_id ) {
198		switch_to_blog( $blog_id );
199		$this->do_2_2_settings_update();
200		}
201		switch_to_blog( $original_blog_id );
202		}
203		}
204
205		/**
206		* Helper for 2.2 autoptimize_extra_settings upgrade to avoid duplicate code
207		*/
208		private function do_2_2_settings_update()
209		{
210		$nogooglefont = autoptimizeOptionWrapper::get_option( 'autoptimize_css_nogooglefont', '' );
211		$ao_extrasetting = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' );
212		if ( ( $nogooglefont ) && ( empty( $ao_extrasetting ) ) ) {
213		autoptimizeOptionWrapper::update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() );
214		}
215		delete_option( 'autoptimize_css_nogooglefont' );
216		}
217
218		/**
219		* 2.4.2 introduced too many cronned ao_cachecheckers, make this right
220		*/
221		private function upgrade_from_2_4_2() {
222		// below code by Thomas Sjolshagen (http://eighty20results.com/)
223		// as found on https://www.paidmembershipspro.com/deleting-oldextra-cron-events/.
224		$jobs = _get_cron_array();
225
226		// Remove all ao_cachechecker cron jobs (for now).
227		foreach ( $jobs as $when => $job ) {
228		$name = key( $job );
229
230		if ( false !== strpos( $name, 'ao_cachechecker' ) ) {
231		unset( $jobs[ $when ] );
232		}
233		}
234
235		// Save the data.
236		_set_cron_array( $jobs );
237		}
238
239		/**
240		* Migrate imgopt options from autoptimize_extra_settings to autoptimize_imgopt_settings
241		*/
242		private function upgrade_from_2_4() {
243		$extra_settings = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' );
244		$imgopt_settings = autoptimizeOptionWrapper::get_option( 'autoptimize_imgopt_settings', '' );
245		if ( empty( $imgopt_settings ) && ! empty( $extra_settings ) ) {
246		$imgopt_settings = autoptimizeConfig::get_ao_imgopt_default_options();
247		if ( array_key_exists( 'autoptimize_extra_checkbox_field_5', $extra_settings ) ) {
248		$imgopt_settings['autoptimize_imgopt_checkbox_field_1'] = $extra_settings['autoptimize_extra_checkbox_field_5'];
249		}
250		if ( array_key_exists( 'autoptimize_extra_select_field_6', $extra_settings ) ) {
251		$imgopt_settings['autoptimize_imgopt_select_field_2'] = $extra_settings['autoptimize_extra_select_field_6'];
252		}
253		autoptimizeOptionWrapper::update_option( 'autoptimize_imgopt_settings', $imgopt_settings );
254		}
255		}
256
257		/**
258		* remove CCSS request limit option + update jquery exclusion to include WordPress 5.6 jquery.min.js.
259		*/
260		private function upgrade_from_2_7() {
261		delete_option( 'autoptimize_ccss_rlimit' );
262		$js_exclusions = get_option( 'autoptimize_js_exclude', '' );
263		if ( strpos( $js_exclusions, 'js/jquery/jquery.js' ) !== false && strpos( $js_exclusions, 'js/jquery/jquery.min.js' ) === false ) {
264		$js_exclusions .= ', js/jquery/jquery.min.js';
265		update_option( 'autoptimize_js_exclude', $js_exclusions );
266		}
267		}
268		}
269

futtta / autoptimize

Issues (280)

Security Analysis not enabled

classes/autoptimizeVersionUpdatesHandler.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like