Issues in autoptimize.php - All Issues - Inspection of "Merge pull request #88 from zytzagoo/fix-toolbar-c..." - futtta/autoptimize - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cacc24...b5e696 )

by frank

created 2017-03-06 14:45 UTC

autoptimize.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
Plugin Name: Autoptimize
Plugin URI: http://blog.futtta.be/autoptimize
Description: Optimizes your website, concatenating the CSS and JavaScript code, and compressing it.
Version: 2.1.0
Author: Frank Goossens (futtta)
Author URI: http://blog.futtta.be/
Domain Path: localization/
Text Domain: autoptimize
Released under the GNU General Public License (GPL)
http://www.gnu.org/licenses/gpl.txt
*/

if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly

define('AUTOPTIMIZE_PLUGIN_DIR',plugin_dir_path(__FILE__));

// Load config class
include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeConfig.php');

// Load toolbar class
include( AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeToolbar.php' );

// Load partners tab if admin
if (is_admin()) {
    include AUTOPTIMIZE_PLUGIN_DIR.'classlesses/autoptimizePartners.php';
}

// Do we gzip when caching (needed early to load autoptimizeCache.php)
define('AUTOPTIMIZE_CACHE_NOGZIP',(bool) get_option('autoptimize_cache_nogzip'));

// Load cache class
include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeCache.php');

// wp-content dir name (automagically set, should not be needed), dirname of AO cache dir and AO-prefix can be overridden in wp-config.php
if (!defined('AUTOPTIMIZE_WP_CONTENT_NAME')) { define('AUTOPTIMIZE_WP_CONTENT_NAME','/'.wp_basename( WP_CONTENT_DIR )); }
if (!defined('AUTOPTIMIZE_CACHE_CHILD_DIR')) { define('AUTOPTIMIZE_CACHE_CHILD_DIR','/cache/autoptimize/'); }
if (!defined('AUTOPTIMIZE_CACHEFILE_PREFIX')) { define('AUTOPTIMIZE_CACHEFILE_PREFIX', 'autoptimize_'); }

// Plugin dir constants (plugin url's defined later to accomodate domain mapped sites)
if (is_multisite() && apply_filters( 'autoptimize_separate_blog_caches' , true )) {

    $blog_id = get_current_blog_id();
    define('AUTOPTIMIZE_CACHE_DIR', WP_CONTENT_DIR.AUTOPTIMIZE_CACHE_CHILD_DIR.$blog_id.'/' );
} else {
    define('AUTOPTIMIZE_CACHE_DIR', WP_CONTENT_DIR.AUTOPTIMIZE_CACHE_CHILD_DIR);
}
define('AUTOPTIMIZE_CACHE_DELAY',true);
define('WP_ROOT_DIR',str_replace(AUTOPTIMIZE_WP_CONTENT_NAME,'',WP_CONTENT_DIR));

// Initialize the cache at least once
$conf = autoptimizeConfig::instance();

/* Check if we're updating, in which case we might need to do stuff and flush the cache
to avoid old versions of aggregated files lingering around */

$autoptimize_version="2.1.0";
$autoptimize_db_version=get_option('autoptimize_version','none');

if ($autoptimize_db_version !== $autoptimize_version) {
    if ($autoptimize_db_version==="none") {
        add_action('admin_notices', 'autoptimize_install_config_notice');
    } else {
        // updating, include the update-code
        include(AUTOPTIMIZE_PLUGIN_DIR.'classlesses/autoptimizeUpdateCode.php');
    }

    update_option('autoptimize_version',$autoptimize_version);
    $autoptimize_db_version=$autoptimize_version;
}

// Load translations
function autoptimize_load_plugin_textdomain() {
    load_plugin_textdomain('autoptimize',false,plugin_basename(dirname( __FILE__ )).'/localization');
}
add_action( 'init', 'autoptimize_load_plugin_textdomain' );

function autoptimize_uninstall(){
    autoptimizeCache::clearall();

    $delete_options=array("autoptimize_cache_clean", "autoptimize_cache_nogzip", "autoptimize_css", "autoptimize_css_datauris", "autoptimize_css_justhead", "autoptimize_css_defer", "autoptimize_css_defer_inline", "autoptimize_css_inline", "autoptimize_css_exclude", "autoptimize_html", "autoptimize_html_keepcomments", "autoptimize_js", "autoptimize_js_exclude", "autoptimize_js_forcehead", "autoptimize_js_justhead", "autoptimize_js_trycatch", "autoptimize_version", "autoptimize_show_adv", "autoptimize_cdn_url", "autoptimize_cachesize_notice","autoptimize_css_include_inline","autoptimize_js_include_inline","autoptimize_css_nogooglefont");

    if ( !is_multisite() ) {
        foreach ($delete_options as $del_opt) {    delete_option( $del_opt ); }
    } else {
        global $wpdb;
        $blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
        $original_blog_id = get_current_blog_id();
        foreach ( $blog_ids as $blog_id ) {
            switch_to_blog( $blog_id );
            foreach ($delete_options as $del_opt) {    delete_option( $del_opt ); }
        }
        switch_to_blog( $original_blog_id );
    }

    if ( wp_get_schedule( 'ao_cachechecker' ) ) {
        wp_clear_scheduled_hook( 'ao_cachechecker' );
    }
}

function autoptimize_install_config_notice() {
    echo '<div class="updated"><p>';
    _e('Thank you for installing and activating Autoptimize. Please configure it under "Settings" -> "Autoptimize" to start improving your site\'s performance.', 'autoptimize' );
    echo '</p></div>';
}

function autoptimize_update_config_notice() {
    echo '<div class="updated"><p>';
    _e('Autoptimize has just been updated. Please <strong>test your site now</strong> and adapt Autoptimize config if needed.', 'autoptimize' );
    echo '</p></div>';
}

function autoptimize_cache_unavailable_notice() {
    echo '<div class="error"><p>';
    printf( __( 'Autoptimize cannot write to the cache directory (%s), please fix to enable CSS/ JS optimization!', 'autoptimize' ), AUTOPTIMIZE_CACHE_DIR );
    echo '</p></div>';
}

// Set up the buffering
function autoptimize_start_buffering() {
    $ao_noptimize = false;

    // noptimize in qs to get non-optimized page for debugging
    if (array_key_exists("ao_noptimize",$_GET)) {
        if ( ($_GET["ao_noptimize"]==="1") && (apply_filters('autoptimize_filter_honor_qs_noptimize',true)) ) {
            $ao_noptimize = true;
        }
    }

    // check for DONOTMINIFY constant as used by e.g. WooCommerce POS
    if (defined('DONOTMINIFY') && (constant('DONOTMINIFY')===true || constant('DONOTMINIFY')==="true")) {
        $ao_noptimize = true;
    }

    // filter you can use to block autoptimization on your own terms
    $ao_noptimize = (bool) apply_filters( 'autoptimize_filter_noptimize', $ao_noptimize );

    if (!is_feed() && !$ao_noptimize && !is_admin() && ( !function_exists('is_customize_preview') || !is_customize_preview() ) ) {
        // Config element
        $conf = autoptimizeConfig::instance();

        // Load our base class
        include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeBase.php');

        // Load extra classes and set some vars
        if($conf->get('autoptimize_html')) {
            include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeHTML.php');
            // BUG: new minify-html does not support keeping HTML comments, skipping for now
            // if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {

                @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-html.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            // } else {

            //    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-2.1.7-html.php');
            // }
        }

        if($conf->get('autoptimize_js')) {

            include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeScripts.php');
            if (!class_exists('JSMin')) {
                if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {
                    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/jsmin-1.1.1.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                } else {
                    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-2.3.1-jsmin.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                }
            }
            if ( ! defined( 'CONCATENATE_SCRIPTS' )) {
                define('CONCATENATE_SCRIPTS',false);
            }
            if ( ! defined( 'COMPRESS_SCRIPTS' )) {
                define('COMPRESS_SCRIPTS',false);
            }
        }

        if($conf->get('autoptimize_css')) {

            include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeStyles.php');
            if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {
                if (!class_exists('Minify_CSS_Compressor')) {
                    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-css-compressor.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                }
            } else {
                if (!class_exists('CSSmin')) {
                    @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/yui-php-cssmin-2.4.8-4_fgo.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                }
            }
            if ( ! defined( 'COMPRESS_CSS' )) {
                define('COMPRESS_CSS',false);
            }
        }

        // filter to be used with care, kills all output buffers when true. use with extreme caution. you have been warned!
        if (apply_filters('autoptimize_filter_obkiller',false)) {
            while (ob_get_level() > 0) {
                ob_end_clean();
            }
        }
                
        // Now, start the real thing!
        ob_start('autoptimize_end_buffering');
    }
}

// Action on end, this is where the magic happens
function autoptimize_end_buffering($content) {
    if ( ((stripos($content,"<html") === false) && (stripos($content,"<!DOCTYPE html") === false)) || preg_match('/<html[^>]*(?:amp|⚡)/',$content) === 1 || stripos($content,"<xsl:stylesheet") !== false ) { return $content; }
    
    // load URL constants as late as possible to allow domain mapper to kick in
    if (function_exists("domain_mapping_siteurl")) {
        define('AUTOPTIMIZE_WP_SITE_URL',domain_mapping_siteurl(get_current_blog_id()));
        define('AUTOPTIMIZE_WP_CONTENT_URL',str_replace(get_original_url(AUTOPTIMIZE_WP_SITE_URL),AUTOPTIMIZE_WP_SITE_URL,content_url()));
    } else {
        define('AUTOPTIMIZE_WP_SITE_URL',site_url());
        define('AUTOPTIMIZE_WP_CONTENT_URL',content_url());
    }

    if ( is_multisite() && apply_filters( 'autoptimize_separate_blog_caches' , true ) ) {

        $blog_id = get_current_blog_id();
        define('AUTOPTIMIZE_CACHE_URL',AUTOPTIMIZE_WP_CONTENT_URL.AUTOPTIMIZE_CACHE_CHILD_DIR.$blog_id.'/' );
    } else {
        define('AUTOPTIMIZE_CACHE_URL',AUTOPTIMIZE_WP_CONTENT_URL.AUTOPTIMIZE_CACHE_CHILD_DIR);
    }
    define('AUTOPTIMIZE_WP_ROOT_URL',str_replace(AUTOPTIMIZE_WP_CONTENT_NAME,'',AUTOPTIMIZE_WP_CONTENT_URL));

    // Config element
    $conf = autoptimizeConfig::instance();

    // Choose the classes
    $classes = array();
    if($conf->get('autoptimize_js'))
        $classes[] = 'autoptimizeScripts';
    if($conf->get('autoptimize_css'))
        $classes[] = 'autoptimizeStyles';
    if($conf->get('autoptimize_html'))
        $classes[] = 'autoptimizeHTML';

    // Set some options
    $classoptions = array(
        'autoptimizeScripts' => array(
            'justhead' => $conf->get('autoptimize_js_justhead'),
            'forcehead' => $conf->get('autoptimize_js_forcehead'),
            'trycatch' => $conf->get('autoptimize_js_trycatch'),
            'js_exclude' => $conf->get('autoptimize_js_exclude'),
            'cdn_url' => $conf->get('autoptimize_cdn_url'),
            'include_inline' => $conf->get('autoptimize_js_include_inline')
        ),
        'autoptimizeStyles' => array(
            'justhead' => $conf->get('autoptimize_css_justhead'),
            'datauris' => $conf->get('autoptimize_css_datauris'),
            'defer' => $conf->get('autoptimize_css_defer'),
            'defer_inline' => $conf->get('autoptimize_css_defer_inline'),
            'inline' => $conf->get('autoptimize_css_inline'),
            'css_exclude' => $conf->get('autoptimize_css_exclude'),
            'cdn_url' => $conf->get('autoptimize_cdn_url'),
            'include_inline' => $conf->get('autoptimize_css_include_inline'),
            'nogooglefont' => $conf->get('autoptimize_css_nogooglefont')
        ),
        'autoptimizeHTML' => array(
            'keepcomments' => $conf->get('autoptimize_html_keepcomments')
        )
    );

    $content = apply_filters( 'autoptimize_filter_html_before_minify', $content );

    // Run the classes
    foreach($classes as $name) {
        $instance = new $name($content);
        if($instance->read($classoptions[$name])) {
            $instance->minify();
            $instance->cache();
            $content = $instance->getcontent();
        }
        unset($instance);
    }
    
    $content = apply_filters( 'autoptimize_html_after_minify', $content );
    return $content;
}

if ( autoptimizeCache::cacheavail() ) {
    $conf = autoptimizeConfig::instance();
    if( $conf->get('autoptimize_html') || $conf->get('autoptimize_js') || $conf->get('autoptimize_css') ) {
        // Hook to wordpress
        if (defined('AUTOPTIMIZE_INIT_EARLIER')) {
            add_action('init','autoptimize_start_buffering',-1);
        } else {
            if (!defined('AUTOPTIMIZE_HOOK_INTO')) { define('AUTOPTIMIZE_HOOK_INTO', 'template_redirect'); }
            add_action(constant("AUTOPTIMIZE_HOOK_INTO"),'autoptimize_start_buffering',2);
        }
    }
} else {
    add_action('admin_notices', 'autoptimize_cache_unavailable_notice');
}

function autoptimize_activate() {
    register_uninstall_hook( __FILE__, 'autoptimize_uninstall' );
}
register_activation_hook( __FILE__, 'autoptimize_activate' );

include_once('classlesses/autoptimizeCacheChecker.php');

// Do not pollute other plugins
unset($conf);


1		<?php
2		/*
3		Plugin Name: Autoptimize
4		Plugin URI: http://blog.futtta.be/autoptimize
5		Description: Optimizes your website, concatenating the CSS and JavaScript code, and compressing it.
6		Version: 2.1.0
7		Author: Frank Goossens (futtta)
8		Author URI: http://blog.futtta.be/
9		Domain Path: localization/
10		Text Domain: autoptimize
11		Released under the GNU General Public License (GPL)
12		http://www.gnu.org/licenses/gpl.txt
13		*/
14
15		if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
16
17		define('AUTOPTIMIZE_PLUGIN_DIR',plugin_dir_path(__FILE__));
18
19		// Load config class
20		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeConfig.php');
21
22		// Load toolbar class
23		include( AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeToolbar.php' );
24
25		// Load partners tab if admin
26		if (is_admin()) {
27		include AUTOPTIMIZE_PLUGIN_DIR.'classlesses/autoptimizePartners.php';
28		}
29
30		// Do we gzip when caching (needed early to load autoptimizeCache.php)
31		define('AUTOPTIMIZE_CACHE_NOGZIP',(bool) get_option('autoptimize_cache_nogzip'));
32
33		// Load cache class
34		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeCache.php');
35
36		// wp-content dir name (automagically set, should not be needed), dirname of AO cache dir and AO-prefix can be overridden in wp-config.php
37		if (!defined('AUTOPTIMIZE_WP_CONTENT_NAME')) { define('AUTOPTIMIZE_WP_CONTENT_NAME','/'.wp_basename( WP_CONTENT_DIR )); }
38		if (!defined('AUTOPTIMIZE_CACHE_CHILD_DIR')) { define('AUTOPTIMIZE_CACHE_CHILD_DIR','/cache/autoptimize/'); }
39		if (!defined('AUTOPTIMIZE_CACHEFILE_PREFIX')) { define('AUTOPTIMIZE_CACHEFILE_PREFIX', 'autoptimize_'); }
40
41		// Plugin dir constants (plugin url's defined later to accomodate domain mapped sites)
42	View Code Duplication	if (is_multisite() && apply_filters( 'autoptimize_separate_blog_caches' , true )) {
		0 ignored issues – show Duplication introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$blog_id = get_current_blog_id();
44		define('AUTOPTIMIZE_CACHE_DIR', WP_CONTENT_DIR.AUTOPTIMIZE_CACHE_CHILD_DIR.$blog_id.'/' );
45		} else {
46		define('AUTOPTIMIZE_CACHE_DIR', WP_CONTENT_DIR.AUTOPTIMIZE_CACHE_CHILD_DIR);
47		}
48		define('AUTOPTIMIZE_CACHE_DELAY',true);
49		define('WP_ROOT_DIR',str_replace(AUTOPTIMIZE_WP_CONTENT_NAME,'',WP_CONTENT_DIR));
50
51		// Initialize the cache at least once
52		$conf = autoptimizeConfig::instance();
53
54		/* Check if we're updating, in which case we might need to do stuff and flush the cache
55		to avoid old versions of aggregated files lingering around */
56
57		$autoptimize_version="2.1.0";
58		$autoptimize_db_version=get_option('autoptimize_version','none');
59
60		if ($autoptimize_db_version !== $autoptimize_version) {
61		if ($autoptimize_db_version==="none") {
62		add_action('admin_notices', 'autoptimize_install_config_notice');
63		} else {
64		// updating, include the update-code
65		include(AUTOPTIMIZE_PLUGIN_DIR.'classlesses/autoptimizeUpdateCode.php');
66		}
67
68		update_option('autoptimize_version',$autoptimize_version);
69		$autoptimize_db_version=$autoptimize_version;
70		}
71
72		// Load translations
73		function autoptimize_load_plugin_textdomain() {
74		load_plugin_textdomain('autoptimize',false,plugin_basename(dirname( __FILE__ )).'/localization');
75		}
76		add_action( 'init', 'autoptimize_load_plugin_textdomain' );
77
78		function autoptimize_uninstall(){
79		autoptimizeCache::clearall();
80
81		$delete_options=array("autoptimize_cache_clean", "autoptimize_cache_nogzip", "autoptimize_css", "autoptimize_css_datauris", "autoptimize_css_justhead", "autoptimize_css_defer", "autoptimize_css_defer_inline", "autoptimize_css_inline", "autoptimize_css_exclude", "autoptimize_html", "autoptimize_html_keepcomments", "autoptimize_js", "autoptimize_js_exclude", "autoptimize_js_forcehead", "autoptimize_js_justhead", "autoptimize_js_trycatch", "autoptimize_version", "autoptimize_show_adv", "autoptimize_cdn_url", "autoptimize_cachesize_notice","autoptimize_css_include_inline","autoptimize_js_include_inline","autoptimize_css_nogooglefont");
82
83		if ( !is_multisite() ) {
84		foreach ($delete_options as $del_opt) { delete_option( $del_opt ); }
85		} else {
86		global $wpdb;
87		$blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" );
88		$original_blog_id = get_current_blog_id();
89		foreach ( $blog_ids as $blog_id ) {
90		switch_to_blog( $blog_id );
91		foreach ($delete_options as $del_opt) { delete_option( $del_opt ); }
92		}
93		switch_to_blog( $original_blog_id );
94		}
95
96		if ( wp_get_schedule( 'ao_cachechecker' ) ) {
97		wp_clear_scheduled_hook( 'ao_cachechecker' );
98		}
99		}
100
101		function autoptimize_install_config_notice() {
102		echo '<div class="updated"><p>';
103		_e('Thank you for installing and activating Autoptimize. Please configure it under "Settings" -> "Autoptimize" to start improving your site\'s performance.', 'autoptimize' );
104		echo '</p></div>';
105		}
106
107		function autoptimize_update_config_notice() {
108		echo '<div class="updated"><p>';
109		_e('Autoptimize has just been updated. Please <strong>test your site now</strong> and adapt Autoptimize config if needed.', 'autoptimize' );
110		echo '</p></div>';
111		}
112
113		function autoptimize_cache_unavailable_notice() {
114		echo '<div class="error"><p>';
115		printf( __( 'Autoptimize cannot write to the cache directory (%s), please fix to enable CSS/ JS optimization!', 'autoptimize' ), AUTOPTIMIZE_CACHE_DIR );
116		echo '</p></div>';
117		}
118
119		// Set up the buffering
120		function autoptimize_start_buffering() {
121		$ao_noptimize = false;
122
123		// noptimize in qs to get non-optimized page for debugging
124		if (array_key_exists("ao_noptimize",$_GET)) {
125		if ( ($_GET["ao_noptimize"]==="1") && (apply_filters('autoptimize_filter_honor_qs_noptimize',true)) ) {
126		$ao_noptimize = true;
127		}
128		}
129
130		// check for DONOTMINIFY constant as used by e.g. WooCommerce POS
131		if (defined('DONOTMINIFY') && (constant('DONOTMINIFY')===true \|\| constant('DONOTMINIFY')==="true")) {
132		$ao_noptimize = true;
133		}
134
135		// filter you can use to block autoptimization on your own terms
136		$ao_noptimize = (bool) apply_filters( 'autoptimize_filter_noptimize', $ao_noptimize );
137
138		if (!is_feed() && !$ao_noptimize && !is_admin() && ( !function_exists('is_customize_preview') \|\| !is_customize_preview() ) ) {
139		// Config element
140		$conf = autoptimizeConfig::instance();
141
142		// Load our base class
143		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeBase.php');
144
145		// Load extra classes and set some vars
146		if($conf->get('autoptimize_html')) {
147		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeHTML.php');
148		// BUG: new minify-html does not support keeping HTML comments, skipping for now
149		// if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
150		@include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-html.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
151		// } else {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
152		// @include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-2.1.7-html.php');
153		// }
154		}
155
156	View Code Duplication	if($conf->get('autoptimize_js')) {
		0 ignored issues – show Duplication introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeScripts.php');
158		if (!class_exists('JSMin')) {
159		if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {
160		@include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/jsmin-1.1.1.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
161		} else {
162		@include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-2.3.1-jsmin.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
163		}
164		}
165		if ( ! defined( 'CONCATENATE_SCRIPTS' )) {
166		define('CONCATENATE_SCRIPTS',false);
167		}
168		if ( ! defined( 'COMPRESS_SCRIPTS' )) {
169		define('COMPRESS_SCRIPTS',false);
170		}
171		}
172
173	View Code Duplication	if($conf->get('autoptimize_css')) {
		0 ignored issues – show Duplication introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
174		include(AUTOPTIMIZE_PLUGIN_DIR.'classes/autoptimizeStyles.php');
175		if (defined('AUTOPTIMIZE_LEGACY_MINIFIERS')) {
176		if (!class_exists('Minify_CSS_Compressor')) {
177		@include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/minify-css-compressor.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
178		}
179		} else {
180		if (!class_exists('CSSmin')) {
181		@include(AUTOPTIMIZE_PLUGIN_DIR.'classes/external/php/yui-php-cssmin-2.4.8-4_fgo.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
182		}
183		}
184		if ( ! defined( 'COMPRESS_CSS' )) {
185		define('COMPRESS_CSS',false);
186		}
187		}
188
189		// filter to be used with care, kills all output buffers when true. use with extreme caution. you have been warned!
190		if (apply_filters('autoptimize_filter_obkiller',false)) {
191		while (ob_get_level() > 0) {
192		ob_end_clean();
193		}
194		}
195
196		// Now, start the real thing!
197		ob_start('autoptimize_end_buffering');
198		}
199		}
200
201		// Action on end, this is where the magic happens
202		function autoptimize_end_buffering($content) {
203		if ( ((stripos($content,"<html") === false) && (stripos($content,"<!DOCTYPE html") === false)) \|\| preg_match('/<html[^>]*(?:amp\|⚡)/',$content) === 1 \|\| stripos($content,"<xsl:stylesheet") !== false ) { return $content; }
204
205		// load URL constants as late as possible to allow domain mapper to kick in
206		if (function_exists("domain_mapping_siteurl")) {
207		define('AUTOPTIMIZE_WP_SITE_URL',domain_mapping_siteurl(get_current_blog_id()));
208		define('AUTOPTIMIZE_WP_CONTENT_URL',str_replace(get_original_url(AUTOPTIMIZE_WP_SITE_URL),AUTOPTIMIZE_WP_SITE_URL,content_url()));
209		} else {
210		define('AUTOPTIMIZE_WP_SITE_URL',site_url());
211		define('AUTOPTIMIZE_WP_CONTENT_URL',content_url());
212		}
213
214	View Code Duplication	if ( is_multisite() && apply_filters( 'autoptimize_separate_blog_caches' , true ) ) {
		0 ignored issues – show Duplication introduced 2016-11-16 14:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
215		$blog_id = get_current_blog_id();
216		define('AUTOPTIMIZE_CACHE_URL',AUTOPTIMIZE_WP_CONTENT_URL.AUTOPTIMIZE_CACHE_CHILD_DIR.$blog_id.'/' );
217		} else {
218		define('AUTOPTIMIZE_CACHE_URL',AUTOPTIMIZE_WP_CONTENT_URL.AUTOPTIMIZE_CACHE_CHILD_DIR);
219		}
220		define('AUTOPTIMIZE_WP_ROOT_URL',str_replace(AUTOPTIMIZE_WP_CONTENT_NAME,'',AUTOPTIMIZE_WP_CONTENT_URL));
221
222		// Config element
223		$conf = autoptimizeConfig::instance();
224
225		// Choose the classes
226		$classes = array();
227		if($conf->get('autoptimize_js'))
228		$classes[] = 'autoptimizeScripts';
229		if($conf->get('autoptimize_css'))
230		$classes[] = 'autoptimizeStyles';
231		if($conf->get('autoptimize_html'))
232		$classes[] = 'autoptimizeHTML';
233
234		// Set some options
235		$classoptions = array(
236		'autoptimizeScripts' => array(
237		'justhead' => $conf->get('autoptimize_js_justhead'),
238		'forcehead' => $conf->get('autoptimize_js_forcehead'),
239		'trycatch' => $conf->get('autoptimize_js_trycatch'),
240		'js_exclude' => $conf->get('autoptimize_js_exclude'),
241		'cdn_url' => $conf->get('autoptimize_cdn_url'),
242		'include_inline' => $conf->get('autoptimize_js_include_inline')
243		),
244		'autoptimizeStyles' => array(
245		'justhead' => $conf->get('autoptimize_css_justhead'),
246		'datauris' => $conf->get('autoptimize_css_datauris'),
247		'defer' => $conf->get('autoptimize_css_defer'),
248		'defer_inline' => $conf->get('autoptimize_css_defer_inline'),
249		'inline' => $conf->get('autoptimize_css_inline'),
250		'css_exclude' => $conf->get('autoptimize_css_exclude'),
251		'cdn_url' => $conf->get('autoptimize_cdn_url'),
252		'include_inline' => $conf->get('autoptimize_css_include_inline'),
253		'nogooglefont' => $conf->get('autoptimize_css_nogooglefont')
254		),
255		'autoptimizeHTML' => array(
256		'keepcomments' => $conf->get('autoptimize_html_keepcomments')
257		)
258		);
259
260		$content = apply_filters( 'autoptimize_filter_html_before_minify', $content );
261
262		// Run the classes
263		foreach($classes as $name) {
264		$instance = new $name($content);
265		if($instance->read($classoptions[$name])) {
266		$instance->minify();
267		$instance->cache();
268		$content = $instance->getcontent();
269		}
270		unset($instance);
271		}
272
273		$content = apply_filters( 'autoptimize_html_after_minify', $content );
274		return $content;
275		}
276
277		if ( autoptimizeCache::cacheavail() ) {
278		$conf = autoptimizeConfig::instance();
279		if( $conf->get('autoptimize_html') \|\| $conf->get('autoptimize_js') \|\| $conf->get('autoptimize_css') ) {
280		// Hook to wordpress
281		if (defined('AUTOPTIMIZE_INIT_EARLIER')) {
282		add_action('init','autoptimize_start_buffering',-1);
283		} else {
284		if (!defined('AUTOPTIMIZE_HOOK_INTO')) { define('AUTOPTIMIZE_HOOK_INTO', 'template_redirect'); }
285		add_action(constant("AUTOPTIMIZE_HOOK_INTO"),'autoptimize_start_buffering',2);
286		}
287		}
288		} else {
289		add_action('admin_notices', 'autoptimize_cache_unavailable_notice');
290		}
291
292		function autoptimize_activate() {
293		register_uninstall_hook( __FILE__, 'autoptimize_uninstall' );
294		}
295		register_activation_hook( __FILE__, 'autoptimize_activate' );
296
297		include_once('classlesses/autoptimizeCacheChecker.php');
298
299		// Do not pollute other plugins
300		unset($conf);
301

futtta / autoptimize

Push — master ( cacc24...b5e696 )

autoptimize.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like