Completed
Push — master ( 8e7dca...6ec0d0 )
by frank
01:41
created

autoptimizeExtra::get_img_quality_string()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 12

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 2
nc 2
nop 0
dl 0
loc 12
rs 9.8666
c 0
b 0
f 0
1
<?php
2
/**
3
 * Handles autoptimizeExtra frontend features + admin options page
4
 */
5
6
if ( ! defined( 'ABSPATH' ) ) {
7
    exit;
8
}
9
10
class autoptimizeExtra
11
{
12
    /**
13
     * Options
14
     *
15
     * @var array
16
     */
17
    protected $options = array();
18
19
    /**
20
     * Creates an instance and calls run().
21
     *
22
     * @param array $options Optional. Allows overriding options without having to specify them via admin options page.
23
     */
24
    public function __construct( $options = array() )
25
    {
26
        if ( empty( $options ) ) {
27
            $options = $this->fetch_options();
28
        }
29
30
        $this->options = $options;
31
    }
32
33
    public function run()
34
    {
35
        if ( is_admin() ) {
36
            add_action( 'admin_menu', array( $this, 'admin_menu' ) );
37
            add_filter( 'autoptimize_filter_settingsscreen_tabs', array( $this, 'add_extra_tab' ) );
38
        } else {
39
            $this->run_on_frontend();
40
        }
41
    }
42
43
    protected function fetch_options()
44
    {
45
        $value = get_option( 'autoptimize_extra_settings' );
46
        if ( empty( $value ) ) {
47
            // Fallback to returning defaults when no stored option exists yet.
48
            $value = autoptimizeConfig::get_ao_extra_default_options();
49
        }
50
51
        // get service availability.
52
        $value['availabilities'] = get_option( 'autoptimize_service_availablity' );
53
54
        if ( empty( $value['availabilities'] ) ) {
55
            $value['availabilities'] = autoptimizeUtils::check_service_availability( true );
0 ignored issues
show
Documentation introduced by
true is of type boolean, but the function expects a false|string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
56
        }
57
58
        return $value;
59
    }
60
61
    public function disable_emojis()
62
    {
63
        // Removing all actions related to emojis!
64
        remove_action( 'admin_print_styles', 'print_emoji_styles' );
65
        remove_action( 'wp_head', 'print_emoji_detection_script', 7 );
66
        remove_action( 'admin_print_scripts', 'print_emoji_detection_script' );
67
        remove_action( 'wp_print_styles', 'print_emoji_styles' );
68
        remove_filter( 'wp_mail', 'wp_staticize_emoji_for_email' );
69
        remove_filter( 'the_content_feed', 'wp_staticize_emoji' );
70
        remove_filter( 'comment_text_rss', 'wp_staticize_emoji' );
71
72
        // Removes TinyMCE emojis.
73
        add_filter( 'tiny_mce_plugins', array( $this, 'filter_disable_emojis_tinymce' ) );
74
75
        // Removes emoji dns-preftech.
76
        add_filter( 'wp_resource_hints', array( $this, 'filter_remove_emoji_dns_prefetch' ), 10, 2 );
77
    }
78
79
    public function filter_disable_emojis_tinymce( $plugins )
80
    {
81
        if ( is_array( $plugins ) ) {
82
            return array_diff( $plugins, array( 'wpemoji' ) );
83
        } else {
84
            return array();
85
        }
86
    }
87
88
    public function filter_remove_qs( $src ) {
89
        if ( strpos( $src, '?ver=' ) ) {
90
            $src = remove_query_arg( 'ver', $src );
91
        }
92
93
        return $src;
94
    }
95
96
    public function extra_async_js( $in )
97
    {
98
        $exclusions = array();
99 View Code Duplication
        if ( ! empty( $in ) ) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
100
            $exclusions = array_fill_keys( array_filter( array_map( 'trim', explode( ',', $in ) ) ), '' );
101
        }
102
103
        $settings = $this->options['autoptimize_extra_text_field_3'];
104
        $async    = array_fill_keys( array_filter( array_map( 'trim', explode( ',', $settings ) ) ), '' );
105
        $attr     = apply_filters( 'autoptimize_filter_extra_async', 'async' );
106
        foreach ( $async as $k => $v ) {
107
            $async[ $k ] = $attr;
108
        }
109
110
        // Merge exclusions & asyncs in one array and return to AO API.
111
        $merged = array_merge( $exclusions, $async );
112
113
        return $merged;
114
    }
115
116
    protected function run_on_frontend()
117
    {
118
        $options = $this->options;
119
120
        // Disable emojis if specified.
121
        if ( ! empty( $options['autoptimize_extra_checkbox_field_1'] ) ) {
122
            $this->disable_emojis();
123
        }
124
125
        // Remove version query parameters.
126
        if ( ! empty( $options['autoptimize_extra_checkbox_field_0'] ) ) {
127
            add_filter( 'script_loader_src', array( $this, 'filter_remove_qs' ), 15, 1 );
128
            add_filter( 'style_loader_src', array( $this, 'filter_remove_qs' ), 15, 1 );
129
        }
130
131
        // Making sure is_plugin_active() exists when we need it.
132
        if ( ! function_exists( 'is_plugin_active' ) ) {
133
            require_once ABSPATH . 'wp-admin/includes/plugin.php';
134
        }
135
        // Avoiding conflicts of interest when async-javascript plugin is active!
136
        $async_js_plugin_active = false;
137
        if ( function_exists( 'is_plugin_active' ) && is_plugin_active( 'async-javascript/async-javascript.php' ) ) {
138
            $async_js_plugin_active = true;
139
        }
140
        if ( ! empty( $options['autoptimize_extra_text_field_3'] ) && ! $async_js_plugin_active ) {
141
            add_filter( 'autoptimize_filter_js_exclude', array( $this, 'extra_async_js' ), 10, 1 );
142
        }
143
144
        // Optimize google fonts!
145
        if ( ! empty( $options['autoptimize_extra_radio_field_4'] ) && ( '1' !== $options['autoptimize_extra_radio_field_4'] ) ) {
146
            add_filter( 'wp_resource_hints', array( $this, 'filter_remove_gfonts_dnsprefetch' ), 10, 2 );
147
            add_filter( 'autoptimize_html_after_minify', array( $this, 'filter_optimize_google_fonts' ), 10, 1 );
148
            add_filter( 'autoptimize_extra_filter_tobepreconn', array( $this, 'filter_preconnect_google_fonts' ), 10, 1 );
149
        }
150
151
        // Preconnect!
152
        if ( ! empty( $options['autoptimize_extra_text_field_2'] ) || has_filter( 'autoptimize_extra_filter_tobepreconn' ) ) {
153
            add_filter( 'wp_resource_hints', array( $this, 'filter_preconnect' ), 10, 2 );
154
        }
155
156
        // Optimize Images!
157
        if ( ! empty( $options['autoptimize_extra_checkbox_field_5'] ) && 'down' !== $options['availabilities']['extra_imgopt']['status'] && ( 'launch' !== $options['availabilities']['extra_imgopt']['status'] || $this->imgopt_launch_ok() ) ) {
158
            if ( apply_filters( 'autoptimize_filter_extra_imgopt_do', true ) ) {
159
                add_filter( 'autoptimize_html_after_minify', array( $this, 'filter_optimize_images' ), 10, 1 );
160
                $_imgopt_active = true;
161
            }
162
            if ( apply_filters( 'autoptimize_filter_extra_imgopt_do_css', true ) ) {
163
                add_filter( 'autoptimize_filter_base_replace_cdn', array( $this, 'filter_optimize_css_images' ), 10, 1 );
164
                $_imgopt_active = true;
165
            }
166
            if ( $_imgopt_active ) {
0 ignored issues
show
Bug introduced by
The variable $_imgopt_active does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
167
                add_filter( 'autoptimize_extra_filter_tobepreconn', array( $this, 'filter_preconnect_imgopt_url' ), 10, 1 );
168
            }
169
        }
170
    }
171
172
    public function filter_remove_emoji_dns_prefetch( $urls, $relation_type )
173
    {
174
        $emoji_svg_url = apply_filters( 'emoji_svg_url', 'https://s.w.org/images/core/emoji/' );
175
176
        return $this->filter_remove_dns_prefetch( $urls, $relation_type, $emoji_svg_url );
177
    }
178
179
    public function filter_remove_gfonts_dnsprefetch( $urls, $relation_type )
180
    {
181
        return $this->filter_remove_dns_prefetch( $urls, $relation_type, 'fonts.googleapis.com' );
182
    }
183
184
    public function filter_remove_dns_prefetch( $urls, $relation_type, $url_to_remove )
185
    {
186
        if ( 'dns-prefetch' === $relation_type ) {
187
            $cnt = 0;
188
            foreach ( $urls as $url ) {
189
                if ( false !== strpos( $url, $url_to_remove ) ) {
190
                    unset( $urls[ $cnt ] );
191
                }
192
                $cnt++;
193
            }
194
        }
195
196
        return $urls;
197
    }
198
199
    public function filter_optimize_google_fonts( $in )
200
    {
201
        // Extract fonts, partly based on wp rocket's extraction code.
202
        $markup = preg_replace( '/<!--(.*)-->/Uis', '', $in );
203
        preg_match_all( '#<link(?:\s+(?:(?!href\s*=\s*)[^>])+)?(?:\s+href\s*=\s*([\'"])((?:https?:)?\/\/fonts\.googleapis\.com\/css(?:(?!\1).)+)\1)(?:\s+[^>]*)?>#iU', $markup, $matches );
204
205
        $fonts_collection = array();
206
        if ( ! $matches[2] ) {
207
            return $in;
208
        }
209
210
        // Store them in $fonts array.
211
        $i = 0;
212
        foreach ( $matches[2] as $font ) {
213
            if ( ! preg_match( '/rel=["\']dns-prefetch["\']/', $matches[0][ $i ] ) ) {
214
                // Get fonts name.
215
                $font = str_replace( array( '%7C', '%7c' ), '|', $font );
216
                $font = explode( 'family=', $font );
217
                $font = ( isset( $font[1] ) ) ? explode( '&', $font[1] ) : array();
218
                // Add font to $fonts[$i] but make sure not to pollute with an empty family!
219
                $_thisfont = array_values( array_filter( explode( '|', reset( $font ) ) ) );
220
                if ( ! empty( $_thisfont ) ) {
221
                    $fonts_collection[ $i ]['fonts'] = $_thisfont;
222
                    // And add subset if any!
223
                    $subset = ( is_array( $font ) ) ? end( $font ) : '';
224
                    if ( false !== strpos( $subset, 'subset=' ) ) {
225
                        $subset                            = explode( 'subset=', $subset );
226
                        $fonts_collection[ $i ]['subsets'] = explode( ',', $subset[1] );
227
                    }
228
                }
229
                // And remove Google Fonts.
230
                $in = str_replace( $matches[0][ $i ], '', $in );
231
            }
232
            $i++;
233
        }
234
235
        $options      = $this->options;
236
        $fonts_markup = '';
237
        if ( '2' === $options['autoptimize_extra_radio_field_4'] ) {
238
            // Remove Google Fonts.
239
            unset( $fonts_collection );
240
            return $in;
241
        } elseif ( '3' === $options['autoptimize_extra_radio_field_4'] || '5' === $options['autoptimize_extra_radio_field_4'] ) {
242
            // Aggregate & link!
243
            $fonts_string  = '';
244
            $subset_string = '';
245
            foreach ( $fonts_collection as $font ) {
246
                $fonts_string .= '|' . trim( implode( '|', $font['fonts'] ), '|' );
247
                if ( ! empty( $font['subsets'] ) ) {
248
                    $subset_string .= implode( ',', $font['subsets'] );
249
                }
250
            }
251
252
            if ( ! empty( $subset_string ) ) {
253
                $fonts_string = $fonts_string . '#038;subset=' . $subset_string;
254
            }
255
256
            $fonts_string = str_replace( '|', '%7C', ltrim( $fonts_string, '|' ) );
257
258
            if ( ! empty( $fonts_string ) ) {
259
                if ( '5' === $options['autoptimize_extra_radio_field_4'] ) {
260
                    $rel_string = 'rel="preload" as="style" onload="' . autoptimizeConfig::get_ao_css_preload_onload() . '"';
261
                } else {
262
                    $rel_string = 'rel="stylesheet"';
263
                }
264
                $fonts_markup = '<link ' . $rel_string . ' id="ao_optimized_gfonts" href="https://fonts.googleapis.com/css?family=' . $fonts_string . '" />';
265
            }
266
        } elseif ( '4' === $options['autoptimize_extra_radio_field_4'] ) {
267
            // Aggregate & load async (webfont.js impl.)!
268
            $fonts_array = array();
269
            foreach ( $fonts_collection as $_fonts ) {
270
                if ( ! empty( $_fonts['subsets'] ) ) {
271
                    $_subset = implode( ',', $_fonts['subsets'] );
272
                    foreach ( $_fonts['fonts'] as $key => $_one_font ) {
273
                        $_one_font               = $_one_font . ':' . $_subset;
274
                        $_fonts['fonts'][ $key ] = $_one_font;
275
                    }
276
                }
277
                $fonts_array = array_merge( $fonts_array, $_fonts['fonts'] );
278
            }
279
280
            $fonts_markup = '<script data-cfasync="false" id="ao_optimized_gfonts" type="text/javascript">WebFontConfig={google:{families:[\'';
281
            foreach ( $fonts_array as $fnt ) {
282
                $fonts_markup .= $fnt . "','";
283
            }
284
            $fonts_markup  = trim( trim( $fonts_markup, "'" ), ',' );
285
            $fonts_markup .= '] },classes:false, events:false, timeout:1500};(function() {var wf = document.createElement(\'script\');wf.src=\'https://ajax.googleapis.com/ajax/libs/webfont/1/webfont.js\';wf.type=\'text/javascript\';wf.async=\'true\';var s=document.getElementsByTagName(\'script\')[0];s.parentNode.insertBefore(wf, s);})();</script>';
286
        }
287
288
        // Replace back in markup.
289
        $out = substr_replace( $in, $fonts_markup . '<link', strpos( $in, '<link' ), strlen( '<link' ) );
290
        unset( $fonts_collection );
291
292
        // and insert preload polyfill if "link preload" and if the polyfill isn't there yet (courtesy of inline&defer).
293
        $preload_polyfill = autoptimizeConfig::get_ao_css_preload_polyfill();
294
        if ( '5' === $options['autoptimize_extra_radio_field_4'] && strpos( $out, $preload_polyfill ) === false ) {
295
            $out = str_replace( '</body>', $preload_polyfill . '</body>', $out );
296
        }
297
        return $out;
298
    }
299
300
    public function filter_preconnect( $hints, $relation_type )
301
    {
302
        $options = $this->options;
303
304
        // Get settings and store in array.
305
        $preconns = array_filter( array_map( 'trim', explode( ',', $options['autoptimize_extra_text_field_2'] ) ) );
306
        $preconns = apply_filters( 'autoptimize_extra_filter_tobepreconn', $preconns );
307
308
        // Walk array, extract domain and add to new array with crossorigin attribute.
309
        foreach ( $preconns as $preconn ) {
310
            $parsed = parse_url( $preconn );
311
312
            if ( is_array( $parsed ) && empty( $parsed['scheme'] ) ) {
313
                $domain = '//' . $parsed['host'];
314
            } elseif ( is_array( $parsed ) ) {
315
                $domain = $parsed['scheme'] . '://' . $parsed['host'];
316
            }
317
318
            if ( ! empty( $domain ) ) {
319
                $hint = array( 'href' => $domain );
320
                // Fonts don't get preconnected unless crossorigin flag is set, non-fonts don't get preconnected if origin flag is set
321
                // so hardcode fonts.gstatic.com to come with crossorigin and have filter to add other domains if needed.
322
                $crossorigins = apply_filters( 'autoptimize_extra_filter_preconn_crossorigin', array( 'https://fonts.gstatic.com' ) );
323
                if ( in_array( $domain, $crossorigins ) ) {
324
                    $hint['crossorigin'] = 'anonymous';
325
                }
326
                $new_hints[] = $hint;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$new_hints was never initialized. Although not strictly required by PHP, it is generally a good practice to add $new_hints = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
327
            }
328
        }
329
330
        // Merge in WP's preconnect hints.
331
        if ( 'preconnect' === $relation_type && ! empty( $new_hints ) ) {
332
            $hints = array_merge( $hints, $new_hints );
333
        }
334
335
        return $hints;
336
    }
337
338
    public function filter_preconnect_google_fonts( $in )
339
    {
340
        if ( '2' !== $this->options['autoptimize_extra_radio_field_4'] ) {
341
            // Preconnect to fonts.gstatic.com unless we remove gfonts.
342
            $in[] = 'https://fonts.gstatic.com';
343
        }
344
345
        if ( '4' === $this->options['autoptimize_extra_radio_field_4'] ) {
346
            // Preconnect even more hosts for webfont.js!
347
            $in[] = 'https://ajax.googleapis.com';
348
            $in[] = 'https://fonts.googleapis.com';
349
        }
350
351
        return $in;
352
    }
353
354
    public function filter_optimize_images( $in )
355
    {
356
        /*
357
         * potential future functional improvements:
358
         *
359
         * picture element.
360
         * filter for critical CSS.
361
         */
362
363
        $imgopt_base_url = $this->get_imgopt_base_url();
0 ignored issues
show
Unused Code introduced by
$imgopt_base_url is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
364
        $to_replace      = array();
365
366
        // extract img tags.
367
        if ( preg_match_all( '#<img[^>]*src[^>]*>#Usmi', $in, $matches ) ) {
368
            foreach ( $matches[0] as $tag ) {
369
                $orig_tag = $tag;
370
371
                // first do (data-)srcsets.
372
                if ( preg_match_all( '#srcset=("|\')(.*)("|\')#Usmi', $tag, $allsrcsets, PREG_SET_ORDER ) ) {
373
                    foreach ( $allsrcsets as $srcset ) {
374
                        $srcset  = $srcset[2];
375
                        $srcsets = explode( ',', $srcset );
376
                        foreach ( $srcsets as $indiv_srcset ) {
377
                            $indiv_srcset_parts = explode( ' ', trim( $indiv_srcset ) );
378
                            if ( $indiv_srcset_parts[1] && rtrim( $indiv_srcset_parts[1], 'w' ) !== $indiv_srcset_parts[1] ) {
379
                                $imgopt_w = rtrim( $indiv_srcset_parts[1], 'w' );
380
                            }
381
                            if ( $this->can_optimize_image( $indiv_srcset_parts[0] ) ) {
382
                                $imgopt_url              = $this->build_imgopt_url( $indiv_srcset_parts[0], $imgopt_w, '' );
0 ignored issues
show
Bug introduced by
The variable $imgopt_w does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
383
                                $tag                     = str_replace( $indiv_srcset_parts[0], $imgopt_url, $tag );
384
                                $to_replace[ $orig_tag ] = $tag;
385
                            }
386
                        }
387
                    }
388
                }
389
390
                // proceed with img src.
391
                // first get width and height and add to $imgopt_size.
392
                if ( preg_match( '#width=("|\')(.*)("|\')#Usmi', $tag, $width ) ) {
393
                    $imgopt_w = $width[2];
394
                }
395
                if ( preg_match( '#height=("|\')(.*)("|\')#Usmi', $tag, $height ) ) {
396
                    $imgopt_h = $height[2];
397
                }
398
399
                // then start replacing images src.
400
                if ( preg_match_all( '#src=(?:"|\')(?!data)(.*)(?:"|\')#Usmi', $tag, $urls, PREG_SET_ORDER ) ) {
401
                    foreach ( $urls as $url ) {
402
                        $full_src_orig = $url[0];
403
                        $url           = $url[1];
404
                        if ( $this->can_optimize_image( $url ) ) {
405
                            $imgopt_url              = $this->build_imgopt_url( $url, $imgopt_w, $imgopt_h );
0 ignored issues
show
Bug introduced by
The variable $imgopt_h does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
406
                            $full_imgopt_src         = str_replace( $url, $imgopt_url, $full_src_orig );
407
                            $tag                     = str_replace( $full_src_orig, $full_imgopt_src, $tag );
408
                            $to_replace[ $orig_tag ] = $tag;
409
                        }
410
                    }
411
                }
412
            }
413
        }
414
        $out = str_replace( array_keys( $to_replace ), array_values( $to_replace ), $in );
415
416
        // img thumbnails in e.g. woocommerce.
417
        if ( strpos( $out, 'data-thumb' ) !== false && apply_filters( 'autoptimize_filter_extra_imgopt_datathumbs', true ) ) {
418
            $out = preg_replace_callback(
419
                '/\<div(?:[^>]?)\sdata-thumb\=(?:\"|\')(.+?)(?:\"|\')(?:[^>]*)?\>/s',
420
                array( $this, 'replace_data_thumbs' ),
421
                $out
422
            );
423
        }
424
425
        return $out;
426
    }
427
428
    public function filter_optimize_css_images( $in )
429
    {
430
        $imgopt_base_url = $this->get_imgopt_base_url();
0 ignored issues
show
Unused Code introduced by
$imgopt_base_url is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
431
        $in              = $this->normalize_img_urls( $in );
432
433
        if ( $this->can_optimize_image( $in ) ) {
434
            return $this->build_imgopt_url( $in, '', '' );
435
        } else {
436
            return $in;
437
        }
438
    }
439
440
    private function get_imgopt_base_url()
441
    {
442
        static $imgopt_base_url = null;
443
444
        if ( is_null( $imgopt_base_url ) ) {
445
            $imgopt_host     = $this->get_imgopt_host();
446
            $quality         = $this->get_img_quality_string();
447
            $ret_val         = apply_filters( 'autoptimize_filter_extra_imgopt_wait', 'ret_img' ); // values: ret_wait, ret_img, ret_json, ret_blank.
448
            $imgopt_base_url = $imgopt_host . 'client/' . $quality . ',' . $ret_val;
449
            $imgopt_base_url = apply_filters( 'autoptimize_filter_extra_imgopt_base_url', $imgopt_base_url );
450
        }
451
452
        return $imgopt_base_url;
453
    }
454
455
    private function can_optimize_image( $url )
456
    {
457
        static $cdn_url      = null;
458
        static $nopti_images = null;
459
460
        if ( is_null( $cdn_url ) ) {
461
            $cdn_url = apply_filters( 'autoptimize_filter_base_cdnurl', get_option( 'autoptimize_cdn_url', '' ) );
462
        }
463
464
        if ( is_null( $nopti_images ) ) {
465
            $nopti_images = apply_filters( 'autoptimize_filter_extra_imgopt_noptimize', '' );
466
        }
467
468
        $imgopt_base_url = $this->get_imgopt_base_url();
0 ignored issues
show
Unused Code introduced by
$imgopt_base_url is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
469
        $site_host       = AUTOPTIMIZE_SITE_DOMAIN;
470
        $url_parsed      = parse_url( $url );
471
472
        if ( $url_parsed['host'] !== $site_host && empty( $cdn_url ) ) {
473
            return false;
474
        } elseif ( ! empty( $cdn_url ) && strpos( $url, $cdn_url ) === false && $url_parsed['host'] !== $site_host ) {
475
            return false;
476
        } elseif ( strpos( $url, '.php' ) !== false ) {
477
            return false;
478
        } elseif ( str_ireplace( array( '.png', '.gif', '.jpg', '.jpeg' ), '', $url_parsed['path'] ) === $url_parsed['path'] ) {
479
            // fixme: better check against end of string.
480
            return false;
481
        } elseif ( ! empty( $nopti_images ) ) {
482
            $nopti_images_array = array_filter( array_map( 'trim', explode( ',', $nopti_images ) ) );
483
            foreach ( $nopti_images_array as $nopti_image ) {
484
                if ( strpos( $url, $nopti_image ) !== false ) {
485
                    return false;
486
                }
487
            }
488
        }
489
        return true;
490
    }
491
492
    private function build_imgopt_url( $orig_url, $width = 0, $height = 0 )
493
    {
494
        $filtered_url = apply_filters( 'autoptimize_filter_extra_imgopt_build_url', $orig_url, $width, $height );
495
496
        if ( $filtered_url !== $orig_url ) {
497
            return $filtered_url;
498
        }
499
500
        $orig_url        = $this->normalize_img_urls( $orig_url );
501
        $imgopt_base_url = $this->get_imgopt_base_url();
502
        $imgopt_size     = '';
503
504
        if ( $width && 0 !== $width ) {
505
            $imgopt_size = ',w_' . $width;
506
        }
507
508
        if ( $height && 0 !== $height ) {
509
            $imgopt_size .= ',h_' . $height;
510
        }
511
512
        $url = $imgopt_base_url . $imgopt_size . '/' . $orig_url;
513
514
        return $url;
515
    }
516
517
    public function replace_data_thumbs( $matches )
518
    {
519
        if ( $this->can_optimize_image( $matches[1] ) ) {
520
            return str_replace( $matches[1], $this->build_imgopt_url( $matches[1], 150, 150 ), $matches[0] );
521
        } else {
522
            return $matches[0];
523
        }
524
    }
525
526
    public function filter_preconnect_imgopt_url( $in )
527
    {
528
        $imgopt_url_array = parse_url( $this->get_imgopt_base_url() );
529
        $in[]             = $imgopt_url_array['scheme'] . '://' . $imgopt_url_array['host'];
530
531
        return $in;
532
    }
533
534
    private function normalize_img_urls( $in )
535
    {
536
        $parsed_site_url = parse_url( site_url() );
537
538
        if ( strpos( $in, 'http' ) !== 0 && strpos( $in, '//' ) === 0 ) {
539
            $in = $parsed_site_url['scheme'] . ':' . $in;
540
        } elseif ( strpos( $in, '/' ) === 0 ) {
541
            $in = $parsed_site_url['scheme'] . '://' . $parsed_site_url['host'] . $in;
542
        }
543
544
        return apply_filters( 'autoptimize_filter_extra_imgopt_normalized_url', $in );
545
    }
546
547
    private function get_img_quality_array()
548
    {
549
        static $img_quality_array = null;
550
551
        if ( is_null( $img_quality_array ) ) {
552
            $img_quality_array = array(
553
                '1' => 'lossy',
554
                '2' => 'glossy',
555
                '3' => 'lossless',
556
            );
557
            $img_quality_array = apply_filters( 'autoptimize_filter_extra_imgopt_quality_array', $img_quality_array );
558
        }
559
560
        return $img_quality_array;
561
    }
562
563
    private function get_img_quality_setting()
564
    {
565
        static $_img_q = null;
566
567
        if ( is_null( $_img_q ) ) {
568
            $_setting = $this->options['autoptimize_extra_select_field_6'];
569
570
            if ( ! $_setting || empty( $_setting ) || ( '1' !== $_setting && '3' !== $_setting ) ) {
571
                // default image opt. value is 2 ("glossy").
572
                $_img_q = '2';
573
            } else {
574
                $_img_q = $_setting;
575
            }
576
        }
577
578
        return $_img_q;
579
    }
580
581
    private function get_img_quality_string()
582
    {
583
        static $_img_q_string = null;
584
585
        if ( is_null( $_img_q_string ) ) {
586
            $_quality_array = $this->get_img_quality_array();
587
            $_setting       = $this->get_img_quality_setting();
588
            $_img_q_string  = apply_filters( 'autoptimize_filter_extra_imgopt_quality', 'q_' . $_quality_array[ $_setting ] );
589
        }
590
591
        return $_img_q_string;
592
    }
593
594
    public static function get_img_provider_stats()
595
    {
596
        // wrapper around query_img_provider_stats() so we can get to $this->options from cronjob() in autoptimizeCacheChecker.
597
        $self = new self();
598
        return $self->query_img_provider_stats();
599
    }
600
601
    public function query_img_provider_stats()
602
    {
603
        if ( ! empty( $this->options['autoptimize_extra_checkbox_field_5'] ) ) {
604
            $_img_provider_stat_url = '';
605
            $_img_provider_endpoint = $this->get_imgopt_host() . 'read-domain/';
606
            $_site_host             = AUTOPTIMIZE_SITE_DOMAIN;
607
608
            // make sure parse_url result makes sense, keeping $_img_provider_stat_url empty if not.
609
            if ( $_site_host && ! empty( $_site_host ) ) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $_site_host of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
610
                $_img_provider_stat_url = $_img_provider_endpoint . $_site_host;
611
            }
612
613
            $_img_provider_stat_url = apply_filters( 'autoptimize_filter_extra_imgopt_stat_url', $_img_provider_stat_url );
614
615
            // only do the remote call if $_img_provider_stat_url is not empty to make sure no parse_url weirdness results in useless calls.
616 View Code Duplication
            if ( ! empty( $_img_provider_stat_url ) ) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
617
                $_img_stat_resp = wp_remote_get( $_img_provider_stat_url );
618
                if ( ! is_wp_error( $_img_stat_resp ) ) {
619
                    if ( '200' == wp_remote_retrieve_response_code( $_img_stat_resp ) ) {
620
                        $_img_provider_stat = json_decode( wp_remote_retrieve_body( $_img_stat_resp ), true );
621
                        update_option( 'autoptimize_imgopt_provider_stat', $_img_provider_stat );
622
                    }
623
                }
624
            }
625
        }
626
    }
627
628
    public function imgopt_launch_ok()
629
    {
630
        static $launch_status = null;
631
632
        if ( is_null( $launch_status ) ) {
633
            $avail_imgopt = $this->options['availabilities']['extra_imgopt'];
634
            $magic_number = intval( substr( md5( parse_url( AUTOPTIMIZE_WP_SITE_URL, PHP_URL_HOST ) ), 0, 3 ), 16 );
635
            $has_launched = get_option( 'autoptimize_imgopt_launched', '' );
636
            if ( $has_launched || ( array_key_exists( 'launch-threshold', $avail_imgopt ) && $magic_number < $avail_imgopt['launch-threshold'] ) ) {
637
                $launch_status = true;
638
                if ( ! $has_launched ) {
639
                    update_option( 'autoptimize_imgopt_launched', 'on' );
640
                }
641
            } else {
642
                $launch_status = false;
643
            }
644
        }
645
646
        return $launch_status;
647
    }
648
649
    public function get_imgopt_host()
650
    {
651
        static $imgopt_host = null;
652
653
        if ( is_null( $imgopt_host ) ) {
654
            $avail_imgopt = $this->options['availabilities']['extra_imgopt'];
655
            if ( ! empty( $avail_imgopt ) && array_key_exists( 'hosts', $avail_imgopt ) && is_array( $avail_imgopt['hosts'] ) ) {
656
                $imgopt_host = array_rand( array_flip( $avail_imgopt['hosts'] ) );
657
            } else {
658
                $imgopt_host = 'https://cdn.shortpixel.ai/';
659
            }
660
        }
661
662
        return $imgopt_host;
663
    }
664
665
    public static function get_imgopt_host_wrapper()
666
    {
667
        // needed for CI tests.
668
        $self = new self();
669
        return $self->get_imgopt_host();
670
    }
671
672
    public function get_imgopt_status_notice() {
673
        $_extra_options = $this->options;
674
        if ( ! empty( $_extra_options ) && is_array( $_extra_options ) && array_key_exists( 'autoptimize_extra_checkbox_field_5', $_extra_options ) && ! empty( $_extra_options['autoptimize_extra_checkbox_field_5'] ) ) {
675
            $_imgopt_notice = '';
0 ignored issues
show
Unused Code introduced by
$_imgopt_notice is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
676
            $_stat          = get_option( 'autoptimize_imgopt_provider_stat', '' );
677
            $_site_host     = AUTOPTIMIZE_SITE_DOMAIN;
678
            $_imgopt_upsell = 'https://shortpixel.com/aospai/af/GWRGFLW109483/' . $_site_host;
679
680
            if ( is_array( $_stat ) ) {
681
                if ( 1 == $_stat['Status'] ) {
682
                    // translators: "add more credits" will appear in a "a href".
683
                    $_imgopt_notice = sprintf( __( 'Your ShortPixel image optimization and CDN quota is almost used, make sure you %1$sadd more credits%2$s to avoid slowing down your website.', 'autoptimize' ), '<a href="' . $_imgopt_upsell . '" target="_blank">', '</a>' );
684
                } elseif ( -1 == $_stat['Status'] ) {
685
                    // translators: "add more credits" will appear in a "a href".
686
                    $_imgopt_notice = sprintf( __( 'Your ShortPixel image optimization and CDN quota was used, %1$sadd more credits%2$s to keep fast serving optimized images on your site.', 'autoptimize' ), '<a href="' . $_imgopt_upsell . '" target="_blank">', '</a>' );
687
                } else {
688
                    $_imgopt_upsell = 'https://shortpixel.com/g/af/GWRGFLW109483';
689
                    // translators: "log in to check your account" will appear in a "a href".
690
                    $_imgopt_notice = sprintf( __( 'Your ShortPixel image optimization and CDN quota are in good shape, %1$slog in to check your account%2$s.', 'autoptimize' ), '<a href="' . $_imgopt_upsell . '" target="_blank">', '</a>' );
691
                }
692
                $_imgopt_notice = apply_filters( 'autoptimize_filter_imgopt_notice', $_imgopt_notice );
693
694
                return array(
695
                    'status' => $_stat[ 'Status' ],
696
                    'notice' => $_imgopt_notice,
697
                );
698
            }
699
        }
700
        return false;
701
    }
702
703
    public static function get_imgopt_status_notice_wrapper() {
704
        // needed for notice being shown in autoptimizeCacheChecker.php.
705
        $self = new self();
706
        return $self->get_imgopt_status_notice();
707
    }
708
709
    public function admin_menu()
710
    {
711
        add_submenu_page( null, 'autoptimize_extra', 'autoptimize_extra', 'manage_options', 'autoptimize_extra', array( $this, 'options_page' ) );
712
        register_setting( 'autoptimize_extra_settings', 'autoptimize_extra_settings' );
713
    }
714
715
    public function add_extra_tab( $in )
716
    {
717
        $in = array_merge( $in, array( 'autoptimize_extra' => __( 'Extra', 'autoptimize' ) ) );
718
719
        return $in;
720
    }
721
722
    public function options_page()
723
    {
724
        // Working with actual option values from the database here.
725
        // That way any saves are still processed as expected, but we can still
726
        // override behavior by using `new autoptimizeExtra($custom_options)` and not have that custom
727
        // behavior being persisted in the DB even if save is done here.
728
        $options       = $this->fetch_options();
729
        $gfonts        = $options['autoptimize_extra_radio_field_4'];
730
        $sp_url_suffix = '/af/GWRGFLW109483/' . AUTOPTIMIZE_SITE_DOMAIN;
731
    ?>
732
    <style>
733
        #ao_settings_form {background: white;border: 1px solid #ccc;padding: 1px 15px;margin: 15px 10px 10px 0;}
734
        #ao_settings_form .form-table th {font-weight: normal;}
735
        #autoptimize_extra_descr{font-size: 120%;}
736
    </style>
737
    <div class="wrap">
738
    <h1><?php _e( 'Autoptimize Settings', 'autoptimize' ); ?></h1>
739
    <?php echo autoptimizeConfig::ao_admin_tabs(); ?>
740
    <?php
741
    if ( 'on' !== get_option( 'autoptimize_js' ) && 'on' !== get_option( 'autoptimize_css' ) && 'on' !== get_option( 'autoptimize_html' ) ) {
742
        ?>
743
        <div class="notice-warning notice"><p>
744
        <?php
745
        _e( 'Most of below Extra optimizations require at least one of HTML, JS or CSS autoptimizations being active.', 'autoptimize' );
746
        ?>
747
        </p></div>
748
        <?php
749
    }
750
751
    if ( 'down' === $options['availabilities']['extra_imgopt']['status'] ) {
752
        ?>
753
        <div class="notice-warning notice"><p>
754
        <?php
755
        // translators: "Autoptimize support forum" will appear in a "a href".
756
        echo sprintf( __( 'The image optimization service is currently down, image optimization will be skipped until further notice. Check the %1$sAutoptimize support forum%2$s for more info.', 'autoptimize' ), '<a href="https://wordpress.org/support/plugin/autoptimize/" target="_blank">', '</a>' );
757
        ?>
758
        </p></div>
759
        <?php
760
    }
761
762
    if ( 'launch' === $options['availabilities']['extra_imgopt']['status'] && ! $this->imgopt_launch_ok() ) {
763
        ?>
764
        <div class="notice-warning notice"><p>
765
        <?php
766
        _e( 'The image optimization service is launching, but not yet available for this domain, it should become available in the next couple of days.', 'autoptimize' );
767
        ?>
768
        </p></div>
769
        <?php
770
    }
771
772
    ?>
773
    <form id='ao_settings_form' action='options.php' method='post'>
774
        <?php settings_fields( 'autoptimize_extra_settings' ); ?>
775
        <h2><?php _e( 'Extra Auto-Optimizations', 'autoptimize' ); ?></h2>
776
        <span id='autoptimize_extra_descr'><?php _e( 'The following settings can improve your site\'s performance even more.', 'autoptimize' ); ?></span>
777
        <table class="form-table">
778
            <tr>
779
                <th scope="row"><?php _e( 'Google Fonts', 'autoptimize' ); ?></th>
780
                <td>
781
                    <input type="radio" name="autoptimize_extra_settings[autoptimize_extra_radio_field_4]" value="1" <?php if ( ! in_array( $gfonts, array( 2, 3, 4, 5 ) ) ) { echo 'checked'; } ?> ><?php _e( 'Leave as is', 'autoptimize' ); ?><br/>
782
                    <input type="radio" name="autoptimize_extra_settings[autoptimize_extra_radio_field_4]" value="2" <?php checked( 2, $gfonts, true ); ?> ><?php _e( 'Remove Google Fonts', 'autoptimize' ); ?><br/>
783
                    <input type="radio" name="autoptimize_extra_settings[autoptimize_extra_radio_field_4]" value="3" <?php checked( 3, $gfonts, true ); ?> ><?php _e( 'Combine and link in head (fonts load fast but are render-blocking)', 'autoptimize' ); ?><br/>
784
                    <input type="radio" name="autoptimize_extra_settings[autoptimize_extra_radio_field_4]" value="5" <?php checked( 5, $gfonts, true ); ?> ><?php _e( 'Combine and preload in head (fonts load late, but are not render-blocking)', 'autoptimize' ); ?><br/>
785
                    <input type="radio" name="autoptimize_extra_settings[autoptimize_extra_radio_field_4]" value="4" <?php checked( 4, $gfonts, true ); ?> ><?php _e( 'Combine and load fonts asynchronously with <a href="https://github.com/typekit/webfontloader#readme" target="_blank">webfont.js</a>', 'autoptimize' ); ?><br/>
786
                </td>
787
            </tr>
788
            <tr>
789
                <th scope="row"><?php _e( 'Optimize Images', 'autoptimize' ); ?></th>
790
                <td>
791
                    <label><input id='autoptimize_imgopt_checkbox' type='checkbox' name='autoptimize_extra_settings[autoptimize_extra_checkbox_field_5]' <?php if ( ! empty( $options['autoptimize_extra_checkbox_field_5'] ) && '1' === $options['autoptimize_extra_checkbox_field_5'] ) { echo 'checked="checked"'; } ?> value='1'><?php _e( 'Optimize images on the fly and serve them from a CDN.', 'autoptimize' ); ?></label>
792
                    <?php
793
                    // show shortpixel status.
794
                    $_notice = $this->get_imgopt_status_notice();
795
                    if ( $_notice ) {
796
                        switch ( $_notice['status'] ) {
797
                            case 2:
798
                                $_notice_color = 'green';
799
                                break;
800
                            case 1:
801
                                $_notice_color = 'orange';
802
                                break;
803
                            case -1:
804
                                $_notice_color = 'red';
805
                                break;
806
                            default:
807
                                $_notice_color = 'green';
808
                        }
809
                        echo apply_filters( 'autoptimize_filter_imgopt_settings_status', '<p><strong><span style="color:' . $_notice_color . ';">' . __( 'Shortpixel status: ', 'autoptimize' ) . '</span></strong>' . $_notice['notice'] . '</p>' );
810
                    } else {
811
                        $upsell_msg_1 = '<p>' . __( 'Get more Google love and improve your website\'s loading speed by having the images optimized on the fly by', 'autoptimize' );
812
                        $upsell_link  = ' <a href="https://shortpixel.com/aospai' . $sp_url_suffix . '" target="_blank">ShortPixel</a> ';
813
                        $upsell_msg_2 = __( 'and then cached and served fast from a CDN.', 'autoptimize' ) . ' ';
814
                        if ( 'launch' === $options['availabilities']['extra_imgopt']['status'] ) {
815
                            $upsell_msg_3 = __( 'For a limited time only, this service is offered free-for-all, <b>don\'t miss the chance to test it</b> and see how much it could improve your site\'s speed.', 'autoptimize' );
816
                        } else {
817
                            $upsell_msg_3 = __( 'The service is offered for free for 100 images/month regardless of the traffic used. More image optimizations can be purchased starting with $4.99.', 'autoptimize' );
818
                        }
819
                        echo apply_filters( 'autoptimize_extra_imgopt_settings_copy', $upsell_msg_1 . $upsell_link . $upsell_msg_2 . $upsell_msg_3 . '</p>' );
820
                    }
821
                    echo '<p>' . __( 'Usage of this feature is subject to Shortpixel\'s', 'autoptimize' ) . ' <a href="https://shortpixel.com/tos' . $sp_url_suffix . '" target="_blank">' . __( 'Terms of Use', 'autoptimize' ) . '</a> ' . __( 'and', 'autoptimize' ) . ' <a href="https://shortpixel.com/pp' . $sp_url_suffix . '" target="_blank">Privacy policy</a>.</p>';
822
                    ?>
823
                </td>
824
            </tr>
825
            <tr id='autoptimize_imgopt_quality' <?php if ( ! array_key_exists( 'autoptimize_extra_checkbox_field_5', $options ) || ( ! empty( $options['autoptimize_extra_checkbox_field_5'] ) && '1' !== $options['autoptimize_extra_checkbox_field_5'] ) ) { echo 'class="hidden"'; } ?>>
826
                <th scope="row"><?php _e( 'Image Optimization quality', 'autoptimize' ); ?></th>
827
                <td>
828
                    <label>
829
                    <select name='autoptimize_extra_settings[autoptimize_extra_select_field_6]'>
830
                        <?php
831
                        $_imgopt_array = $this->get_img_quality_array();
832
                        $_imgopt_val   = $this->get_img_quality_setting();
833
834
                        foreach ( $_imgopt_array as $key => $value ) {
835
                            echo '<option value="' . $key . '"';
836
                            if ( $_imgopt_val == $key ) {
837
                                echo ' selected';
838
                            }
839
                            echo '>' . ucfirst( $value ) . '</option>';
840
                        }
841
                        echo "\n";
842
                        ?>
843
                    </select>
844
                    </label>
845
                    <p><?php echo apply_filters( 'autoptimize_extra_imgopt_quality_copy', __( 'You can', 'autoptimize' ) . ' <a href="https://shortpixel.com/oic' . $sp_url_suffix . '" target="_blank">' . __( 'test compression levels here', 'autoptimize' ) . '</a>.' ); ?></p>
846
                </td>
847
            </tr>
848
            <tr>
849
                <th scope="row"><?php _e( 'Remove emojis', 'autoptimize' ); ?></th>
850
                <td>
851
                    <label><input type='checkbox' name='autoptimize_extra_settings[autoptimize_extra_checkbox_field_1]' <?php if ( ! empty( $options['autoptimize_extra_checkbox_field_1'] ) && '1' === $options['autoptimize_extra_checkbox_field_1'] ) { echo 'checked="checked"'; } ?> value='1'><?php _e( 'Removes WordPress\' core emojis\' inline CSS, inline JavaScript, and an otherwise un-autoptimized JavaScript file.', 'autoptimize' ); ?></label>
852
                </td>
853
            </tr>
854
            <tr>
855
                <th scope="row"><?php _e( 'Remove query strings from static resources', 'autoptimize' ); ?></th>
856
                <td>
857
                    <label><input type='checkbox' name='autoptimize_extra_settings[autoptimize_extra_checkbox_field_0]' <?php if ( ! empty( $options['autoptimize_extra_checkbox_field_0'] ) && '1' === $options['autoptimize_extra_checkbox_field_0'] ) { echo 'checked="checked"'; } ?> value='1'><?php _e( 'Removing query strings (or more specifically the <code>ver</code> parameter) will not improve load time, but might improve performance scores.', 'autoptimize' ); ?></label>
858
                </td>
859
            </tr>
860
            <tr>
861
                <th scope="row"><?php _e( 'Preconnect to 3rd party domains <em>(advanced users)</em>', 'autoptimize' ); ?></th>
862
                <td>
863
                    <label><input type='text' style='width:80%' name='autoptimize_extra_settings[autoptimize_extra_text_field_2]' value='<?php echo esc_attr( $options['autoptimize_extra_text_field_2'] ); ?>'><br /><?php _e( 'Add 3rd party domains you want the browser to <a href="https://www.keycdn.com/support/preconnect/#primary" target="_blank">preconnect</a> to, separated by comma\'s. Make sure to include the correct protocol (HTTP or HTTPS).', 'autoptimize' ); ?></label>
864
                </td>
865
            </tr>
866
            <tr>
867
                <th scope="row"><?php _e( 'Async Javascript-files <em>(advanced users)</em>', 'autoptimize' ); ?></th>
868
                <td>
869
                    <?php
870
                    if ( function_exists( 'is_plugin_active' ) && is_plugin_active( 'async-javascript/async-javascript.php' ) ) {
871
                        _e( 'You have "Async JavaScript" installed,', 'autoptimize' );
872
                        $asj_config_url = 'options-general.php?page=async-javascript';
873
                        echo sprintf( ' <a href="' . $asj_config_url . '">%s</a>', __( 'configuration of async javascript is best done there.', 'autoptimize' ) );
874
                    } else {
875
                    ?>
876
                        <input type='text' style='width:80%' name='autoptimize_extra_settings[autoptimize_extra_text_field_3]' value='<?php echo esc_attr( $options['autoptimize_extra_text_field_3'] ); ?>'>
877
                        <br />
878
                        <?php
879
                            _e( 'Comma-separated list of local or 3rd party JS-files that should loaded with the <code>async</code> flag. JS-files from your own site will be automatically excluded if added here. ', 'autoptimize' );
880
                            // translators: %s will be replaced by a link to the "async javascript" plugin.
881
                            echo sprintf( __( 'Configuration of async javascript is easier and more flexible using the %s plugin.', 'autoptimize' ), '"<a href="https://wordpress.org/plugins/async-javascript" target="_blank">Async Javascript</a>"' );
882
                            $asj_install_url = network_admin_url() . 'plugin-install.php?s=async+javascript&tab=search&type=term';
883
                            echo sprintf( ' <a href="' . $asj_install_url . '">%s</a>', __( 'Click here to install and activate it.', 'autoptimize' ) );
884
                    }
885
                    ?>
886
                </td>
887
            </tr>
888
            <tr>
889
                <th scope="row"><?php _e( 'Optimize YouTube videos', 'autoptimize' ); ?></th>
890
                <td>
891
                    <?php
892
                    if ( function_exists( 'is_plugin_active' ) && is_plugin_active( 'wp-youtube-lyte/wp-youtube-lyte.php' ) ) {
893
                        _e( 'Great, you have WP YouTube Lyte installed.', 'autoptimize' );
894
                        $lyte_config_url = 'options-general.php?page=lyte_settings_page';
895
                        echo sprintf( ' <a href="' . $lyte_config_url . '">%s</a>', __( 'Click here to configure it.', 'autoptimize' ) );
896 View Code Duplication
                    } else {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
897
                        // translators: %s will be replaced by a link to "wp youtube lyte" plugin.
898
                        echo sprintf( __( '%s allows you to “lazy load” your videos, by inserting responsive “Lite YouTube Embeds". ', 'autoptimize' ), '<a href="https://wordpress.org/plugins/wp-youtube-lyte" target="_blank">WP YouTube Lyte</a>' );
899
                        $lyte_install_url = network_admin_url() . 'plugin-install.php?s=lyte&tab=search&type=term';
900
                        echo sprintf( ' <a href="' . $lyte_install_url . '">%s</a>', __( 'Click here to install and activate it.', 'autoptimize' ) );
901
                    }
902
                    ?>
903
                </td>
904
            </tr>
905
        </table>
906
        <p class="submit"><input type="submit" name="submit" id="submit" class="button button-primary" value="<?php _e( 'Save Changes', 'autoptimize' ); ?>" /></p>
907
    </form>
908
    <script>
909
        jQuery(document).ready(function() {
910
            jQuery( "#autoptimize_imgopt_checkbox" ).change(function() {
911
                if (this.checked) {
912
                    jQuery("#autoptimize_imgopt_quality").show("slow");
913
                } else {
914
                    jQuery("#autoptimize_imgopt_quality").hide("slow");
915
                }
916
            });
917
        });
918
    </script>
919
    <?php
920
    }
921
}
922