Conditions | 35 |
Paths | 4609 |
Total Lines | 169 |
Code Lines | 94 |
Lines | 16 |
Ratio | 9.47 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
23 | public function read($options) { |
||
24 | $noptimizeJS = apply_filters( 'autoptimize_filter_js_noptimize', false, $this->content ); |
||
25 | if ($noptimizeJS) return false; |
||
26 | |||
27 | // only optimize known good JS? |
||
28 | $whitelistJS = apply_filters( 'autoptimize_filter_js_whitelist', "" ); |
||
29 | if (!empty($whitelistJS)) { |
||
30 | $this->whitelist = array_filter(array_map('trim',explode(",",$whitelistJS))); |
||
|
|||
31 | } |
||
32 | |||
33 | // is there JS we should simply remove |
||
34 | $removableJS = apply_filters( 'autoptimize_filter_js_removables', ''); |
||
35 | View Code Duplication | if (!empty($removableJS)) { |
|
36 | $this->jsremovables = array_filter(array_map('trim',explode(",",$removableJS))); |
||
37 | } |
||
38 | |||
39 | // only header? |
||
40 | View Code Duplication | if( apply_filters('autoptimize_filter_js_justhead',$options['justhead']) == true ) { |
|
41 | $content = explode('</head>',$this->content,2); |
||
42 | $this->content = $content[0].'</head>'; |
||
43 | $this->restofcontent = $content[1]; |
||
44 | } |
||
45 | |||
46 | // include inline? |
||
47 | if( apply_filters('autoptimize_js_include_inline',$options['include_inline']) == true ) { |
||
48 | $this->include_inline = true; |
||
49 | } |
||
50 | |||
51 | // filter to "late inject minified JS", default to true for now (it is faster) |
||
52 | $this->inject_min_late = apply_filters('autoptimize_filter_js_inject_min_late',true); |
||
53 | |||
54 | // filters to override hardcoded do(nt)move(last) array contents (array in, array out!) |
||
55 | $this->dontmove = apply_filters( 'autoptimize_filter_js_dontmove', $this->dontmove ); |
||
56 | $this->domovelast = apply_filters( 'autoptimize_filter_js_movelast', $this->domovelast ); |
||
57 | $this->domove = apply_filters( 'autoptimize_filter_js_domove', $this->domove ); |
||
58 | |||
59 | // get extra exclusions settings or filter |
||
60 | $excludeJS = $options['js_exclude']; |
||
61 | $excludeJS = apply_filters( 'autoptimize_filter_js_exclude', $excludeJS ); |
||
62 | if ($excludeJS!=="") { |
||
63 | if (is_array($excludeJS)) { |
||
64 | if(($removeKeys = array_keys($excludeJS,"remove")) !== false) { |
||
65 | foreach ($removeKeys as $removeKey) { |
||
66 | unset($excludeJS[$removeKey]); |
||
67 | $this->jsremovables[]=$removeKey; |
||
68 | } |
||
69 | } |
||
70 | $exclJSArr = array_keys($excludeJS); |
||
71 | } else { |
||
72 | $exclJSArr = array_filter(array_map('trim',explode(",",$excludeJS))); |
||
73 | } |
||
74 | $this->dontmove = array_merge($exclJSArr,$this->dontmove); |
||
75 | } |
||
76 | |||
77 | //Should we add try-catch? |
||
78 | if($options['trycatch'] == true) |
||
79 | $this->trycatch = true; |
||
80 | |||
81 | // force js in head? |
||
82 | if($options['forcehead'] == true) { |
||
83 | $this->forcehead = true; |
||
84 | } else { |
||
85 | $this->forcehead = false; |
||
86 | } |
||
87 | $this->forcehead = apply_filters( 'autoptimize_filter_js_forcehead', $this->forcehead ); |
||
88 | |||
89 | // get cdn url |
||
90 | $this->cdn_url = $options['cdn_url']; |
||
91 | |||
92 | // noptimize me |
||
93 | $this->content = $this->hide_noptimize($this->content); |
||
94 | |||
95 | // Save IE hacks |
||
96 | $this->content = $this->hide_iehacks($this->content); |
||
97 | |||
98 | // comments |
||
99 | $this->content = $this->hide_comments($this->content); |
||
100 | |||
101 | // Get script files |
||
102 | if (preg_match_all('#<script.*</script>#Usmi',$this->content,$matches)) { |
||
103 | foreach($matches[0] as $tag) { |
||
104 | // only consider script aggregation for types whitelisted in should_aggregate-function |
||
105 | if( !$this->should_aggregate($tag) ) { |
||
106 | $tag=''; |
||
107 | continue; |
||
108 | } |
||
109 | |||
110 | if (preg_match('#<script[^>]*src=("|\')([^>]*)("|\')#Usmi',$tag,$source)) { |
||
111 | // non-inline script |
||
112 | View Code Duplication | if ($this->isremovable($tag,$this->jsremovables)) { |
|
113 | $this->content = str_replace($tag,'',$this->content); |
||
114 | continue; |
||
115 | } |
||
116 | |||
117 | $url = current(explode('?',$source[2],2)); |
||
118 | $path = $this->getpath($url); |
||
119 | if($path !== false && preg_match('#\.js$#',$path) && $this->ismergeable($tag)) { |
||
120 | // ok to optimize, add to array |
||
121 | $this->scripts[] = $path; |
||
122 | } else { |
||
123 | // non-mergeable script (excluded or dynamic or external) |
||
124 | if (is_array($excludeJS)) { |
||
125 | // should we add flags? |
||
126 | $origTag = $tag; |
||
127 | foreach ($excludeJS as $exclTag => $exclFlags) { |
||
128 | if ( strpos($origTag,$exclTag)!==false && in_array($exclFlags,array("async","defer")) ) { |
||
129 | $tag = str_replace('<script ','<script '.$exclFlags.' ',$tag); |
||
130 | } |
||
131 | } |
||
132 | } |
||
133 | if($this->ismovable($tag)) { |
||
134 | // can be moved, flags and all |
||
135 | if($this->movetolast($tag)) { |
||
136 | $this->move['last'][] = $tag; |
||
137 | } else { |
||
138 | $this->move['first'][] = $tag; |
||
139 | } |
||
140 | } else { |
||
141 | // cannot be moved, so if flag was added re-inject altered tag immediately |
||
142 | if ($origTag && $origTag !== $tag) { |
||
143 | $this->content = str_replace($origTag,$tag,$this->content); |
||
144 | $origTag = ''; |
||
145 | } |
||
146 | // and forget about the $tag (not to be touched any more) |
||
147 | $tag = ''; |
||
148 | } |
||
149 | } |
||
150 | } else { |
||
151 | // Inline script |
||
152 | View Code Duplication | if ($this->isremovable($tag,$this->jsremovables)) { |
|
153 | $this->content = str_replace($tag,'',$this->content); |
||
154 | continue; |
||
155 | } |
||
156 | |||
157 | // unhide comments, as javascript may be wrapped in comment-tags for old times' sake |
||
158 | $tag = $this->restore_comments($tag); |
||
159 | if($this->ismergeable($tag) && ( $this->include_inline )) { |
||
160 | preg_match('#<script.*>(.*)</script>#Usmi',$tag,$code); |
||
161 | $code = preg_replace('#.*<!\[CDATA\[(?:\s*\*/)?(.*)(?://|/\*)\s*?\]\]>.*#sm','$1',$code[1]); |
||
162 | $code = preg_replace('/(?:^\\s*<!--\\s*|\\s*(?:\\/\\/)?\\s*-->\\s*$)/','',$code); |
||
163 | $this->scripts[] = 'INLINE;'.$code; |
||
164 | } else { |
||
165 | // Can we move this? |
||
166 | $autoptimize_js_moveable = apply_filters( 'autoptimize_js_moveable', '', $tag ); |
||
167 | if( $this->ismovable($tag) || $autoptimize_js_moveable !== '' ) { |
||
168 | if( $this->movetolast($tag) || $autoptimize_js_moveable === 'last' ) { |
||
169 | $this->move['last'][] = $tag; |
||
170 | } else { |
||
171 | $this->move['first'][] = $tag; |
||
172 | } |
||
173 | } else { |
||
174 | //We shouldn't touch this |
||
175 | $tag = ''; |
||
176 | } |
||
177 | } |
||
178 | // re-hide comments to be able to do the removal based on tag from $this->content |
||
179 | $tag = $this->hide_comments($tag); |
||
180 | } |
||
181 | |||
182 | //Remove the original script tag |
||
183 | $this->content = str_replace($tag,'',$this->content); |
||
184 | } |
||
185 | |||
186 | return true; |
||
187 | } |
||
188 | |||
189 | // No script files, great ;-) |
||
190 | return false; |
||
191 | } |
||
192 | |||
422 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..