+global\autoptimizeScripts::read()

Complexity

Conditions	38
Paths	12801

Size

Total Lines	188
Code Lines	102

Duplication

Lines	19
Ratio	10.11 %

Importance

Changes

0

<?php
    public function read($options) {
        $noptimizeJS = apply_filters( 'autoptimize_filter_js_noptimize', false, $this->content );
        if ($noptimizeJS) return false;

        // only optimize known good JS?
        $whitelistJS = apply_filters( 'autoptimize_filter_js_whitelist', "" );
        if (!empty($whitelistJS)) {
            $this->whitelist = array_filter(array_map('trim',explode(",",$whitelistJS)));

It seems like array_filter(array_map('trim', explode(',', $whitelistJS))) of type array is incompatible with the declared type string of property $whitelist.

        }

        // is there JS we should simply remove
        $removableJS = apply_filters( 'autoptimize_filter_js_removables', '');
        if (!empty($removableJS)) {

This code seems to be duplicated across your project.

            $this->jsremovables = array_filter(array_map('trim',explode(",",$removableJS)));
        }

        // only header?
        if( apply_filters('autoptimize_filter_js_justhead',$options['justhead']) == true ) {

This code seems to be duplicated across your project.

            $content = explode('</head>',$this->content,2);
            $this->content = $content[0].'</head>';
            $this->restofcontent = $content[1];
        }
        
        // include inline?
        if( apply_filters('autoptimize_js_include_inline',$options['include_inline']) == true ) {
            $this->include_inline = true;
        }

        // filter to "late inject minified JS", default to true for now (it is faster)
        $this->inject_min_late = apply_filters('autoptimize_filter_js_inject_min_late',true);

        // filters to override hardcoded do(nt)move(last) array contents (array in, array out!)

37% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->dontmove = apply_filters( 'autoptimize_filter_js_dontmove', $this->dontmove );        
        $this->domovelast = apply_filters( 'autoptimize_filter_js_movelast', $this->domovelast );
        $this->domove = apply_filters( 'autoptimize_filter_js_domove', $this->domove );

        // get extra exclusions settings or filter
        $excludeJS = $options['js_exclude'];
        $excludeJS = apply_filters( 'autoptimize_filter_js_exclude', $excludeJS );
        if ($excludeJS!=="") {
            if (is_array($excludeJS)) {
                if(($removeKeys = array_keys($excludeJS,"remove")) !== false) {
                    foreach ($removeKeys as $removeKey) {
                        unset($excludeJS[$removeKey]);
                        $this->jsremovables[]=$removeKey;
                    }
                }
                $exclJSArr = array_keys($excludeJS);
            } else {
                $exclJSArr = array_filter(array_map('trim',explode(",",$excludeJS)));
            }
            $this->dontmove = array_merge($exclJSArr,$this->dontmove);
        }

        //Should we add try-catch?
        if($options['trycatch'] == true)
            $this->trycatch = true;

        // force js in head?    
        if($options['forcehead'] == true) {
            $this->forcehead = true;
        } else {
            $this->forcehead = false;
        }
        $this->forcehead = apply_filters( 'autoptimize_filter_js_forcehead', $this->forcehead );

        // get cdn url
        $this->cdn_url = $options['cdn_url'];

The property cdn_url does not exist. Did you maybe forget to declare it?

            
        // noptimize me
        $this->content = $this->hide_noptimize($this->content);

        // Save IE hacks
        $this->content = $this->hide_iehacks($this->content);

        // comments
        $this->content = $this->hide_comments($this->content);

        // Get script files
        if (preg_match_all('#<script.*</script>#Usmi',$this->content,$matches)) {
            foreach($matches[0] as $tag) {
                // only consider script aggregation for types whitelisted in should_aggregate-function
                if( !$this->should_aggregate($tag) ) {
                    $tag='';
                    continue;
                }

                if (preg_match('#<script[^>]*src=("|\')([^>]*)("|\')#Usmi',$tag,$source)) {
                    // non-inline script
                    if ($this->isremovable($tag,$this->jsremovables)) {

This code seems to be duplicated across your project.

                        $this->content = str_replace($tag,'',$this->content);
                        continue;
                    }
                    $explUrl = explode('?',$source[2],2);
                    $url = $explUrl[0];
                    $path = $this->getpath($url);
                    if($path !== false && preg_match('#\.js$#',$path) && $this->ismergeable($tag)) {
                        // ok to optimize, add to array
                        $this->scripts[] = $path;
                    } else {
                        $origTag = $tag;
                        $newTag = $tag;
                        
                        // non-mergeable script (excluded or dynamic or external)
                        if (is_array($excludeJS)) {
                            // should we add flags?
                            foreach ($excludeJS as $exclTag => $exclFlags) {
                                if ( strpos($origTag,$exclTag)!==false && in_array($exclFlags,array("async","defer")) ) {
                                   $newTag = str_replace('<script ','<script '.$exclFlags.' ',$newTag);
                                }
                            }
                        }
                        
   						// should we minify the non-aggregated script?
						if ($path && apply_filters('autoptimize_filter_js_minify_excluded',false)) {

The expression $path of type false|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

							$_CachedMinifiedUrl = $this->minify_single($path);

							// replace orig URL with minified URL from cache if so
							if (!empty($_CachedMinifiedUrl)) {
								$newTag = str_replace($url, $_CachedMinifiedUrl, $newTag);
							}
							
							// remove querystring from URL in newTag
							if ( !empty($explUrl[1]) ) {

This code seems to be duplicated across your project.

								$newTag = str_replace("?".$explUrl[1],"",$newTag);
							}
						}

						// should we move the non-aggregated script?
                        if( $this->ismovable($newTag) ) {
                            // can be moved, flags and all
                            if( $this->movetolast($newTag) )    {
                                $this->move['last'][] = $newTag;
                            } else {
                                $this->move['first'][] = $newTag;
                            }
                        } else {
                            // cannot be moved, so if flag was added re-inject altered tag immediately
                            if ( $origTag !== $newTag ) {
                                $this->content = str_replace($origTag,$newTag,$this->content);
                                $origTag = '';

$origTag is not used, you could remove the assignment.

                            }
                            // and forget about the $tag (not to be touched any more)
                            $tag = '';
                        }
                    }
                } else {
                    // Inline script
                    if ($this->isremovable($tag,$this->jsremovables)) {

This code seems to be duplicated across your project.

                        $this->content = str_replace($tag,'',$this->content);
                        continue;
                    }
                    
                    // unhide comments, as javascript may be wrapped in comment-tags for old times' sake
                    $tag = $this->restore_comments($tag);
                    if($this->ismergeable($tag) && ( $this->include_inline )) {
                        preg_match('#<script.*>(.*)</script>#Usmi',$tag,$code);
                        $code = preg_replace('#.*<!\[CDATA\[(?:\s*\*/)?(.*)(?://|/\*)\s*?\]\]>.*#sm','$1',$code[1]);
                        $code = preg_replace('/(?:^\\s*<!--\\s*|\\s*(?:\\/\\/)?\\s*-->\\s*$)/','',$code);
                        $this->scripts[] = 'INLINE;'.$code;
                    } else {
                        // Can we move this?
                        $autoptimize_js_moveable = apply_filters( 'autoptimize_js_moveable', '', $tag );
                        if( $this->ismovable($tag) || $autoptimize_js_moveable !== '' ) {
                            if( $this->movetolast($tag) || $autoptimize_js_moveable === 'last' ) {
                                $this->move['last'][] = $tag;
                            } else {
                                $this->move['first'][] = $tag;
                            }
                        } else {
                            //We shouldn't touch this
                            $tag = '';
                        }
                    }
                    // re-hide comments to be able to do the removal based on tag from $this->content
                    $tag = $this->hide_comments($tag);
                }
                
                //Remove the original script tag
                $this->content = str_replace($tag,'',$this->content);
            }
            
            return true;
        }
    
        // No script files, great ;-)
        return false;
    }