Config::__construct() - Code Metrics - Inspection of "Merge tag '2.0.0' into develop" - fusible/fusible.view-provider - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8060c5...f5ccfa )

by jake

created 2017-07-27 05:08 UTC

Config::__construct() A

↳ Parent: Config

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	3

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
ccs	2
cts	2
cp	1
rs	9.4285
cc	3
eloc	8
nc	4
nop	2
crap	3

<?php
/**
 * Aura\View Provider for Aura\Di
 *
 * PHP version 5
 *
 * Copyright (C) 2016 Jake Johns
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 *
 * @category  Config
 * @package   Fusible\ViewProvider
 * @author    Jake Johns <[email protected]>
 * @copyright 2016 Jake Johns
 * @license   http://jnj.mit-license.org/2016 MIT License
 * @link      https://github.com/fusible/fusible.view-provider
 */

namespace Fusible\ViewProvider;

use Aura\Di\Container;
use Aura\Di\ConfigCollection;

/**
 * Config
 *
 * @category Config
 * @package  Fusible\ViewProvider
 * @author   Jake Johns <[email protected]>
 * @license  http://jnj.mit-license.org/2016 MIT License
 * @link     https://github.com/fusible/fusible.view-provider
 *
 * @see ContainerConfig
 */
class Config extends ConfigCollection
{
    protected $configs = [];

    /**
     * __construct
     *
     * @param mixed $templates DESCRIPTION
     * @param array $helpers   DESCRIPTION
     *
     * @return mixed

     *
     * @access public
     */
    public function __construct($templates = null, array $helpers = [])
    {
        $this->configs = [
            ViewConfig::class => new ViewConfig,
            ViewHelperConfig::class => new ViewHelperConfig
        ];

        if ($templates) {
            $this->view()->addTemplatePath($templates);
        }

        if ($helpers) {

            $this->helper()->addHelpers($helpers);
        }
    }

    /**
     * View
     *
     * @return mixed
     *
     * @access public
     */
    public function view()
    {
        return $this->configs[ViewConfig::class];
    }

    /**
     * Helper
     *
     * @return mixed
     * @throws exceptionclass [description]
     *
     * @access public
     */
    public function helper()
    {
        return $this->configs[ViewHelperConfig::class];
    }
}


1		<?php
2		/**
3		* Aura\View Provider for Aura\Di
4		*
5		* PHP version 5
6		*
7		* Copyright (C) 2016 Jake Johns
8		*
9		* This software may be modified and distributed under the terms
10		* of the MIT license. See the LICENSE file for details.
11		*
12		* @category Config
13		* @package Fusible\ViewProvider
14		* @author Jake Johns <[email protected]>
15		* @copyright 2016 Jake Johns
16		* @license http://jnj.mit-license.org/2016 MIT License
17		* @link https://github.com/fusible/fusible.view-provider
18		*/
19
20		namespace Fusible\ViewProvider;
21
22		use Aura\Di\Container;
23		use Aura\Di\ConfigCollection;
24
25		/**
26		* Config
27		*
28		* @category Config
29		* @package Fusible\ViewProvider
30		* @author Jake Johns <[email protected]>
31		* @license http://jnj.mit-license.org/2016 MIT License
32		* @link https://github.com/fusible/fusible.view-provider
33		*
34		* @see ContainerConfig
35		*/
36		class Config extends ConfigCollection
37		{
38		protected $configs = [];
39
40		/**
41		* __construct
42		*
43		* @param mixed $templates DESCRIPTION
44		* @param array $helpers DESCRIPTION
45		*
46		* @return mixed
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-07-27 05:11 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
47		*
48		* @access public
49		*/
50		public function __construct($templates = null, array $helpers = [])
51		{
52		$this->configs = [
53		ViewConfig::class => new ViewConfig,
54		ViewHelperConfig::class => new ViewHelperConfig
55		];
56
57		if ($templates) {
58		$this->view()->addTemplatePath($templates);
59		}
60
61	9	if ($helpers) {
		0 ignored issues – show Bug Best Practice introduced 2017-07-27 05:11 UTC by Report Bug Copy Issue Report The expression `$helpers` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
62		$this->helper()->addHelpers($helpers);
63		}
64	9	}
65	9
66	9	/**
67	9	* View
68		*
69	9	* @return mixed
70	9	*
71	9	* @access public
72	9	*/
73		public function view()
74	9	{
75	9	return $this->configs[ViewConfig::class];
76		}
77	9
78	9	/**
79	9	* Helper
80	9	*
81		* @return mixed
82	9	* @throws exceptionclass [description]
83	9	*
84	9	* @access public
85	9	*/
86		public function helper()
87	9	{
88	9	return $this->configs[ViewHelperConfig::class];
89	9	}
90		}
91

fusible / fusible.view-provider

Push — develop ( 8060c5...f5ccfa )

Config::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like