Config::define() - Code Metrics - Inspection of "Merge branch 'release/0.2.0'" - fusible/fusible.auth-provider - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 317e01 )

by jake

created 2016-10-25 20:30 UTC

Config::define() A

↳ Parent: Config

Complexity

Conditions	3
Paths	4

Size

Total Lines	52
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	3.6869

Importance

Changes

Metric	Value
dl	0
loc	52
ccs	19
cts	33
cp	0.5758
rs	9.4929
c	0
b	0
f	0
cc	3
eloc	32
nc	4
nop	1
crap	3.6869

How to fix Long Method

<?php
/**
 * Aura\Auth Provider for Aura\Di
 *
 * PHP version 5
 *
 * Copyright (C) 2016 Jake Johns
 *
 * This software may be modified and distributed under the terms
 * of the MIT license.  See the LICENSE file for details.
 *
 * @category  Config
 * @package   Fusible\AuthProvider
 * @author    Jake Johns <[email protected]>
 * @copyright 2016 Jake Johns
 * @license   http://jnj.mit-license.org/2016 MIT License
 * @link      https://github.com/fusible/fusible.auth-provider
 */

namespace Fusible\AuthProvider;

use Aura\Di\Container;
use Aura\Di\ContainerConfig;

use Aura\Auth\AuthFactory as Factory;
use Aura\Auth\Adapter\NullAdapter;

/**
 * Config
 *
 * @category Config
 * @package  Fusible\AuthProvider
 * @author   Jake Johns <[email protected]>
 * @license  http://jnj.mit-license.org/2016 MIT License
 * @link     https://github.com/fusible/fusible.auth-provider
 *
 * @see ContainerConfig
 */
class Config extends ContainerConfig
{
    const COOKIE = 'cookie';

    const FACTORY = 'aura/auth:factory';
    const ADAPTER = 'aura/auth:adapter';

    const AUTH   = 'aura/auth:auth';

    const LOGIN  = 'aura/auth:login';
    const LOGOUT = 'aura/auth:logout';
    const RESUME = 'aura/auth:resume';


    /**
     * Cookie
     *
     * @var array
     *
     * @access protected
     */
    protected $cookie;

    /**
     * __construct
     *
     * @param array $cookie Cookie array
     *
     * @access public
     */
    public function __construct(array $cookie = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->cookie = (null === $cookie) ? $_COOKIE : $cookie;
    }

    /**
     * Define Aura\Auth factories and services
     *
     * @param Container $di DI Container
     *
     * @return void
     *
     * @access public
     *
     * @SuppressWarnings(PHPMD.ShortVariable)
     */
    public function define(Container $di)
    {
        if (! isset($di->values[static::COOKIE])) {
            $di->values[static::COOKIE] = $this->cookie;
        }

        $di->params[Factory::class]['cookie'] = $di->lazyValue(static::COOKIE);

        $di->set(
            static::FACTORY,
            $di->lazyNew(Factory::class)
        );

        if (! $di->has(static::ADAPTER)) {
            $di->set(
                static::ADAPTER,
                $di->lazyNew(NullAdapter::class)
            );
        }

        $di->set(
            static::AUTH,
            $di->lazyGetCall(static::FACTORY, 'newInstance')
        );

        $di->set(
            static::LOGIN,
            $di->lazyGetCall(
                static::FACTORY,
                'newLoginService',
                $di->lazyGet(static::ADAPTER)
            )
        );

        $di->set(
            static::LOGOUT,
            $di->lazyGetCall(
                static::FACTORY,
                'newLogoutService',
                $di->lazyGet(static::ADAPTER)
            )
        );

        $di->set(
            static::RESUME,
            $di->lazyGetCall(
                static::FACTORY,
                'newResumeService',
                $di->lazyGet(static::ADAPTER)
            )
        );
    }
}


1		<?php
2		/**
3		* Aura\Auth Provider for Aura\Di
4		*
5		* PHP version 5
6		*
7		* Copyright (C) 2016 Jake Johns
8		*
9		* This software may be modified and distributed under the terms
10		* of the MIT license. See the LICENSE file for details.
11		*
12		* @category Config
13		* @package Fusible\AuthProvider
14		* @author Jake Johns <[email protected]>
15		* @copyright 2016 Jake Johns
16		* @license http://jnj.mit-license.org/2016 MIT License
17		* @link https://github.com/fusible/fusible.auth-provider
18		*/
19
20		namespace Fusible\AuthProvider;
21
22		use Aura\Di\Container;
23		use Aura\Di\ContainerConfig;
24
25		use Aura\Auth\AuthFactory as Factory;
26		use Aura\Auth\Adapter\NullAdapter;
27
28		/**
29		* Config
30		*
31		* @category Config
32		* @package Fusible\AuthProvider
33		* @author Jake Johns <[email protected]>
34		* @license http://jnj.mit-license.org/2016 MIT License
35		* @link https://github.com/fusible/fusible.auth-provider
36		*
37		* @see ContainerConfig
38		*/
39		class Config extends ContainerConfig
40		{
41		const COOKIE = 'cookie';
42
43		const FACTORY = 'aura/auth:factory';
44		const ADAPTER = 'aura/auth:adapter';
45
46		const AUTH = 'aura/auth:auth';
47
48		const LOGIN = 'aura/auth:login';
49		const LOGOUT = 'aura/auth:logout';
50		const RESUME = 'aura/auth:resume';
51
52
53		/**
54		* Cookie
55		*
56		* @var array
57		*
58		* @access protected
59		*/
60		protected $cookie;
61
62		/**
63		* __construct
64		*
65		* @param array $cookie Cookie array
66		*
67		* @access public
68		*/
69	7	public function __construct(array $cookie = null)
		0 ignored issues – show Coding Style introduced 2016-03-05 16:39 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
70		{
71	7	$this->cookie = (null === $cookie) ? $_COOKIE : $cookie;
72		}
73
74		/**
75		* Define Aura\Auth factories and services
76		*
77		* @param Container $di DI Container
78		*
79		* @return void
80		*
81		* @access public
82		*
83		* @SuppressWarnings(PHPMD.ShortVariable)
84		*/
85	7	public function define(Container $di)
86		{
87		if (! isset($di->values[static::COOKIE])) {
88		$di->values[static::COOKIE] = $this->cookie;
89		}
90
91		$di->params[Factory::class]['cookie'] = $di->lazyValue(static::COOKIE);
92
93		$di->set(
94	7	static::FACTORY,
95	7	$di->lazyNew(Factory::class)
96		);
97
98		if (! $di->has(static::ADAPTER)) {
99		$di->set(
100	7	static::ADAPTER,
101	7	$di->lazyNew(NullAdapter::class)
102		);
103		}
104
105		$di->set(
106	7	static::AUTH,
107	7	$di->lazyGetCall(static::FACTORY, 'newInstance')
108		);
109
110		$di->set(
111	7	static::LOGIN,
112		$di->lazyGetCall(
113	7	static::FACTORY,
114	7	'newLoginService',
115	7	$di->lazyGet(static::ADAPTER)
116		)
117		);
118
119		$di->set(
120	7	static::LOGOUT,
121		$di->lazyGetCall(
122	7	static::FACTORY,
123	7	'newLogoutService',
124	7	$di->lazyGet(static::ADAPTER)
125		)
126		);
127
128		$di->set(
129	7	static::RESUME,
130		$di->lazyGetCall(
131	7	static::FACTORY,
132	7	'newResumeService',
133	7	$di->lazyGet(static::ADAPTER)
134		)
135		);
136		}
137		}
138

fusible / fusible.auth-provider

GitHub Access Token became invalid

Push — master ( 317e01 )

Config::define() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like