Furic\RedeemCodes\Http\Controllers\RedeemController::redeem()

Complexity

Conditions	7
Paths	8

Size

Total Lines	45
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function redeem($code)
    {
        $validator = Validator::make(['code' => $code], ['code' => 'exists:redeem_codes,code']);
        if ($validator->fails()) {
            return response([
                'error' => 'No redeem code found.'
            ], 400);
        }

        $redeemCode = RedeemCode::findByCode($code);

        if ($redeemCode->redeemed != false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            return response([
                'error' => 'Redeem code has already redeemed.'
            ], 400);
        }

        // Check event valid date
        $event = $redeemCode->event;
        if ($event != null) {
            $validator = Validator::make($event->toArray(), ['start_at' => 'before:tomorrow']);
            if ($validator->fails()) {
                return response([
                    'error' => 'Redeem code cannot be used yet.'
                ], 400);
            }
            $validator = Validator::make($event->toArray(), ['end_at' => 'after:yesterday']);
            if ($validator->fails()) {
                return response([
                    'error' => 'Redeem code has expired.'
                ], 400);
            }
        }

        if ($redeemCode->reusable == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $redeemCode->setRedeemed();
        }

        // Add a redeem code history
        $data['redeem_code_id'] = $redeemCode->id;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['ip'] = filter_input(INPUT_SERVER, "REMOTE_ADDR");
        $data['agent'] = filter_input(INPUT_SERVER, "HTTP_USER_AGENT");
        RedeemCodeHistory::create($data);

        return $redeemCode;
    }