Checkbox - Code Metrics - Inspection of "fixed #18 Bug witch checkbox" - funivan/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 897b5a...5205fa )

by Shcherbak

created 2016-03-25 08:16 UTC

Checkbox A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	9
c	2
b	1
f	0
lcom	2
cbo	1
dl	0
loc	87
rs	10

6 Methods

Rating	Name	Size	Complexity
A	setValue()	12	4
A	check()	5	1
A	unCheck()	5	1
A	isChecked()	3	1
A	setLabel()	4	1
A	render()	3	1

<?php

  namespace Fiv\Form\Element;

  use Fiv\Form\Element;

  /**
   * Generate <input type="submit" /> element
   *
   * @author Ivan Shcherbak <[email protected]>
   * @package Fiv\Form
   */
  class Checkbox extends Element\Input {

    /**
     * @var int
     */
    protected $value = 0;

    /**
     * @var string
     */
    protected $label = '';

    /**
     * @var array
     */
    protected $attributes = [
      'type' => 'checkbox',
    ];


    /**
     * Value in checkbox can be true or false
     *
     * @param int $value
     * @return $this
     */
    public function setValue($value) {
      if ($value !== 1 and $value !== 0) {
        throw new \InvalidArgumentException('Expect int: 1 or 0');
      }

      if ($value === 1) {
        return $this->check();
      } else {
        return $this->unCheck();
      }

    }


    /**
     * @return $this
     */
    public function check() {
      $this->setAttribute('checked', 'checked');
      parent::setValue(1);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
      return $this;
    }


    /**
     * Set value to 0
     * @return $this
     */
    public function unCheck() {
      $this->removeAttribute('checked');
      parent::setValue(0);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
      return $this;
    }


    /**
     * @return bool
     */
    public function isChecked() {
      return $this->getValue() === 1;
    }


    /**
     * @param string $text
     * @return $this
     */
    public function setLabel($text) {
      $this->label = $text;
      return $this;
    }


    /**
     * @return string
     */
    public function render() {
      return '<label>' . parent::render() . $this->label . '</label>';
    }

  }

1			<?php
2
3			namespace Fiv\Form\Element;
4
5			use Fiv\Form\Element;
6
7			/**
8			* Generate <input type="submit" /> element
9			*
10			* @author Ivan Shcherbak <[email protected]>
11			* @package Fiv\Form
12			*/
13			class Checkbox extends Element\Input {
14
15			/**
16			* @var int
17			*/
18			protected $value = 0;
19
20			/**
21			* @var string
22			*/
23			protected $label = '';
24
25			/**
26			* @var array
27			*/
28			protected $attributes = [
29			'type' => 'checkbox',
30			];
31
32
33			/**
34			* Value in checkbox can be true or false
35			*
36			* @param int $value
37			* @return $this
38			*/
39			public function setValue($value) {
40			if ($value !== 1 and $value !== 0) {
41			throw new \InvalidArgumentException('Expect int: 1 or 0');
42			}
43
44			if ($value === 1) {
45			return $this->check();
46			} else {
47			return $this->unCheck();
48			}
49
50			}
51
52
53			/**
54			* @return $this
55			*/
56			public function check() {
57			$this->setAttribute('checked', 'checked');
58			parent::setValue(1);
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-18 09:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setValue()` instead of `check()`). Are you sure this is correct? If so, you might want to change this to `$this->setValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
59			return $this;
60			}
61
62
63			/**
64			* Set value to 0
65			* @return $this
66			*/
67			public function unCheck() {
68			$this->removeAttribute('checked');
69			parent::setValue(0);
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-18 09:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`setValue()` instead of `unCheck()`). Are you sure this is correct? If so, you might want to change this to `$this->setValue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
70			return $this;
71			}
72
73
74			/**
75			* @return bool
76			*/
77			public function isChecked() {
78			return $this->getValue() === 1;
79			}
80
81
82			/**
83			* @param string $text
84			* @return $this
85			*/
86			public function setLabel($text) {
87			$this->label = $text;
88			return $this;
89			}
90
91
92			/**
93			* @return string
94			*/
95			public function render() {
96			return '<label>' . parent::render() . $this->label . '</label>';
97			}
98
99			}

funivan / form

Push — master ( 897b5a...5205fa )

Checkbox A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like