CheckboxList - Code Metrics - Inspection of "remove default value from formData" - funivan/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 739745...1116f8 )

by Shcherbak

created 2016-05-30 10:06 UTC

CheckboxList A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

85.71%

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	12
c	4
b	1
f	1
lcom	1
cbo	2
dl	0
loc	92
ccs	30
cts	35
cp	0.8571
rs	10

6 Methods

Rating	Name	Size	Complexity
A	handle()	10	2
A	setValue()	15	4
A	getValue()	3	1
A	isChecked()	3	1
A	setChecked()	3	1
A	render()	22	3

<?php

  namespace Fiv\Form\Element;

  use Fiv\Form\FormData;


  /**
   * Class TextArea
   * Generate
   * ```html
   * <input type="checkbox" name="languages[]" value="en">
   * <input type="checkbox" name="languages[]" value="ru">
   * ```
   * html tags
   *
   * @author  Ivan Shcherbak <[email protected]>
   * @package Fiv\Form
   */
  class CheckboxList extends Multiple {

    /**
     * @inheritdoc
     */
    public function handle(FormData $data) {
      $values = $data->get($this->getName());
      if ($values === null) {
        $values = [];
      } else {
        $values = (array) $values;
      }

      $this->setValue($values);
    }


    /**
     * @param array|string $data
     * @return $this
     */
    public function setValue($data) {
      if (!is_array($data)) {
        $data = (array) $data;
      }

      foreach ($data as $i => $value) {
        # remove invalid values
        if (!isset($this->options[$value])) {
          unset($data[$i]);
        }
      }

      $this->value = array_values($data);

      return $this;
    }


    /**
     * @return array
     */
    public function getValue() {
      return (array) parent::getValue();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }


    /**
     * @param string $optionKey
     * @return bool
     */
    public function isChecked($optionKey) {
      return in_array($optionKey, $this->getValue());
    }


    /**
     * Alias of setValue
     *
     * @param string[] $values
     * @return $this
     */
    public function setChecked($values) {
      return $this->setValue($values);
    }


    /**
     * @return string
     */
    public function render() {
      $html = '';
      $currentValues = $this->getValue();
      $attributes = $this->attributes;
      $attributes['type'] = 'checkbox';

      $name = $this->getName();

      foreach ($this->options as $value => $text) {
        $attributes['value'] = $value;
        $attributes['name'] = $name . '[]';
        if (in_array($value, $currentValues)) {
          $attributes['checked'] = 'checked';
        } else {
          unset($attributes['checked']);
        }

        $html .= '<label>' . static::tag('input', $attributes) . $text . '</label>';
      }

      return $html;
    }
  }

1		<?php
2
3		namespace Fiv\Form\Element;
4
5		use Fiv\Form\FormData;
6
7
8		/**
9		* Class TextArea
10		* Generate
11		* ```html
12		* <input type="checkbox" name="languages[]" value="en">
13		* <input type="checkbox" name="languages[]" value="ru">
14		* ```
15		* html tags
16		*
17		* @author Ivan Shcherbak <[email protected]>
18		* @package Fiv\Form
19		*/
20		class CheckboxList extends Multiple {
21
22		/**
23		* @inheritdoc
24		*/
25	1	public function handle(FormData $data) {
26	1	$values = $data->get($this->getName());
27	1	if ($values === null) {
28		$values = [];
29		} else {
30	1	$values = (array) $values;
31		}
32
33	1	$this->setValue($values);
34	1	}
35
36
37		/**
38		* @param array\|string $data
39		* @return $this
40		*/
41	1	public function setValue($data) {
42	1	if (!is_array($data)) {
43		$data = (array) $data;
44		}
45
46	1	foreach ($data as $i => $value) {
47		# remove invalid values
48	1	if (!isset($this->options[$value])) {
49	1	unset($data[$i]);
50		}
51		}
52
53	1	$this->value = array_values($data);
		0 ignored issues – show Documentation Bug introduced 2016-01-18 09:56 UTC by Report Bug Copy Issue Report It seems like `array_values($data)` of type `array<integer,?>` is incompatible with the declared type `null\|string` of property `$value`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
54	1	return $this;
55		}
56
57
58		/**
59		* @return array
60		*/
61	2	public function getValue() {
62	2	return (array) parent::getValue();
		0 ignored issues – show Bug Best Practice introduced 2016-05-25 06:57 UTC by Report Bug Copy Issue Report The return type of `return (array) parent::getValue();` (`array`) is incompatible with the return type of the parent method `Fiv\Form\Element\BaseElement::getValue` of type `null\|string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
63		}
64
65
66		/**
67		* @param string $optionKey
68		* @return bool
69		*/
70	1	public function isChecked($optionKey) {
71	1	return in_array($optionKey, $this->getValue());
72		}
73
74
75		/**
76		* Alias of setValue
77		*
78		* @param string[] $values
79		* @return $this
80		*/
81		public function setChecked($values) {
82		return $this->setValue($values);
83		}
84
85
86		/**
87		* @return string
88		*/
89	1	public function render() {
90	1	$html = '';
91	1	$currentValues = $this->getValue();
92	1	$attributes = $this->attributes;
93	1	$attributes['type'] = 'checkbox';
94
95	1	$name = $this->getName();
96
97	1	foreach ($this->options as $value => $text) {
98	1	$attributes['value'] = $value;
99	1	$attributes['name'] = $name . '[]';
100	1	if (in_array($value, $currentValues)) {
101		$attributes['checked'] = 'checked';
102		} else {
103	1	unset($attributes['checked']);
104		}
105
106	1	$html .= '<label>' . static::tag('input', $attributes) . $text . '</label>';
107		}
108
109	1	return $html;
110		}
111		}

funivan / form

Push — master ( 739745...1116f8 )

CheckboxList A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like