ExampleMessageForm::isValid() - Code Metrics - Inspection of "#22 fixed" - funivan/form - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by Vitaliy

created 2016-05-23 10:45 UTC

ExampleMessageForm::isValid() B

↳ Parent: ExampleMessageForm

Complexity

Conditions	5
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	16
rs	8.8571
cc	5
eloc	10
nc	3
nop	0

<?php

  namespace Tests\Form;

  use Fiv\Form\Form;

  /**
   *
   */
  class ExampleMessageForm extends Form {

    /**
     * @return bool
     */
    public function isValid() {
      if (!parent::isValid()) {
        return false;
      }

      if (
        $this->getElements()['emailFrom']->getValue() == '[email protected]'
        and $this->getElements()['emailTo']->getValue() == '[email protected]'
        and $this->getElements()['message']->getValue() == 'copy message text'
      ) {
        $this->validationResult = false;
        $this->addError('message duplicate error');
      }

      return $this->validationResult;
    }

  }

  /**
   *
   */
  class AdvancedFormValidationTest extends \PHPUnit_Framework_TestCase {


    /**
     *
     */
    public function testFormValidation() {
      $form = new ExampleMessageForm();
      $form->input('emailFrom');
      $form->input('emailTo');
      $form->input('message');

      $form->setData([
        $form->getUid() => 1,
        'emailFrom' => '[email protected]',
        'emailTo' => '[email protected]',
        'message' => 'new message text',
      ]);
      $this->assertTrue($form->isValid());
      $this->assertEquals([], $form->getErrors());

      $form->setData([
        $form->getUid() => 1,
        'emailFrom' => '[email protected]',
        'emailTo' => '[email protected]',
        'message' => 'copy message text',
      ]);
      $this->assertFalse($form->isValid());
      $this->assertEquals(['message duplicate error'], $form->getErrors());
    }

  }

1			<?php
2
3			namespace Tests\Form;
4
5			use Fiv\Form\Form;
6
7			/**
8			*
9			*/
10			class ExampleMessageForm extends Form {
11
12			/**
13			* @return bool
14			*/
15			public function isValid() {
16			if (!parent::isValid()) {
17			return false;
18			}
19
20			if (
21			$this->getElements()['emailFrom']->getValue() == '[email protected]'
22			and $this->getElements()['emailTo']->getValue() == '[email protected]'
23			and $this->getElements()['message']->getValue() == 'copy message text'
24			) {
25			$this->validationResult = false;
26			$this->addError('message duplicate error');
27			}
28
29			return $this->validationResult;
30			}
31
32			}
33
34			/**
35			*
36			*/
37			class AdvancedFormValidationTest extends \PHPUnit_Framework_TestCase {
38
39
40			/**
41			*
42			*/
43			public function testFormValidation() {
44			$form = new ExampleMessageForm();
45			$form->input('emailFrom');
46			$form->input('emailTo');
47			$form->input('message');
48
49			$form->setData([
50			$form->getUid() => 1,
51			'emailFrom' => '[email protected]',
52			'emailTo' => '[email protected]',
53			'message' => 'new message text',
54			]);
55			$this->assertTrue($form->isValid());
56			$this->assertEquals([], $form->getErrors());
57
58			$form->setData([
59			$form->getUid() => 1,
60			'emailFrom' => '[email protected]',
61			'emailTo' => '[email protected]',
62			'message' => 'copy message text',
63			]);
64			$this->assertFalse($form->isValid());
65			$this->assertEquals(['message duplicate error'], $form->getErrors());
66			}
67
68			}

funivan / form

Pull Request — master (#23)

ExampleMessageForm::isValid() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like